Title: [264624] trunk/Source/WebKit
- Revision
- 264624
- Author
- [email protected]
- Date
- 2020-07-20 15:20:21 -0700 (Mon, 20 Jul 2020)
Log Message
Web Inspector: developerExtrasEnabled should be respected when opening local Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=214573
<rdar://problem/65848496>
Reviewed by David Kilzer.
Ensure that WKPreferences.developerExtrasEnabled is true prior to opening a Web Inspector
window. This matches the check in WebCore when deciding to show "Inspect Element" menu item.
* UIProcess/Inspector/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::openLocalInspectorFrontend):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264623 => 264624)
--- trunk/Source/WebKit/ChangeLog 2020-07-20 22:16:41 UTC (rev 264623)
+++ trunk/Source/WebKit/ChangeLog 2020-07-20 22:20:21 UTC (rev 264624)
@@ -1,3 +1,18 @@
+2020-07-20 Brian Burg <[email protected]>
+
+ Web Inspector: developerExtrasEnabled should be respected when opening local Web Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=214573
+ <rdar://problem/65848496>
+
+ Reviewed by David Kilzer.
+
+ Ensure that WKPreferences.developerExtrasEnabled is true prior to opening a Web Inspector
+ window. This matches the check in WebCore when deciding to show "Inspect Element" menu item.
+
+ * UIProcess/Inspector/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::connect):
+ (WebKit::WebInspectorProxy::openLocalInspectorFrontend):
+
2020-07-20 Adrian Perez de Castro <[email protected]>
[WPE] WebPopupItem should always be forward declared as struct
Modified: trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp (264623 => 264624)
--- trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp 2020-07-20 22:16:41 UTC (rev 264623)
+++ trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp 2020-07-20 22:20:21 UTC (rev 264624)
@@ -120,6 +120,9 @@
if (!m_inspectedPage)
return;
+ if (!m_inspectedPage->preferences().developerExtrasEnabled())
+ return;
+
if (m_showMessageSent)
return;
@@ -414,6 +417,9 @@
if (!m_inspectedPage)
return;
+ if (!m_inspectedPage->preferences().developerExtrasEnabled())
+ return;
+
if (m_inspectedPage->inspectorController().hasLocalFrontend()) {
show();
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
