Title: [264634] trunk/LayoutTests
- Revision
- 264634
- Author
- [email protected]
- Date
- 2020-07-20 16:32:35 -0700 (Mon, 20 Jul 2020)
Log Message
Reduce number of iterations for weakref tests
https://bugs.webkit.org/show_bug.cgi?id=214567
Reviewed by Mark Lam.
These tests seem to time out on the watch series 3 simulator. Let's reduce the number of
iterations and see if it impacts the flakiness of the test.
* js/script-tests/weakref-async-is-collected.js:
(turnEventLoop):
* js/script-tests/weakref-eventually-collects-values.js:
(turnEventLoop):
* js/script-tests/weakref-microtasks-dont-collect.js:
(turnEventLoop):
* js/script-tests/weakref-weakset-consistency.js:
(turnEventLoop):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264633 => 264634)
--- trunk/LayoutTests/ChangeLog 2020-07-20 23:28:28 UTC (rev 264633)
+++ trunk/LayoutTests/ChangeLog 2020-07-20 23:32:35 UTC (rev 264634)
@@ -1,3 +1,22 @@
+2020-07-20 Keith Miller <[email protected]>
+
+ Reduce number of iterations for weakref tests
+ https://bugs.webkit.org/show_bug.cgi?id=214567
+
+ Reviewed by Mark Lam.
+
+ These tests seem to time out on the watch series 3 simulator. Let's reduce the number of
+ iterations and see if it impacts the flakiness of the test.
+
+ * js/script-tests/weakref-async-is-collected.js:
+ (turnEventLoop):
+ * js/script-tests/weakref-eventually-collects-values.js:
+ (turnEventLoop):
+ * js/script-tests/weakref-microtasks-dont-collect.js:
+ (turnEventLoop):
+ * js/script-tests/weakref-weakset-consistency.js:
+ (turnEventLoop):
+
2020-07-20 Hector Lopez <[email protected]>
[ Release Mac wk2 ] svg/animations/smil-leak-list-property-instances.svg is a flaky failure
Modified: trunk/LayoutTests/js/script-tests/weakref-async-is-collected.js (264633 => 264634)
--- trunk/LayoutTests/js/script-tests/weakref-async-is-collected.js 2020-07-20 23:28:28 UTC (rev 264633)
+++ trunk/LayoutTests/js/script-tests/weakref-async-is-collected.js 2020-07-20 23:32:35 UTC (rev 264634)
@@ -4,12 +4,11 @@
function makeWeakRef() { return new WeakRef({foo: 1 }); }
noInline(makeWeakRef);
-let loopCount = 10000;
+// Turns out the test times out if we turn the event loop 10000 times...
+let loopCount = globalThis.window ? 300 : 10000;
function turnEventLoop() {
return new Promise(function(resolve, reject) {
if (globalThis.window) {
- // Turns out the test times out if we turn the event loop 10000 times...
- loopCount = 1000;
window.setTimeout(() => {
resolve();
}, 0);
Modified: trunk/LayoutTests/js/script-tests/weakref-eventually-collects-values.js (264633 => 264634)
--- trunk/LayoutTests/js/script-tests/weakref-eventually-collects-values.js 2020-07-20 23:28:28 UTC (rev 264633)
+++ trunk/LayoutTests/js/script-tests/weakref-eventually-collects-values.js 2020-07-20 23:32:35 UTC (rev 264634)
@@ -5,12 +5,11 @@
function makeWeakRef() { return new WeakRef({foo: 1}); }
noInline(makeWeakRef);
-let loopCount = 10000;
+// Turns out the test times out if we turn the event loop 10000 times...
+let loopCount = globalThis.window ? 300 : 10000;
function turnEventLoop() {
return new Promise(function(resolve, reject) {
if (globalThis.window) {
- // Turns out the test times out if we turn the event loop 10000 times...
- loopCount = 1000;
window.setTimeout(() => {
resolve();
}, 0);
Modified: trunk/LayoutTests/js/script-tests/weakref-microtasks-dont-collect.js (264633 => 264634)
--- trunk/LayoutTests/js/script-tests/weakref-microtasks-dont-collect.js 2020-07-20 23:28:28 UTC (rev 264633)
+++ trunk/LayoutTests/js/script-tests/weakref-microtasks-dont-collect.js 2020-07-20 23:32:35 UTC (rev 264634)
@@ -5,13 +5,11 @@
function makeWeakRef() { return new WeakRef({foo: 1 }); }
noInline(makeWeakRef);
-let loopCount = 10000;
-
+// Turns out the test times out if we turn the event loop 10000 times...
+let loopCount = globalThis.window ? 300 : 10000;
function turnEventLoop() {
return new Promise(function(resolve, reject) {
if (globalThis.window) {
- // Turns out the test times out if we turn the event loop 10000 times...
- loopCount = 1000;
window.setTimeout(() => {
resolve();
}, 0);
Modified: trunk/LayoutTests/js/script-tests/weakref-weakset-consistency.js (264633 => 264634)
--- trunk/LayoutTests/js/script-tests/weakref-weakset-consistency.js 2020-07-20 23:28:28 UTC (rev 264633)
+++ trunk/LayoutTests/js/script-tests/weakref-weakset-consistency.js 2020-07-20 23:32:35 UTC (rev 264634)
@@ -4,12 +4,11 @@
function makeWeakRef() { return new WeakRef({foo: 1 }); }
noInline(makeWeakRef);
-let loopCount = 10000;
+// Turns out the test times out if we turn the event loop 10000 times...
+let loopCount = globalThis.window ? 300 : 10000;
function turnEventLoop() {
return new Promise(function(resolve, reject) {
if (globalThis.window) {
- // Turns out the test times out if we turn the event loop 10000 times...
- loopCount = 1000;
window.setTimeout(() => {
resolve();
}, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
