Title: [264753] trunk
Revision
264753
Author
[email protected]
Date
2020-07-23 03:59:53 -0700 (Thu, 23 Jul 2020)

Log Message

Unreviewed, reverting r264745.
https://bugs.webkit.org/show_bug.cgi?id=214681

Broke 3 web-platform-tests on iOS

Reverted changeset:

"iOS simulator does not support WebAssembly"
https://bugs.webkit.org/show_bug.cgi?id=191064
https://trac.webkit.org/changeset/264745

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (264752 => 264753)


--- trunk/LayoutTests/ChangeLog	2020-07-23 10:44:27 UTC (rev 264752)
+++ trunk/LayoutTests/ChangeLog	2020-07-23 10:59:53 UTC (rev 264753)
@@ -1,3 +1,16 @@
+2020-07-23  Commit Queue  <[email protected]>
+
+        Unreviewed, reverting r264745.
+        https://bugs.webkit.org/show_bug.cgi?id=214681
+
+        Broke 3 web-platform-tests on iOS
+
+        Reverted changeset:
+
+        "iOS simulator does not support WebAssembly"
+        https://bugs.webkit.org/show_bug.cgi?id=191064
+        https://trac.webkit.org/changeset/264745
+
 2020-07-23  Mark Lam  <[email protected]>
 
         Fix missing exception checks below RTCPeerConnection.generateCertificate().

Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (264752 => 264753)


--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2020-07-23 10:44:27 UTC (rev 264752)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2020-07-23 10:59:53 UTC (rev 264753)
@@ -41,6 +41,27 @@
 # we explicitly disallow this because this font is too slow.
 fast/text/initial-advance-in-intermediate-run-complex.html [ ImageOnlyFailure ]
 
+# Simulator doesn't support WebAssembly.
+http/tests/security/contentSecurityPolicy/WebAssembly-allowed.html [ Failure ]
+http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-about-blank-iframe.html [ Failure ]
+http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-external-script.html [ Failure ]
+http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ]
+http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ]
+imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.html [ Failure ]
+imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker.html [ Failure ]
+imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-success.any.worker.html [ Failure ]
+wasm/iframe-postmessage.html [ Skip ]
+wasm/iframe-parent-postmessage.html [ Skip ]
+wasm/window-postmessage.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/encodeInto.any.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/encodeInto.any.worker.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.worker.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.worker.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.html [ Skip ]
+imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.worker.html [ Skip ]
+
 # These tests seem to fail due pixel rounding errors in the absolute positioned elements used as reference.
 webkit.org/b/170176 fast/inline-block/baseline-vertical-01.html [ ImageOnlyFailure ]
 webkit.org/b/170176 fast/inline-block/baseline-vertical-02.html [ ImageOnlyFailure ]

Modified: trunk/Source/WTF/ChangeLog (264752 => 264753)


--- trunk/Source/WTF/ChangeLog	2020-07-23 10:44:27 UTC (rev 264752)
+++ trunk/Source/WTF/ChangeLog	2020-07-23 10:59:53 UTC (rev 264753)
@@ -1,3 +1,16 @@
+2020-07-23  Commit Queue  <[email protected]>
+
+        Unreviewed, reverting r264745.
+        https://bugs.webkit.org/show_bug.cgi?id=214681
+
+        Broke 3 web-platform-tests on iOS
+
+        Reverted changeset:
+
+        "iOS simulator does not support WebAssembly"
+        https://bugs.webkit.org/show_bug.cgi?id=191064
+        https://trac.webkit.org/changeset/264745
+
 2020-07-22  Jer Noble  <[email protected]>
 
         [Cocoa] Add feature flag for WebM & VP9

Modified: trunk/Source/WTF/wtf/PlatformEnable.h (264752 => 264753)


--- trunk/Source/WTF/wtf/PlatformEnable.h	2020-07-23 10:44:27 UTC (rev 264752)
+++ trunk/Source/WTF/wtf/PlatformEnable.h	2020-07-23 10:59:53 UTC (rev 264753)
@@ -610,6 +610,13 @@
 #define ENABLE_FTL_JIT 0
 #endif
 
+/* FIXME: This should be turned into an #error invariant */
+/* The FTL is disabled on the iOS simulator, mostly for simplicity. */
+#if PLATFORM(IOS_FAMILY_SIMULATOR)
+#undef ENABLE_FTL_JIT
+#define ENABLE_FTL_JIT 0
+#endif
+
 /* If possible, try to enable a disassembler. This is optional. We proceed in two
    steps: first we try to find some disassembler that we can use, and then we
    decide if the high-level disassembler API can be enabled. */

Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (264752 => 264753)


--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2020-07-23 10:44:27 UTC (rev 264752)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2020-07-23 10:59:53 UTC (rev 264753)
@@ -204,7 +204,7 @@
 #define ENABLE_FILTERS_LEVEL_2 1
 #endif
 
-#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64)
+#if !defined(ENABLE_FTL_JIT) && !USE(JSVALUE32_64) && !PLATFORM(IOS_FAMILY_SIMULATOR)
 #define ENABLE_FTL_JIT 1
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to