Title: [264791] trunk/Source/WebCore
- Revision
- 264791
- Author
- [email protected]
- Date
- 2020-07-23 14:41:11 -0700 (Thu, 23 Jul 2020)
Log Message
[Cocoa] RELEASE_ASSERT when calling registerSupplementalVP9Decoder() when VideoToolbox.framework is not present
https://bugs.webkit.org/show_bug.cgi?id=214697
<rdar://problem/66010949>
Reviewed by Eric Carlson.
* platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::registerSupplementalVP9Decoder):
(WebCore::isVP9DecoderAvailable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264790 => 264791)
--- trunk/Source/WebCore/ChangeLog 2020-07-23 21:21:21 UTC (rev 264790)
+++ trunk/Source/WebCore/ChangeLog 2020-07-23 21:41:11 UTC (rev 264791)
@@ -1,3 +1,15 @@
+2020-07-23 Jer Noble <[email protected]>
+
+ [Cocoa] RELEASE_ASSERT when calling registerSupplementalVP9Decoder() when VideoToolbox.framework is not present
+ https://bugs.webkit.org/show_bug.cgi?id=214697
+ <rdar://problem/66010949>
+
+ Reviewed by Eric Carlson.
+
+ * platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
+ (WebCore::registerSupplementalVP9Decoder):
+ (WebCore::isVP9DecoderAvailable):
+
2020-07-23 Sihui Liu <[email protected]>
Allow IndexedDB in third-party frames
Modified: trunk/Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm (264790 => 264791)
--- trunk/Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm 2020-07-23 21:21:21 UTC (rev 264790)
+++ trunk/Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm 2020-07-23 21:41:11 UTC (rev 264791)
@@ -98,6 +98,9 @@
void registerSupplementalVP9Decoder()
{
+ if (!VideoToolboxLibrary(true))
+ return;
+
if (canLoad_VideoToolbox_VTRegisterSupplementalVideoDecoderIfAvailable())
softLink_VideoToolbox_VTRegisterSupplementalVideoDecoderIfAvailable(kCMVideoCodecType_VP9);
}
@@ -104,6 +107,8 @@
bool isVP9DecoderAvailable()
{
+ if (!VideoToolboxLibrary(true))
+ return false;
return noErr == VTSelectAndCreateVideoDecoderInstance(kCMVideoCodecType_VP9, kCFAllocatorDefault, nullptr, nullptr);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
