Title: [264803] trunk/Source/WebKit
Revision
264803
Author
[email protected]
Date
2020-07-23 15:48:27 -0700 (Thu, 23 Jul 2020)

Log Message

Web Inspector: developerExtrasEnabled should be respected when opening local Web Inspector (part 2)
https://bugs.webkit.org/show_bug.cgi?id=214669

Reviewed by Devin Rousso and Joseph Pecoraro.

* UIProcess/Inspector/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::save):
(WebKit::WebInspectorProxy::append): Add missing check for developerExtrasEnabled.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (264802 => 264803)


--- trunk/Source/WebKit/ChangeLog	2020-07-23 22:35:06 UTC (rev 264802)
+++ trunk/Source/WebKit/ChangeLog	2020-07-23 22:48:27 UTC (rev 264803)
@@ -1,3 +1,14 @@
+2020-07-23  Brian Burg  <[email protected]>
+
+        Web Inspector: developerExtrasEnabled should be respected when opening local Web Inspector (part 2)
+        https://bugs.webkit.org/show_bug.cgi?id=214669
+
+        Reviewed by Devin Rousso and Joseph Pecoraro.
+
+        * UIProcess/Inspector/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::save):
+        (WebKit::WebInspectorProxy::append): Add missing check for developerExtrasEnabled.
+
 2020-07-23  Sihui Liu  <[email protected]>
 
         Allow IndexedDB in third-party frames

Modified: trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp (264802 => 264803)


--- trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp	2020-07-23 22:35:06 UTC (rev 264802)
+++ trunk/Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp	2020-07-23 22:48:27 UTC (rev 264803)
@@ -673,6 +673,9 @@
 
 void WebInspectorProxy::save(const String& filename, const String& content, bool base64Encoded, bool forceSaveAs)
 {
+    if (!m_inspectedPage->preferences().developerExtrasEnabled())
+        return;
+
     ASSERT(!filename.isEmpty());
     if (filename.isEmpty())
         return;
@@ -682,6 +685,9 @@
 
 void WebInspectorProxy::append(const String& filename, const String& content)
 {
+    if (!m_inspectedPage->preferences().developerExtrasEnabled())
+        return;
+
     ASSERT(!filename.isEmpty());
     if (filename.isEmpty())
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to