Title: [264836] trunk
- Revision
- 264836
- Author
- [email protected]
- Date
- 2020-07-24 10:13:22 -0700 (Fri, 24 Jul 2020)
Log Message
ASSERT(!m_peerConnection.isClosed()) on imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https.html
https://bugs.webkit.org/show_bug.cgi?id=214189
<rdar://problem/65343941>
Reviewed by Eric Carlson.
Source/WebCore:
Covered by unskipped tests.
* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::addPendingTrackEvent):
This can be called in case the connection is closed but should not be in case the connection is stopped.
Update the ASSERT accordingly.
LayoutTests:
* TestExpectations: Unskip test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264835 => 264836)
--- trunk/LayoutTests/ChangeLog 2020-07-24 17:10:30 UTC (rev 264835)
+++ trunk/LayoutTests/ChangeLog 2020-07-24 17:13:22 UTC (rev 264836)
@@ -1,3 +1,13 @@
+2020-07-24 Youenn Fablet <[email protected]>
+
+ ASSERT(!m_peerConnection.isClosed()) on imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https.html
+ https://bugs.webkit.org/show_bug.cgi?id=214189
+ <rdar://problem/65343941>
+
+ Reviewed by Eric Carlson.
+
+ * TestExpectations: Unskip test.
+
2020-07-24 Hector Lopez <[email protected]>
[ macOS ] svg/wicd/test-rightsizing-b.xhtml is passing and expectation needs to be removed
Modified: trunk/LayoutTests/TestExpectations (264835 => 264836)
--- trunk/LayoutTests/TestExpectations 2020-07-24 17:10:30 UTC (rev 264835)
+++ trunk/LayoutTests/TestExpectations 2020-07-24 17:13:22 UTC (rev 264836)
@@ -1914,9 +1914,6 @@
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-timing.https.html [ Pass Failure ]
imported/w3c/web-platform-tests/webrtc/protocol/split.https.html [ Pass Failure ]
-# This test has been consistently crashing in Debug since import.
-webkit.org/b/214189 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https.html [ Skip ]
-
# Skip timing out test
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html [ Skip ]
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-remote-track-mute.https.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (264835 => 264836)
--- trunk/Source/WebCore/ChangeLog 2020-07-24 17:10:30 UTC (rev 264835)
+++ trunk/Source/WebCore/ChangeLog 2020-07-24 17:13:22 UTC (rev 264836)
@@ -1,3 +1,18 @@
+2020-07-24 Youenn Fablet <[email protected]>
+
+ ASSERT(!m_peerConnection.isClosed()) on imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-operations.https.html
+ https://bugs.webkit.org/show_bug.cgi?id=214189
+ <rdar://problem/65343941>
+
+ Reviewed by Eric Carlson.
+
+ Covered by unskipped tests.
+
+ * Modules/mediastream/PeerConnectionBackend.cpp:
+ (WebCore::PeerConnectionBackend::addPendingTrackEvent):
+ This can be called in case the connection is closed but should not be in case the connection is stopped.
+ Update the ASSERT accordingly.
+
2020-07-24 Xabier Rodriguez Calvar <[email protected]>
[GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)' failed
Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (264835 => 264836)
--- trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2020-07-24 17:10:30 UTC (rev 264835)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2020-07-24 17:13:22 UTC (rev 264836)
@@ -299,7 +299,7 @@
void PeerConnectionBackend::addPendingTrackEvent(PendingTrackEvent&& event)
{
- ASSERT(!m_peerConnection.isClosed());
+ ASSERT(!m_peerConnection.isStopped());
m_pendingTrackEvents.append(WTFMove(event));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
