Title: [264868] trunk/LayoutTests
- Revision
- 264868
- Author
- [email protected]
- Date
- 2020-07-24 16:18:19 -0700 (Fri, 24 Jul 2020)
Log Message
REGRESSION (r264690): [ iOS wk2 ] editing/selection/shift-click-includes-existing-selection.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=214688
<rdar://problem/65993683>
Reviewed by Darin Adler.
On iOS, this test simulates a "Shift + tap" and verifies that it extends an existing selection. However, it's
possible for this test to fail if the selection view appears before the tap completes, since the tap may be too
close to one of the selection handle views, causing `-[UITextRangeView gestureRecognizerShouldBegin:]` to return
`NO` and cause the synthetic click gesture to fail in favor of toggling the visibility of the callout bar above
the selection view.
Mitigate this by simply adding a large margin between the existing selection and the tap location, to which the
test attempts to extend the selection.
* editing/selection/shift-click-includes-existing-selection.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264867 => 264868)
--- trunk/LayoutTests/ChangeLog 2020-07-24 23:15:07 UTC (rev 264867)
+++ trunk/LayoutTests/ChangeLog 2020-07-24 23:18:19 UTC (rev 264868)
@@ -1,3 +1,22 @@
+2020-07-24 Wenson Hsieh <[email protected]>
+
+ REGRESSION (r264690): [ iOS wk2 ] editing/selection/shift-click-includes-existing-selection.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=214688
+ <rdar://problem/65993683>
+
+ Reviewed by Darin Adler.
+
+ On iOS, this test simulates a "Shift + tap" and verifies that it extends an existing selection. However, it's
+ possible for this test to fail if the selection view appears before the tap completes, since the tap may be too
+ close to one of the selection handle views, causing `-[UITextRangeView gestureRecognizerShouldBegin:]` to return
+ `NO` and cause the synthetic click gesture to fail in favor of toggling the visibility of the callout bar above
+ the selection view.
+
+ Mitigate this by simply adding a large margin between the existing selection and the tap location, to which the
+ test attempts to extend the selection.
+
+ * editing/selection/shift-click-includes-existing-selection.html:
+
2020-07-24 Tadeu Zagallo <[email protected]>
WKStringGetMaximumUTF8CStringSize should cast before arithmetic
Modified: trunk/LayoutTests/editing/selection/shift-click-includes-existing-selection.html (264867 => 264868)
--- trunk/LayoutTests/editing/selection/shift-click-includes-existing-selection.html 2020-07-24 23:15:07 UTC (rev 264867)
+++ trunk/LayoutTests/editing/selection/shift-click-includes-existing-selection.html 2020-07-24 23:18:19 UTC (rev 264868)
@@ -9,6 +9,10 @@
font-size: 20px;
}
+p + p {
+ margin-top: 100px;
+}
+
#start {
border: 1px solid blue;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
