Title: [264873] trunk
Revision
264873
Author
[email protected]
Date
2020-07-24 17:25:32 -0700 (Fri, 24 Jul 2020)

Log Message

[JSC] Skip unrelated / too-compute-heavy tests in Apple Watch Series 3
https://bugs.webkit.org/show_bug.cgi?id=214768

Reviewed by Mark Lam.

JSTests:

We skip following tests in Apple Watch Series 3.

1. Tests take very long time to reproduce crash.
2. Tests for FTL, which are unrelated to Apple Watch Series 3.
3. Tests for fast for-of semantics update, which is not supported in 32bit architectures.
4. Tests for denormalized numbers where ceil / floor works differently in ARMv7k as expected.

* ChakraCore.yaml:
* stress/for-of-iterator-open-osr-at-inlined-return-non-object.js:
* stress/for-of-iterator-open-osr-at-iterator-set-local.js:
* stress/for-of-iterator-open-return-non-object.js:
* stress/op_bitand.js:
* stress/op_bitor.js:
* stress/op_bitxor.js:
* stress/op_lshift-ConstVar.js:
* stress/op_lshift-VarConst.js:
* stress/op_lshift-VarVar.js:
* stress/op_mul-ConstVar.js:
* stress/op_mul-VarConst.js:
* stress/op_mul-VarVar.js:
* stress/op_rshift-ConstVar.js:
* stress/op_rshift-VarConst.js:
* stress/op_rshift-VarVar.js:
* stress/op_sub-ConstVar.js:
* stress/op_sub-VarConst.js:
* stress/op_sub-VarVar.js:
* stress/op_urshift-ConstVar.js:
* stress/op_urshift-VarConst.js:
* stress/op_urshift-VarVar.js:
* stress/spread-forward-call-varargs-stack-overflow.js:
* stress/toctou-having-a-bad-time-new-array.js:

LayoutTests:

* js/script-tests/math-denorm.js:

Modified Paths

Diff

Modified: trunk/JSTests/ChakraCore.yaml (264872 => 264873)


--- trunk/JSTests/ChakraCore.yaml	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/ChakraCore.yaml	2020-07-25 00:25:32 UTC (rev 264873)
@@ -924,7 +924,12 @@
 - path: ChakraCore/test/Math/round.js
   cmd: runChakra :pass, "NoException", "", []
 - path: ChakraCore/test/Math/ceilfloor.js
-  cmd: runChakra :baseline, "NoException", "ceilfloor.baseline", []
+  cmd: |
+      if $model == "Apple Watch Series 3" # Denormalized numbers are round to zero in ARMv7k.
+          skip
+      else
+          runChakra :baseline, "NoException", "ceilfloor.baseline", []
+      end
 - path: ChakraCore/test/Math/sin.js
   cmd: runChakra :baseline, "NoException", "sin.baseline", []
 - path: ChakraCore/test/Math/sqrt.js

Modified: trunk/JSTests/ChangeLog (264872 => 264873)


--- trunk/JSTests/ChangeLog	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/ChangeLog	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,44 @@
 2020-07-24  Yusuke Suzuki  <[email protected]>
 
+        [JSC] Skip unrelated / too-compute-heavy tests in Apple Watch Series 3
+        https://bugs.webkit.org/show_bug.cgi?id=214768
+
+        Reviewed by Mark Lam.
+
+        We skip following tests in Apple Watch Series 3.
+
+        1. Tests take very long time to reproduce crash.
+        2. Tests for FTL, which are unrelated to Apple Watch Series 3.
+        3. Tests for fast for-of semantics update, which is not supported in 32bit architectures.
+        4. Tests for denormalized numbers where ceil / floor works differently in ARMv7k as expected.
+
+        * ChakraCore.yaml:
+        * stress/for-of-iterator-open-osr-at-inlined-return-non-object.js:
+        * stress/for-of-iterator-open-osr-at-iterator-set-local.js:
+        * stress/for-of-iterator-open-return-non-object.js:
+        * stress/op_bitand.js:
+        * stress/op_bitor.js:
+        * stress/op_bitxor.js:
+        * stress/op_lshift-ConstVar.js:
+        * stress/op_lshift-VarConst.js:
+        * stress/op_lshift-VarVar.js:
+        * stress/op_mul-ConstVar.js:
+        * stress/op_mul-VarConst.js:
+        * stress/op_mul-VarVar.js:
+        * stress/op_rshift-ConstVar.js:
+        * stress/op_rshift-VarConst.js:
+        * stress/op_rshift-VarVar.js:
+        * stress/op_sub-ConstVar.js:
+        * stress/op_sub-VarConst.js:
+        * stress/op_sub-VarVar.js:
+        * stress/op_urshift-ConstVar.js:
+        * stress/op_urshift-VarConst.js:
+        * stress/op_urshift-VarVar.js:
+        * stress/spread-forward-call-varargs-stack-overflow.js:
+        * stress/toctou-having-a-bad-time-new-array.js:
+
+2020-07-24  Yusuke Suzuki  <[email protected]>
+
         [JSC] DFG::AbstractValue::filterByValue should re-filter configured m_value via m_type
         https://bugs.webkit.org/show_bug.cgi?id=214721
         <rdar://problem/65882837>

Modified: trunk/JSTests/stress/for-of-iterator-open-osr-at-inlined-return-non-object.js (264872 => 264873)


--- trunk/JSTests/stress/for-of-iterator-open-osr-at-inlined-return-non-object.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/for-of-iterator-open-osr-at-inlined-return-non-object.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # We are not supporting fast for-of for 32bit architecture.
 //@ skip if ["arm", "mips"].include?($architecture)
 let shouldVendNull = false;
 function vendIterator() {

Modified: trunk/JSTests/stress/for-of-iterator-open-osr-at-iterator-set-local.js (264872 => 264873)


--- trunk/JSTests/stress/for-of-iterator-open-osr-at-iterator-set-local.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/for-of-iterator-open-osr-at-iterator-set-local.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # We are not supporting fast for-of for 32bit architecture.
 //@ skip if ["arm", "mips"].include?($architecture)
 let shouldVendNull = false;
 function vendIterator() {

Modified: trunk/JSTests/stress/for-of-iterator-open-return-non-object.js (264872 => 264873)


--- trunk/JSTests/stress/for-of-iterator-open-return-non-object.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/for-of-iterator-open-return-non-object.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # We are not supporting fast for-of for 32bit architecture.
 //@ skip if ["arm", "mips"].include?($architecture)
 function vendIterator() {
     return 1;

Modified: trunk/JSTests/stress/op_bitand.js (264872 => 264873)


--- trunk/JSTests/stress/op_bitand.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_bitand.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_bitor.js (264872 => 264873)


--- trunk/JSTests/stress/op_bitor.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_bitor.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_bitxor.js (264872 => 264873)


--- trunk/JSTests/stress/op_bitxor.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_bitxor.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_lshift-ConstVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_lshift-ConstVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_lshift-ConstVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_lshift-VarConst.js (264872 => 264873)


--- trunk/JSTests/stress/op_lshift-VarConst.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_lshift-VarConst.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_lshift-VarVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_lshift-VarVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_lshift-VarVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_mul-ConstVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_mul-ConstVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_mul-ConstVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_mul-VarConst.js (264872 => 264873)


--- trunk/JSTests/stress/op_mul-VarConst.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_mul-VarConst.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_mul-VarVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_mul-VarVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_mul-VarVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_rshift-ConstVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_rshift-ConstVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_rshift-ConstVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_rshift-VarConst.js (264872 => 264873)


--- trunk/JSTests/stress/op_rshift-VarConst.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_rshift-VarConst.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_rshift-VarVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_rshift-VarVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_rshift-VarVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_sub-ConstVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_sub-ConstVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_sub-ConstVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_sub-VarConst.js (264872 => 264873)


--- trunk/JSTests/stress/op_sub-VarConst.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_sub-VarConst.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_sub-VarVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_sub-VarVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_sub-VarVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,5 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
-//@ slow! if $model == "Apple Watch Series 3"
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.

Modified: trunk/JSTests/stress/op_urshift-ConstVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_urshift-ConstVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_urshift-ConstVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_urshift-VarConst.js (264872 => 264873)


--- trunk/JSTests/stress/op_urshift-VarConst.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_urshift-VarConst.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/op_urshift-VarVar.js (264872 => 264873)


--- trunk/JSTests/stress/op_urshift-VarVar.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/op_urshift-VarVar.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # This is test for FTL.
 //@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print

Modified: trunk/JSTests/stress/spread-forward-call-varargs-stack-overflow.js (264872 => 264873)


--- trunk/JSTests/stress/spread-forward-call-varargs-stack-overflow.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/spread-forward-call-varargs-stack-overflow.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,5 @@
+//@ skip if $model == "Apple Watch Series 3" # Takes very long time to reproduce failure.
+
 function assert(b) {
     if (!b)
         throw new Error("Bad assertion");

Modified: trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js (264872 => 264873)


--- trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/JSTests/stress/toctou-having-a-bad-time-new-array.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,4 +1,4 @@
-//@ skip if $buildType == "debug"
+//@ skip if $buildType == "debug" || $model == "Apple Watch Series 3" # This test takes very long time to reproduce crash.
 
 let code = `
     function foo() {

Modified: trunk/LayoutTests/ChangeLog (264872 => 264873)


--- trunk/LayoutTests/ChangeLog	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/LayoutTests/ChangeLog	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,12 @@
+2020-07-24  Yusuke Suzuki  <[email protected]>
+
+        [JSC] Skip unrelated / too-compute-heavy tests in Apple Watch Series 3
+        https://bugs.webkit.org/show_bug.cgi?id=214768
+
+        Reviewed by Mark Lam.
+
+        * js/script-tests/math-denorm.js:
+
 2020-07-24  Hector Lopez  <[email protected]>
 
         [ macO iOS ] http/tests/xmlhttprequest/cross-origin-cookie-storage.html is passing and needs expectations removed

Modified: trunk/LayoutTests/js/script-tests/math-denorm.js (264872 => 264873)


--- trunk/LayoutTests/js/script-tests/math-denorm.js	2020-07-25 00:12:38 UTC (rev 264872)
+++ trunk/LayoutTests/js/script-tests/math-denorm.js	2020-07-25 00:25:32 UTC (rev 264873)
@@ -1,3 +1,4 @@
+//@ skip if $model == "Apple Watch Series 3" # denormalized numbers will be round to zero in ARMv7k.
 //@ skip if $architecture == "arm" and $hostOS == "darwin"
 
 description("This test checks the behavior of the Math.ceil and Math.floor on denormalized FP values.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to