Title: [264899] trunk
- Revision
- 264899
- Author
- [email protected]
- Date
- 2020-07-26 08:35:18 -0700 (Sun, 26 Jul 2020)
Log Message
Unreviewed, partially revert r264896.
https://bugs.webkit.org/show_bug.cgi?id=214688
This logging is no longer needed.
Source/WebKit:
* Platform/spi/ios/UIKitSPI.h:
Tools:
* WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp GSKeyboardForHWLayout:forceRebuild:createIfNeeded:]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264898 => 264899)
--- trunk/Source/WebKit/ChangeLog 2020-07-26 14:08:23 UTC (rev 264898)
+++ trunk/Source/WebKit/ChangeLog 2020-07-26 15:35:18 UTC (rev 264899)
@@ -1,5 +1,14 @@
2020-07-26 Wenson Hsieh <[email protected]>
+ Unreviewed, partially revert r264896.
+ https://bugs.webkit.org/show_bug.cgi?id=214688
+
+ This logging is no longer needed.
+
+ * Platform/spi/ios/UIKitSPI.h:
+
+2020-07-26 Wenson Hsieh <[email protected]>
+
Unreviewed, add even more logging to try and diagnose a flaky test
https://bugs.webkit.org/show_bug.cgi?id=214688
<rdar://problem/65993683>
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (264898 => 264899)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-07-26 14:08:23 UTC (rev 264898)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-07-26 15:35:18 UTC (rev 264899)
@@ -1379,7 +1379,6 @@
@interface UIApplication (IPI)
- (GSKeyboardRef)_hardwareKeyboard:(BOOL)createIfNeeded;
-- (GSKeyboardRef)GSKeyboardForHWLayout:(NSString *)layout forceRebuild:(BOOL)forceRebuild createIfNeeded:(BOOL)createIfNeeded;
@end
WTF_EXTERN_C_BEGIN
Modified: trunk/Tools/ChangeLog (264898 => 264899)
--- trunk/Tools/ChangeLog 2020-07-26 14:08:23 UTC (rev 264898)
+++ trunk/Tools/ChangeLog 2020-07-26 15:35:18 UTC (rev 264899)
@@ -1,5 +1,15 @@
2020-07-26 Wenson Hsieh <[email protected]>
+ Unreviewed, partially revert r264896.
+ https://bugs.webkit.org/show_bug.cgi?id=214688
+
+ This logging is no longer needed.
+
+ * WebKitTestRunner/ios/mainIOS.mm:
+ (-[WebKitTestRunnerApp GSKeyboardForHWLayout:forceRebuild:createIfNeeded:]): Deleted.
+
+2020-07-26 Wenson Hsieh <[email protected]>
+
Unreviewed, add even more logging to try and diagnose a flaky test
https://bugs.webkit.org/show_bug.cgi?id=214688
<rdar://problem/65993683>
Modified: trunk/Tools/WebKitTestRunner/ios/mainIOS.mm (264898 => 264899)
--- trunk/Tools/WebKitTestRunner/ios/mainIOS.mm 2020-07-26 14:08:23 UTC (rev 264898)
+++ trunk/Tools/WebKitTestRunner/ios/mainIOS.mm 2020-07-26 15:35:18 UTC (rev 264899)
@@ -55,13 +55,6 @@
RELEASE_ASSERT_NOT_REACHED();
}
-- (GSKeyboardRef)GSKeyboardForHWLayout:(NSString *)layout forceRebuild:(BOOL)forceRebuild createIfNeeded:(BOOL)createIfNeeded
-{
- auto keyboard = [super GSKeyboardForHWLayout:layout forceRebuild:forceRebuild createIfNeeded:createIfNeeded];
- WTFLogAlways("-[%@ GSKeyboardForHWLayout:%@ forceRebuild:%@ createIfNeeded:%@] => %p", self.class, layout, forceRebuild ? @"YES" : @"NO", createIfNeeded ? @"YES" : @"NO", keyboard);
- return keyboard;
-}
-
- (void)handleKeyHIDEvent:(IOHIDEventRef)event
{
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
