Title: [264926] trunk/LayoutTests
- Revision
- 264926
- Author
- grao...@webkit.org
- Date
- 2020-07-27 09:35:20 -0700 (Mon, 27 Jul 2020)
Log Message
Test landed flaky: [ iOS ] fast/visual-viewport/scroll-event-fired-during-scroll-alone.html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=214324
<rdar://problem/65566127>
Reviewed by Simon Fraser.
Use UIHelper.ensureStablePresentationUpdate() to determine that scroll has completed after the call to `window.scrollTo()`.
* fast/visual-viewport/scroll-event-fired-during-scroll-alone.html:
* platform/ios-simulator-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (264925 => 264926)
--- trunk/LayoutTests/ChangeLog 2020-07-27 16:00:23 UTC (rev 264925)
+++ trunk/LayoutTests/ChangeLog 2020-07-27 16:35:20 UTC (rev 264926)
@@ -1,3 +1,16 @@
+2020-07-27 Antoine Quint <grao...@webkit.org>
+
+ Test landed flaky: [ iOS ] fast/visual-viewport/scroll-event-fired-during-scroll-alone.html is a flakey failure
+ https://bugs.webkit.org/show_bug.cgi?id=214324
+ <rdar://problem/65566127>
+
+ Reviewed by Simon Fraser.
+
+ Use UIHelper.ensureStablePresentationUpdate() to determine that scroll has completed after the call to `window.scrollTo()`.
+
+ * fast/visual-viewport/scroll-event-fired-during-scroll-alone.html:
+ * platform/ios-simulator-wk2/TestExpectations:
+
2020-07-27 Hector Lopez <hector_i_lo...@apple.com>
[ iOS ] compositing/contents-scale/non-decomposable-matrix.html is passing and needs expectations removed
Modified: trunk/LayoutTests/fast/visual-viewport/scroll-event-fired-during-scroll-alone.html (264925 => 264926)
--- trunk/LayoutTests/fast/visual-viewport/scroll-event-fired-during-scroll-alone.html 2020-07-27 16:00:23 UTC (rev 264925)
+++ trunk/LayoutTests/fast/visual-viewport/scroll-event-fired-during-scroll-alone.html 2020-07-27 16:35:20 UTC (rev 264926)
@@ -6,6 +6,7 @@
}
</style>
+<script src=""
<script src=""
<script src=""
<script>
@@ -23,15 +24,15 @@
window.visualViewport.addEventListener("scroll", event => numScrollEvents++);
promise_test(async () => {
- await new Promise(resolve => window.addEventListener("load", resolve));
+ await UIHelper.waitForEvent(window, "load");
await new Promise(resolve => testRunner.runUIScript(getUIScript(), resolve));
window.scrollTo(1000, 1000);
- await new Promise(requestAnimationFrame);
+ await UIHelper.ensureStablePresentationUpdate();
assert_not_equals(numScrollEvents, 0, "Calling window.scrollTo() caused 'scroll' events to be dispatched.");
const numScrollEventsAfterScroll = numScrollEvents;
- await new Promise(requestAnimationFrame);
+ await UIHelper.animationFrame();
assert_equals(numScrollEventsAfterScroll, numScrollEvents, "There were no additional scroll events after scrolling.");
}, "Verify that a scroll event gets fired on window.visualViewport when its offset changes but not after the scroll has completed.");
Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (264925 => 264926)
--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2020-07-27 16:00:23 UTC (rev 264925)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2020-07-27 16:35:20 UTC (rev 264926)
@@ -110,8 +110,6 @@
webkit.org/b/214739 [ Debug ] imported/w3c/web-platform-tests/css/css-flexbox/getcomputedstyle/flexbox_computedstyle_align-content-center.html [ Pass Timeout ]
-webkit.org/b/214324 fast/visual-viewport/scroll-event-fired-during-scroll-alone.html [ Pass Failure ]
-
webkit.org/b/214751 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub.html [ Pass Failure ]
webkit.org/b/214752 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes