Title: [265075] trunk/Source/WebCore
Revision
265075
Author
[email protected]
Date
2020-07-29 22:43:26 -0700 (Wed, 29 Jul 2020)

Log Message

Unreviewed. Remove the build warning below since r265062.
warning: comparison of unsigned _expression_ < 0 is always false [-Wtype-limits]

No new tests, no new behaviors.

* Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::copyFromChannel):
(WebCore::AudioBuffer::copyToChannel):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (265074 => 265075)


--- trunk/Source/WebCore/ChangeLog	2020-07-30 04:42:46 UTC (rev 265074)
+++ trunk/Source/WebCore/ChangeLog	2020-07-30 05:43:26 UTC (rev 265075)
@@ -1,3 +1,14 @@
+2020-07-29  Joonghun Park  <[email protected]>
+
+        Unreviewed. Remove the build warning below since r265062.
+        warning: comparison of unsigned _expression_ < 0 is always false [-Wtype-limits]
+
+        No new tests, no new behaviors.
+
+        * Modules/webaudio/AudioBuffer.cpp:
+        (WebCore::AudioBuffer::copyFromChannel):
+        (WebCore::AudioBuffer::copyToChannel):
+
 2020-07-29  Jer Noble  <[email protected]>
 
         Support HDR decode in SW VP9

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp (265074 => 265075)


--- trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp	2020-07-30 04:42:46 UTC (rev 265074)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp	2020-07-30 05:43:26 UTC (rev 265075)
@@ -130,7 +130,7 @@
     if (destination->isShared())
         return Exception { TypeError, "Destination may not be a shared buffer."_s };
     
-    if (channelNumber < 0 || channelNumber >= m_channels.size())
+    if (channelNumber >= m_channels.size())
         return Exception { IndexSizeError, "Not a valid channelNumber."_s };
     
     Float32Array* channelData = m_channels[channelNumber].get();
@@ -158,7 +158,7 @@
     if (source->isShared())
         return Exception { TypeError, "Source may not be a shared buffer."_s };
     
-    if (channelNumber < 0 || channelNumber >= m_channels.size())
+    if (channelNumber >= m_channels.size())
         return Exception { IndexSizeError, "Not a valid channelNumber."_s };
     
     Float32Array* channelData = m_channels[channelNumber].get();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to