Title: [265118] trunk/Source/WebInspectorUI
Revision
265118
Author
[email protected]
Date
2020-07-30 16:35:15 -0700 (Thu, 30 Jul 2020)

Log Message

Web Inspector: only show scrollbars when needed
https://bugs.webkit.org/show_bug.cgi?id=214980

Reviewed by Brian Burg.

Prefer `overflow: auto;` instead of `overflow: scroll;` wherever possible, as when using a
hardware mouse scrollbars are always shown for the latter, even when the content fits.

* UserInterface/Debug/UncaughtExceptionReporter.css:
(.sheet-container):
* UserInterface/Views/AuditTestContentView.css:
(.content-view-container > .content-view.audit-test):
* UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline):
* UserInterface/Views/CanvasSidebarPanel.css:
(.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
* UserInterface/Views/DOMEventsBreakdownView.css:
(.waterfall-popover-content .dom-events-breakdown):
* UserInterface/Views/DOMNodeEventsContentView.css:
(.dom-node-details.dom-events):
* UserInterface/Views/GraphicsOverviewContentView.css:
(.content-view.graphics-overview):
* UserInterface/Views/LocalRemoteObjectContentView.css:
(.content-view.local-remote-object):
* UserInterface/Views/NetworkResourceDetailView.css:
(.content-view.resource-details):
* UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .tree-outline):
* UserInterface/Views/SourceCodeTextEditor.css:
(.popover .debugger-popover-content > .body):

* UserInterface/Views/CPUTimelineView.css:
(.timeline-view.cpu): Added.
(body .timeline-view.cpu): Deleted.
* UserInterface/Views/MemoryTimelineView.css:
(.timeline-view.memory): Added.
(body .timeline-view.memory): Deleted.
Although `!important` is kind of a "hack", adding `body` to the selector is more of a "hack"
and is easier to unintentionally break.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (265117 => 265118)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-07-30 23:35:15 UTC (rev 265118)
@@ -1,3 +1,45 @@
+2020-07-30  Devin Rousso  <[email protected]>
+
+        Web Inspector: only show scrollbars when needed
+        https://bugs.webkit.org/show_bug.cgi?id=214980
+
+        Reviewed by Brian Burg.
+
+        Prefer `overflow: auto;` instead of `overflow: scroll;` wherever possible, as when using a
+        hardware mouse scrollbars are always shown for the latter, even when the content fits.
+
+        * UserInterface/Debug/UncaughtExceptionReporter.css:
+        (.sheet-container):
+        * UserInterface/Views/AuditTestContentView.css:
+        (.content-view-container > .content-view.audit-test):
+        * UserInterface/Views/CanvasOverviewContentView.css:
+        (.content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline):
+        * UserInterface/Views/CanvasSidebarPanel.css:
+        (.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
+        * UserInterface/Views/DOMEventsBreakdownView.css:
+        (.waterfall-popover-content .dom-events-breakdown):
+        * UserInterface/Views/DOMNodeEventsContentView.css:
+        (.dom-node-details.dom-events):
+        * UserInterface/Views/GraphicsOverviewContentView.css:
+        (.content-view.graphics-overview):
+        * UserInterface/Views/LocalRemoteObjectContentView.css:
+        (.content-view.local-remote-object):
+        * UserInterface/Views/NetworkResourceDetailView.css:
+        (.content-view.resource-details):
+        * UserInterface/Views/OpenResourceDialog.css:
+        (.open-resource-dialog > .tree-outline):
+        * UserInterface/Views/SourceCodeTextEditor.css:
+        (.popover .debugger-popover-content > .body):
+
+        * UserInterface/Views/CPUTimelineView.css:
+        (.timeline-view.cpu): Added.
+        (body .timeline-view.cpu): Deleted.
+        * UserInterface/Views/MemoryTimelineView.css:
+        (.timeline-view.memory): Added.
+        (body .timeline-view.memory): Deleted.
+        Although `!important` is kind of a "hack", adding `body` to the selector is more of a "hack"
+        and is easier to unintentionally break.
+
 2020-07-28  Brian Burg  <[email protected]>
 
         Web Inspector: REGRESSION(r255396): Audit: button to exit edit mode in main content area is missing border

Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -31,7 +31,7 @@
     bottom: 0;
     z-index: var(--z-index-uncaught-exception-sheet);
     background-color: hsl(0, 0%, 96%);
-    overflow: scroll;
+    overflow: auto;
 }
 
 .uncaught-exception-sheet {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -24,7 +24,7 @@
  */
 
 .content-view-container > .content-view.audit-test {
-    overflow-y: scroll;
+    overflow-y: auto;
 }
 
 .content-view-container > .content-view.audit-test > header {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -23,8 +23,8 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-body .timeline-view.cpu {
-    overflow: scroll;
+.timeline-view.cpu {
+    overflow: auto !important;
 }
 
 .timeline-view.cpu > .content .subtitle {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -186,7 +186,7 @@
 }
 
 .content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline {
-    overflow-y: scroll;
+    overflow-y: auto;
 }
 
 .content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline > .item.recording > .icon {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -49,7 +49,7 @@
 
 .sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content {
     flex-grow: 1;
-    overflow-y: scroll;
+    overflow-y: auto;
 }
 
 .sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -26,7 +26,7 @@
 .waterfall-popover-content .dom-events-breakdown {
     -webkit-user-select: text;
     max-height: 210px;
-    overflow-y: scroll;
+    overflow-y: auto;
 }
 
 .dom-events-breakdown {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeEventsContentView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeEventsContentView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeEventsContentView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -24,5 +24,5 @@
  */
 
 .dom-node-details.dom-events {
-    overflow-y: scroll;
+    overflow-y: auto;
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -25,7 +25,7 @@
 
 .content-view.graphics-overview {
     background-color: var(--background-color-content);
-    overflow-y: scroll;
+    overflow-y: auto;
     padding-bottom: var(--navigation-bar-height);
     background-color: hsl(0, 0%, 90%);
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalRemoteObjectContentView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LocalRemoteObjectContentView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalRemoteObjectContentView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -25,5 +25,5 @@
 
 .content-view.local-remote-object {
     padding: 10px;
-    overflow: scroll;
+    overflow: auto;
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -23,8 +23,8 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-body .timeline-view.memory {
-    overflow: scroll;
+.timeline-view.memory {
+    overflow: auto !important;
 }
 
 .timeline-view.memory > .content .subtitle {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -31,7 +31,7 @@
     bottom: 0;
 
     padding: 12px 20px 0 20px;
-    overflow: scroll;
+    overflow: auto;
 
     -webkit-user-select: text;
     white-space: nowrap;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -124,7 +124,7 @@
 .open-resource-dialog > .tree-outline {
     display: flex;
     flex-direction: column;
-    overflow-y: scroll;
+    overflow-y: auto;
 
     border-bottom-left-radius: 4px;
     border-bottom-right-radius: 4px;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css (265117 => 265118)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css	2020-07-30 23:31:59 UTC (rev 265117)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css	2020-07-30 23:35:15 UTC (rev 265118)
@@ -150,7 +150,7 @@
 .popover .debugger-popover-content > .body {
     padding-top: 2px;
     border-top: 1px solid var(--text-color-quaternary);
-    overflow: scroll;
+    overflow: auto;
 }
 
 .popover .debugger-popover-content.function > .body {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to