Title: [265140] trunk/Tools
Revision
265140
Author
[email protected]
Date
2020-07-31 08:36:02 -0700 (Fri, 31 Jul 2020)

Log Message

[ews] Add unit-tests for various builder factories
https://bugs.webkit.org/show_bug.cgi?id=214969

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/factories_unittest.py: Added unit-tests.
(TestBuildFactory.test_generic_build_factory):
(TestBuildFactory.test_gtk_build_factory):
(TestBuildFactory.test_wpe_factory):
(TestBuildFactory.test_wincairo_factory):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py (265139 => 265140)


--- trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py	2020-07-31 14:03:35 UTC (rev 265139)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py	2020-07-31 15:36:02 UTC (rev 265140)
@@ -157,6 +157,19 @@
 
 
 class TestBuildFactory(TestCase):
+    def test_generic_build_factory(self):
+        factory = factories.BuildFactory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
+        ])
+
     def test_macos_build_factory(self):
         factory = factories.macOSBuildFactory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
         self.assertBuildSteps(factory.steps, [
@@ -235,6 +248,47 @@
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
         ])
 
+    def test_gtk_build_factory(self):
+        factory = factories.GTKBuildFactory(platform='gtk', configuration='release', architectures=['x86_64'])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='gtk', configuration='release', architectures=['x86_64'], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.InstallGtkDependencies),
+            _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
+        ])
+
+    def test_wpe_factory(self):
+        factory = factories.WPEFactory(platform='wpe', configuration='release', architectures=['x86_64'])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='wpe', configuration='release', architectures=['x86_64'], buildOnly=True, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.InstallWpeDependencies),
+            _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
+        ])
+
+    def test_wincairo_factory(self):
+        factory = factories.WinCairoFactory(platform='wincairo', configuration='release', architectures=['x86_64'])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='wincairo', configuration='release', architectures=['x86_64'], buildOnly=True, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
+        ])
+
     def test_jsc_mipsel_factory(self):
         factory = factories.JSCBuildFactory(platform='jsc', configuration='release', architectures=["mipsel"])
         self.assertBuildSteps(factory.steps, [

Modified: trunk/Tools/ChangeLog (265139 => 265140)


--- trunk/Tools/ChangeLog	2020-07-31 14:03:35 UTC (rev 265139)
+++ trunk/Tools/ChangeLog	2020-07-31 15:36:02 UTC (rev 265140)
@@ -1,3 +1,16 @@
+2020-07-31  Aakash Jain  <[email protected]>
+
+        [ews] Add unit-tests for various builder factories
+        https://bugs.webkit.org/show_bug.cgi?id=214969
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/factories_unittest.py: Added unit-tests.
+        (TestBuildFactory.test_generic_build_factory):
+        (TestBuildFactory.test_gtk_build_factory):
+        (TestBuildFactory.test_wpe_factory):
+        (TestBuildFactory.test_wincairo_factory):
+
 2020-07-30  Jonathan Bedard  <[email protected]>
 
         [webkitcorepy] Add an auto-installer (Unreviewed follow-up fix)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to