Title: [265143] trunk/Tools
Revision
265143
Author
[email protected]
Date
2020-07-31 09:10:02 -0700 (Fri, 31 Jul 2020)

Log Message

[webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
https://bugs.webkit.org/show_bug.cgi?id=214998
<rdar://problem/66355658>

Reviewed by Aakash Jain.

* BuildSlaveSupport/ews-build/steps.py:
(CheckPatchRelevance): Add Tools/Scripts/libraries.
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestCheckPatchRelevance.test_relevant_webkitpy_patch):
(TestCheckPatchRelevance.test_relevant_libraries_patch):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (265142 => 265143)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2020-07-31 16:00:27 UTC (rev 265142)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2020-07-31 16:10:02 UTC (rev 265143)
@@ -297,7 +297,8 @@
     ]
 
     webkitpy_paths = [
-        'Tools/Scripts/webkitpy/',
+        'Tools/Scripts/webkitpy',
+        'Tools/Scripts/libraries',
     ]
 
     group_to_paths_mapping = {

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (265142 => 265143)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2020-07-31 16:00:27 UTC (rev 265142)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2020-07-31 16:10:02 UTC (rev 265143)
@@ -2304,6 +2304,20 @@
         self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
         return self.runStep()
 
+    def test_relevant_webkitpy_patch(self):
+        CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Tools/Scripts/webkitpy'
+        self.setupStep(CheckPatchRelevance())
+        self.setProperty('buildername', 'WebKitPy-Tests-EWS')
+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
+        return self.runStep()
+
+    def test_relevant_libraries_patch(self):
+        CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Tools/Scripts/libraries'
+        self.setupStep(CheckPatchRelevance())
+        self.setProperty('buildername', 'WebKitPy-Tests-EWS')
+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
+        return self.runStep()
+
     def test_queues_without_relevance_info(self):
         CheckPatchRelevance._get_patch = lambda x: 'Sample patch'
         queues = ['Commit-Queue', 'Style-EWS', 'Apply-WatchList-EWS', 'GTK-Build-EWS', 'GTK-WK2-Tests-EWS',

Modified: trunk/Tools/ChangeLog (265142 => 265143)


--- trunk/Tools/ChangeLog	2020-07-31 16:00:27 UTC (rev 265142)
+++ trunk/Tools/ChangeLog	2020-07-31 16:10:02 UTC (rev 265143)
@@ -1,3 +1,17 @@
+2020-07-31  Jonathan Bedard  <[email protected]>
+
+        [webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
+        https://bugs.webkit.org/show_bug.cgi?id=214998
+        <rdar://problem/66355658>
+
+        Reviewed by Aakash Jain.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CheckPatchRelevance): Add Tools/Scripts/libraries.
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestCheckPatchRelevance.test_relevant_webkitpy_patch):
+        (TestCheckPatchRelevance.test_relevant_libraries_patch):
+
 2020-07-31  Keith Miller  <[email protected]>
 
         Fix build around broken internal SDK for iOS 13
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to