Title: [265148] trunk/Source/WebCore
Revision
265148
Author
[email protected]
Date
2020-07-31 10:27:47 -0700 (Fri, 31 Jul 2020)

Log Message

AX: Inteterminate progressbar reading as 50% with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=214330
<rdar://problem/65570800>

Reviewed by Zalan Bujtas.

Expose indeterminate status to iOS API.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsIndeterminate]):
(-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListTerm]):
(-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListDefinition]):
  - Drive by style fix.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (265147 => 265148)


--- trunk/Source/WebCore/ChangeLog	2020-07-31 17:26:27 UTC (rev 265147)
+++ trunk/Source/WebCore/ChangeLog	2020-07-31 17:27:47 UTC (rev 265148)
@@ -1,3 +1,19 @@
+2020-07-31  Chris Fleizach  <[email protected]>
+
+        AX: Inteterminate progressbar reading as 50% with Voiceover
+        https://bugs.webkit.org/show_bug.cgi?id=214330
+        <rdar://problem/65570800>
+
+        Reviewed by Zalan Bujtas.
+
+        Expose indeterminate status to iOS API.
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityIsIndeterminate]):
+        (-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListTerm]):
+        (-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListDefinition]):
+          - Drive by style fix.
+
 2020-07-31  Peng Liu  <[email protected]>
 
         PIP on netflix.com shows only a gray window and spinner

Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (265147 => 265148)


--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm	2020-07-31 17:26:27 UTC (rev 265147)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm	2020-07-31 17:27:47 UTC (rev 265148)
@@ -1487,6 +1487,13 @@
     return nil;
 }
 
+- (BOOL)accessibilityIsIndeterminate
+{
+    if (![self _prepareAccessibilityCall])
+        return NO;
+    return self.axBackingObject->isIndeterminate();
+}
+
 - (BOOL)accessibilityIsAttachmentElement
 {
     if (![self _prepareAccessibilityCall])
@@ -1508,9 +1515,9 @@
     if (![self _prepareAccessibilityCall])
         return NO;
 
-    return Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, false, [] (const AXCoreObject& object) {
+    return !!Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, false, [] (const AXCoreObject& object) {
         return object.roleValue() == AccessibilityRole::DescriptionListTerm;
-    }) != nullptr;
+    });
 }
 
 - (BOOL)accessibilityIsInDescriptionListDefinition
@@ -1518,9 +1525,9 @@
     if (![self _prepareAccessibilityCall])
         return NO;
 
-    return Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, false, [] (const AXCoreObject& object) {
+    return !!Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, false, [] (const AXCoreObject& object) {
         return object.roleValue() == AccessibilityRole::DescriptionListDetail;
-    }) != nullptr;
+    });
 }
 
 - (NSString *)accessibilityHint
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to