Title: [265165] trunk/Source
- Revision
- 265165
- Author
- [email protected]
- Date
- 2020-07-31 15:56:30 -0700 (Fri, 31 Jul 2020)
Log Message
Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK
https://bugs.webkit.org/show_bug.cgi?id=215035
<rdar://problem/65003342>
Reviewed by Tim Horton.
Source/WebCore:
* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isJesusCalling): Deleted.
(WebCore::IOSApplication::isFudget): Deleted.
(WebCore::IOSApplication::isFamilyHealthApp): Deleted.
Drop code that is no longer needed.
Source/WebKitLegacy/mac:
Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (265164 => 265165)
--- trunk/Source/WebCore/ChangeLog 2020-07-31 22:50:31 UTC (rev 265164)
+++ trunk/Source/WebCore/ChangeLog 2020-07-31 22:56:30 UTC (rev 265165)
@@ -1,3 +1,18 @@
+2020-07-31 Chris Dumez <[email protected]>
+
+ Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK
+ https://bugs.webkit.org/show_bug.cgi?id=215035
+ <rdar://problem/65003342>
+
+ Reviewed by Tim Horton.
+
+ * platform/RuntimeApplicationChecks.h:
+ * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+ (WebCore::IOSApplication::isJesusCalling): Deleted.
+ (WebCore::IOSApplication::isFudget): Deleted.
+ (WebCore::IOSApplication::isFamilyHealthApp): Deleted.
+ Drop code that is no longer needed.
+
2020-07-31 Brady Eidson <[email protected]>
Log a warning to the dev console when gamepads are accessed from an insecure context.
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (265164 => 265165)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-07-31 22:50:31 UTC (rev 265164)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2020-07-31 22:56:30 UTC (rev 265165)
@@ -87,9 +87,6 @@
WEBCORE_EXPORT bool isDumpRenderTree();
WEBCORE_EXPORT bool isMiniBrowser();
bool isMobileStore();
-WEBCORE_EXPORT bool isJesusCalling();
-WEBCORE_EXPORT bool isFudget();
-WEBCORE_EXPORT bool isFamilyHealthApp();
bool isSpringBoard();
WEBCORE_EXPORT bool isWebProcess();
WEBCORE_EXPORT bool isIBooks();
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (265164 => 265165)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-07-31 22:50:31 UTC (rev 265164)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2020-07-31 22:56:30 UTC (rev 265165)
@@ -266,24 +266,6 @@
return isDumpRenderTree;
}
-bool IOSApplication::isJesusCalling()
-{
- static bool isJesusCalling = applicationBundleIsEqualTo("com.thomasnelson.jesuscalling"_s);
- return isJesusCalling;
-}
-
-bool IOSApplication::isFudget()
-{
- static bool isFudget = applicationBundleIsEqualTo("com.dannyconnell.fudget"_s);
- return isFudget;
-}
-
-bool IOSApplication::isFamilyHealthApp()
-{
- static bool isFamilyHealthApp = applicationBundleStartsWith("com.wildflowerhealth.Grow"_s) || applicationBundleStartsWith("com.wildflowerhealth.UGROW");
- return isFamilyHealthApp;
-}
-
bool IOSApplication::isMobileStore()
{
static bool isMobileStore = applicationBundleIsEqualTo("com.apple.MobileStore"_s);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (265164 => 265165)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-07-31 22:50:31 UTC (rev 265164)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-07-31 22:56:30 UTC (rev 265165)
@@ -1,3 +1,16 @@
+2020-07-31 Chris Dumez <[email protected]>
+
+ Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK
+ https://bugs.webkit.org/show_bug.cgi?id=215035
+ <rdar://problem/65003342>
+
+ Reviewed by Tim Horton.
+
+ Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+
2020-07-30 Darin Adler <[email protected]>
Further reduction in the use of live ranges, particularly in headers
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (265164 => 265165)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-07-31 22:50:31 UTC (rev 265164)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-07-31 22:56:30 UTC (rev 265165)
@@ -396,7 +396,9 @@
bool allowsInlineMediaPlaybackAfterFullscreen = WebCore::deviceClass() != MGDeviceClassiPad;
bool requiresPlaysInlineAttribute = !allowsInlineMediaPlayback;
bool attachmentElementEnabled = IOSApplication::isMobileMail();
- bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling() || IOSApplication::isFudget()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0;
+
+ // For backward compatibility, keep WebSQL working until apps are rebuilt with the iOS 14 SDK.
+ bool webSQLEnabled = applicationSDKVersion() < DYLD_IOS_VERSION_14_0;
#endif
NSDictionary *dict = [NSDictionary dictionaryWithObjectsAndKeys:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes