Modified: trunk/Source/WebCore/ChangeLog (265184 => 265185)
--- trunk/Source/WebCore/ChangeLog 2020-08-02 03:19:39 UTC (rev 265184)
+++ trunk/Source/WebCore/ChangeLog 2020-08-02 06:21:06 UTC (rev 265185)
@@ -1,3 +1,17 @@
+2020-08-01 Rob Buis <[email protected]>
+
+ Remove superfluous ResourceTiming constructor overload
+ https://bugs.webkit.org/show_bug.cgi?id=215063
+
+ Reviewed by Sam Weinig.
+
+ Remove superfluous ResourceTiming constructor overload, we
+ can just call another overload from ResourceTiming::fromLoad.
+
+ * loader/ResourceTiming.cpp:
+ (WebCore::ResourceTiming::fromLoad):
+ * loader/ResourceTiming.h:
+
2020-08-01 Brady Eidson <[email protected]>
Special HID mapping for the Logitech F310/F710 controllers.
Modified: trunk/Source/WebCore/loader/ResourceTiming.cpp (265184 => 265185)
--- trunk/Source/WebCore/loader/ResourceTiming.cpp 2020-08-02 03:19:39 UTC (rev 265184)
+++ trunk/Source/WebCore/loader/ResourceTiming.cpp 2020-08-02 06:21:06 UTC (rev 265185)
@@ -64,7 +64,7 @@
ResourceTiming ResourceTiming::fromLoad(CachedResource& resource, const String& initiator, const LoadTiming& loadTiming, const NetworkLoadMetrics& networkLoadMetrics, const SecurityOrigin& securityOrigin)
{
- return ResourceTiming(resource, initiator, loadTiming, networkLoadMetrics, securityOrigin);
+ return ResourceTiming(resource.resourceRequest().url(), initiator, loadTiming, networkLoadMetrics, resource.response(), securityOrigin);
}
ResourceTiming ResourceTiming::fromSynchronousLoad(const URL& url, const String& initiator, const LoadTiming& loadTiming, const NetworkLoadMetrics& networkLoadMetrics, const ResourceResponse& response, const SecurityOrigin& securityOrigin)
@@ -81,16 +81,6 @@
initServerTiming(response);
}
-ResourceTiming::ResourceTiming(CachedResource& resource, const String& initiator, const LoadTiming& loadTiming, const NetworkLoadMetrics& networkLoadMetrics, const SecurityOrigin& securityOrigin)
- : m_url(resource.resourceRequest().url())
- , m_initiator(initiator)
- , m_loadTiming(loadTiming)
- , m_networkLoadMetrics(networkLoadMetrics)
- , m_allowTimingDetails(passesTimingAllowCheck(resource.response(), securityOrigin))
-{
- initServerTiming(resource.response());
-}
-
ResourceTiming::ResourceTiming(const URL& url, const String& initiator, const LoadTiming& loadTiming, const NetworkLoadMetrics& networkLoadMetrics, const ResourceResponse& response, const SecurityOrigin& securityOrigin)
: m_url(url)
, m_initiator(initiator)
Modified: trunk/Source/WebCore/loader/ResourceTiming.h (265184 => 265185)
--- trunk/Source/WebCore/loader/ResourceTiming.h 2020-08-02 03:19:39 UTC (rev 265184)
+++ trunk/Source/WebCore/loader/ResourceTiming.h 2020-08-02 06:21:06 UTC (rev 265185)
@@ -55,7 +55,6 @@
void overrideInitiatorName(const String& name) { m_initiator = name; }
private:
- ResourceTiming(CachedResource&, const String& initiator, const LoadTiming&, const NetworkLoadMetrics&, const SecurityOrigin&);
ResourceTiming(const URL&, const String& initiator, const LoadTiming&, const NetworkLoadMetrics&, const ResourceResponse&, const SecurityOrigin&);
ResourceTiming(const URL&, const String& initiator, const LoadTiming&, const ResourceResponse&, const SecurityOrigin&);
ResourceTiming(URL&& url, String&& initiator, LoadTiming&& loadTiming, NetworkLoadMetrics&& networkLoadMetrics, bool allowTimingDetails, Vector<ServerTiming>&& serverTiming)