Title: [265195] trunk/Tools
Revision
265195
Author
[email protected]
Date
2020-08-03 05:29:30 -0700 (Mon, 03 Aug 2020)

Log Message

[WPE][GTK] run-minibrowser no longer assumes release configuration by default
https://bugs.webkit.org/show_bug.cgi?id=214961

Patch by Philippe Normand <[email protected]> on 2020-08-03
Reviewed by Adrian Perez de Castro.

* Scripts/webkitpy/port/base.py:
(Port.set_option_default): Ensure default value is set on optparsed options. In the case of
the default build configuration being set from the Port constructor, this wasn't done
properly. After fixing this, the WPE and GTK ports are correctly implicitely reusing the
build configuration option through the _build_path() method.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (265194 => 265195)


--- trunk/Tools/ChangeLog	2020-08-03 12:26:11 UTC (rev 265194)
+++ trunk/Tools/ChangeLog	2020-08-03 12:29:30 UTC (rev 265195)
@@ -1,5 +1,18 @@
 2020-08-03  Philippe Normand  <[email protected]>
 
+        [WPE][GTK] run-minibrowser no longer assumes release configuration by default
+        https://bugs.webkit.org/show_bug.cgi?id=214961
+
+        Reviewed by Adrian Perez de Castro.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port.set_option_default): Ensure default value is set on optparsed options. In the case of
+        the default build configuration being set from the Port constructor, this wasn't done
+        properly. After fixing this, the WPE and GTK ports are correctly implicitely reusing the
+        build configuration option through the _build_path() method.
+
+2020-08-03  Philippe Normand  <[email protected]>
+
         REGRESSION(r264096): [flatpak] Clean gst-build within build-webkit fails
         https://bugs.webkit.org/show_bug.cgi?id=214080
 

Modified: trunk/Tools/Scripts/webkitpy/port/base.py (265194 => 265195)


--- trunk/Tools/Scripts/webkitpy/port/base.py	2020-08-03 12:26:11 UTC (rev 265194)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2020-08-03 12:29:30 UTC (rev 265195)
@@ -797,6 +797,8 @@
             if not hasattr(self._options, name):
                 setattr(self._options, name, default_value)
                 return True
+            elif not self.get_option(name):
+                self.set_option(name, default_value)
         else:
             return self._options.ensure_value(name, default_value)
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to