Title: [265201] trunk/Tools
Revision
265201
Author
[email protected]
Date
2020-08-03 09:59:25 -0700 (Mon, 03 Aug 2020)

Log Message

REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
https://bugs.webkit.org/show_bug.cgi?id=215038

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/results/options.py:
(upload_options):
For compatibility, make it possible to create the option with a differently-named flag.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (265200 => 265201)


--- trunk/Tools/ChangeLog	2020-08-03 16:54:52 UTC (rev 265200)
+++ trunk/Tools/ChangeLog	2020-08-03 16:59:25 UTC (rev 265201)
@@ -1,3 +1,14 @@
+2020-08-03  Brian Burg  <[email protected]>
+
+        REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
+        https://bugs.webkit.org/show_bug.cgi?id=215038
+
+        Reviewed by Jonathan Bedard.
+
+        * Scripts/webkitpy/results/options.py:
+        (upload_options):
+        For compatibility, make it possible to create the option with a differently-named flag.
+
 2020-08-03  Philippe Normand  <[email protected]>
 
         [WPE][GTK] run-minibrowser no longer assumes release configuration by default

Modified: trunk/Tools/Scripts/webkitpy/results/options.py (265200 => 265201)


--- trunk/Tools/Scripts/webkitpy/results/options.py	2020-08-03 16:54:52 UTC (rev 265200)
+++ trunk/Tools/Scripts/webkitpy/results/options.py	2020-08-03 16:59:25 UTC (rev 265201)
@@ -23,7 +23,7 @@
 import optparse
 
 
-def upload_options():
+def upload_options(suite_name_flag='suite'):
     return [
         optparse.make_option('--report', action='', dest='report_urls', help='URL (or URLs) to report test results to'),
         optparse.make_option('--buildbot-master', help='The url of the buildbot master.'),
@@ -31,5 +31,5 @@
         optparse.make_option('--build-number', help='The buildbot build number tests are associated with.'),
         optparse.make_option('--buildbot-worker', help='The buildbot worker tests were run on.'),
         optparse.make_option('--result-report-flavor', help='Optional flag for categorizing test runs which do not fit into other configuration options.'),
-        optparse.make_option('--suite', help='Optional flag for overriding reported suite name.', default=None),
+        optparse.make_option('--' + suite_name_flag, help='Optional flag for overriding reported suite name.', default=None),
     ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to