Title: [265207] trunk/Source/WebCore
- Revision
- 265207
- Author
- [email protected]
- Date
- 2020-08-03 11:00:44 -0700 (Mon, 03 Aug 2020)
Log Message
[WebDriver] window.print should not invoke native UI
https://bugs.webkit.org/show_bug.cgi?id=215084
Reviewed by Devin Rousso.
This could be handled at a higher level if there is a valid use case to allow printing,
but I'm not aware of one. For now, this fixes a script evaluation hang on Mac and iOS.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::print):
Don't call out to print delegates if this is a WebDriver-controlled page.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (265206 => 265207)
--- trunk/Source/WebCore/ChangeLog 2020-08-03 17:49:37 UTC (rev 265206)
+++ trunk/Source/WebCore/ChangeLog 2020-08-03 18:00:44 UTC (rev 265207)
@@ -1,3 +1,17 @@
+2020-08-03 Brian Burg <[email protected]>
+
+ [WebDriver] window.print should not invoke native UI
+ https://bugs.webkit.org/show_bug.cgi?id=215084
+
+ Reviewed by Devin Rousso.
+
+ This could be handled at a higher level if there is a valid use case to allow printing,
+ but I'm not aware of one. For now, this fixes a script evaluation hang on Mac and iOS.
+
+ * page/DOMWindow.cpp:
+ (WebCore::DOMWindow::print):
+ Don't call out to print delegates if this is a WebDriver-controlled page.
+
2020-08-03 Rob Buis <[email protected]>
Remove unused API in HighlightMap
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (265206 => 265207)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2020-08-03 17:49:37 UTC (rev 265206)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2020-08-03 18:00:44 UTC (rev 265207)
@@ -1069,6 +1069,9 @@
return;
}
+ if (page->isControlledByAutomation())
+ return;
+
if (frame->loader().activeDocumentLoader()->isLoading()) {
m_shouldPrintWhenFinishedLoading = true;
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes