Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (265223 => 265224)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-03 22:16:02 UTC (rev 265224)
@@ -1,3 +1,26 @@
+2020-08-03 Brian Burg <[email protected]>
+
+ Web Inspector: "Show transparency grid" string needs to be disambiguated for localization
+ https://bugs.webkit.org/show_bug.cgi?id=215101
+
+ Reviewed by Darin Adler.
+
+ Add two different string keys with the same English translation. This is specifically
+ needed for Portuguese, apparently.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/CanvasContentView.js:
+ (WI.CanvasContentView):
+ * UserInterface/Views/GraphicsOverviewContentView.js:
+ (WI.GraphicsOverviewContentView):
+ * UserInterface/Views/ImageResourceContentView.js:
+ * UserInterface/Views/RecordingContentView.js:
+ (WI.RecordingContentView):
+ * UserInterface/Views/ResourceCollectionContentView.js:
+ (WI.ResourceCollectionContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createSourcesSettingsView):
+
2020-08-03 Devin Rousso <[email protected]>
Web Inspector: REGRESSION(r243301): Network: initiator column missing
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -1147,7 +1147,8 @@
localizedStrings["Show rulers"] = "Show rulers";
localizedStrings["Show the details sidebar (%s)"] = "Show the details sidebar (%s)";
localizedStrings["Show the navigation sidebar (%s)"] = "Show the navigation sidebar (%s)";
-localizedStrings["Show transparency grid"] = "Show transparency grid";
+localizedStrings["Show transparency grid (tooltip)"] = "Show transparency grid";
+localizedStrings["Show transparency grid (settings label)"] = "Show transparency grid";
localizedStrings["Show type information"] = "Show type information";
localizedStrings["Show:"] = "Show:";
localizedStrings["Site-specific Hacks"] = "Site-specific Hacks";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -47,7 +47,7 @@
this._refreshButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this.handleRefreshButtonClicked, this);
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -39,7 +39,7 @@
this._refreshButtonNavigationItem = new WI.ButtonNavigationItem("refresh", WI.UIString("Refresh"), "Images/ReloadFull.svg", 13, 13);
this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleRefreshButtonClicked, this);
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleShowGridButtonClicked, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -35,7 +35,7 @@
this._draggingInternalImageElement = false;
this._disableDropZone = disableDropZone || false;
- const toolTip = WI.UIString("Show transparency grid");
+ const toolTip = WI.UIString("Show transparency grid", "Show transparency grid (tooltip)");
const activatedToolTip = WI.UIString("Hide transparency grid");
this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", toolTip, activatedToolTip, "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -58,7 +58,7 @@
this._showPathButtonNavigationItem.activated = !!WI.settings.showCanvasPath.value;
}
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -38,7 +38,7 @@
this.element.classList.add("resource-collection");
if (collection.resourceType === WI.Resource.Type.Image) {
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleShowGridButtonClicked, this);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (265223 => 265224)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2020-08-03 22:14:10 UTC (rev 265223)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2020-08-03 22:16:02 UTC (rev 265224)
@@ -300,7 +300,7 @@
sourcesSettingsView.addSeparator();
- sourcesSettingsView.addSetting(WI.UIString("Images:"), WI.settings.showImageGrid, WI.UIString("Show transparency grid"));
+ sourcesSettingsView.addSetting(WI.UIString("Images:"), WI.settings.showImageGrid, WI.UIString("Show transparency grid", "Show transparency grid (settings label)"));
this._createReferenceLink(sourcesSettingsView);