Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (265232 => 265233)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-04 00:31:57 UTC (rev 265233)
@@ -1,5 +1,20 @@
2020-08-03 Chris Dumez <[email protected]>
+ Add constructor for AudioBufferSourceNode
+ https://bugs.webkit.org/show_bug.cgi?id=215096
+
+ Reviewed by Darin Adler.
+
+ Rebaseline WPT tests now that more checks are passing.
+
+ * web-platform-tests/webaudio/idlharness.https.window-expected.txt:
+ * web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
+ * web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
+ * web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
+ * web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
+
+2020-08-03 Chris Dumez <[email protected]>
+
Add constructor for GainNode
https://bugs.webkit.org/show_bug.cgi?id=215093
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt (265232 => 265233)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -233,27 +233,27 @@
PASS AudioParam interface: operation setValueCurveAtTime(sequence<float>, double, double)
PASS AudioParam interface: operation cancelScheduledValues(double)
FAIL AudioParam interface: operation cancelAndHoldAtTime(double) assert_own_property: interface prototype object missing non-static operation expected property "cancelAndHoldAtTime" missing
-FAIL AudioParam must be primary interface of new AudioBufferSourceNode(context).playbackRate assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL Stringification of new AudioBufferSourceNode(context).playbackRate assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "value" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "automationRate" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "defaultValue" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "minValue" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "maxValue" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setValueAtTime(float, double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling setValueAtTime(float, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "linearRampToValueAtTime(float, double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling linearRampToValueAtTime(float, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "exponentialRampToValueAtTime(float, double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling exponentialRampToValueAtTime(float, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setTargetAtTime(float, double, float)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling setTargetAtTime(float, double, float) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setValueCurveAtTime(sequence<float>, double, double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling setValueCurveAtTime(sequence<float>, double, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "cancelScheduledValues(double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling cancelScheduledValues(double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "cancelAndHoldAtTime(double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioParam interface: calling cancelAndHoldAtTime(double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
+PASS AudioParam must be primary interface of new AudioBufferSourceNode(context).playbackRate
+PASS Stringification of new AudioBufferSourceNode(context).playbackRate
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "value" with the proper type
+FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "automationRate" with the proper type assert_inherits: property "automationRate" not found in prototype chain
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "defaultValue" with the proper type
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "minValue" with the proper type
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "maxValue" with the proper type
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setValueAtTime(float, double)" with the proper type
+PASS AudioParam interface: calling setValueAtTime(float, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "linearRampToValueAtTime(float, double)" with the proper type
+PASS AudioParam interface: calling linearRampToValueAtTime(float, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "exponentialRampToValueAtTime(float, double)" with the proper type
+PASS AudioParam interface: calling exponentialRampToValueAtTime(float, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setTargetAtTime(float, double, float)" with the proper type
+PASS AudioParam interface: calling setTargetAtTime(float, double, float) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "setValueCurveAtTime(sequence<float>, double, double)" with the proper type
+PASS AudioParam interface: calling setValueCurveAtTime(sequence<float>, double, double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError
+PASS AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "cancelScheduledValues(double)" with the proper type
+PASS AudioParam interface: calling cancelScheduledValues(double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError
+FAIL AudioParam interface: new AudioBufferSourceNode(context).playbackRate must inherit property "cancelAndHoldAtTime(double)" with the proper type assert_inherits: property "cancelAndHoldAtTime" not found in prototype chain
+FAIL AudioParam interface: calling cancelAndHoldAtTime(double) on new AudioBufferSourceNode(context).playbackRate with too few arguments must throw TypeError assert_inherits: property "cancelAndHoldAtTime" not found in prototype chain
PASS AudioScheduledSourceNode interface: existence and properties of interface object
PASS AudioScheduledSourceNode interface object length
PASS AudioScheduledSourceNode interface object name
@@ -317,7 +317,7 @@
PASS AudioNode interface: new AnalyserNode(context) must inherit property "channelCountMode" with the proper type
PASS AudioNode interface: new AnalyserNode(context) must inherit property "channelInterpretation" with the proper type
PASS AudioBufferSourceNode interface: existence and properties of interface object
-FAIL AudioBufferSourceNode interface object length assert_equals: wrong value for AudioBufferSourceNode.length expected 1 but got 0
+PASS AudioBufferSourceNode interface object length
PASS AudioBufferSourceNode interface object name
PASS AudioBufferSourceNode interface: existence and properties of interface prototype object
PASS AudioBufferSourceNode interface: existence and properties of interface prototype object's "constructor" property
@@ -324,49 +324,49 @@
PASS AudioBufferSourceNode interface: existence and properties of interface prototype object's @@unscopables property
PASS AudioBufferSourceNode interface: attribute buffer
PASS AudioBufferSourceNode interface: attribute playbackRate
-FAIL AudioBufferSourceNode interface: attribute detune assert_true: The prototype object must have a property "detune" expected true got false
+PASS AudioBufferSourceNode interface: attribute detune
PASS AudioBufferSourceNode interface: attribute loop
PASS AudioBufferSourceNode interface: attribute loopStart
PASS AudioBufferSourceNode interface: attribute loopEnd
PASS AudioBufferSourceNode interface: operation start(optional double, optional double, optional double)
-FAIL AudioBufferSourceNode must be primary interface of new AudioBufferSourceNode(context) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL Stringification of new AudioBufferSourceNode(context) assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "buffer" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "playbackRate" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "detune" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "loop" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "loopStart" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "loopEnd" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "start(optional double, optional double, optional double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioBufferSourceNode interface: calling start(optional double, optional double, optional double) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioScheduledSourceNode interface: new AudioBufferSourceNode(context) must inherit property "onended" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioScheduledSourceNode interface: new AudioBufferSourceNode(context) must inherit property "start(optional double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioScheduledSourceNode interface: calling start(optional double) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioScheduledSourceNode interface: new AudioBufferSourceNode(context) must inherit property "stop(optional double)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioScheduledSourceNode interface: calling stop(optional double) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "connect(AudioNode, optional unsigned long, optional unsigned long)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling connect(AudioNode, optional unsigned long, optional unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "connect(AudioParam, optional unsigned long)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling connect(AudioParam, optional unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect()" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(unsigned long)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling disconnect(unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioNode)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling disconnect(AudioNode) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioNode, unsigned long)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling disconnect(AudioNode, unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioNode, unsigned long, unsigned long)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling disconnect(AudioNode, unsigned long, unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioParam)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling disconnect(AudioParam) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioParam, unsigned long)" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: calling disconnect(AudioParam, unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "context" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "numberOfInputs" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "numberOfOutputs" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "channelCount" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "channelCountMode" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
-FAIL AudioNode interface: new AudioBufferSourceNode(context) must inherit property "channelInterpretation" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
+PASS AudioBufferSourceNode must be primary interface of new AudioBufferSourceNode(context)
+PASS Stringification of new AudioBufferSourceNode(context)
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "buffer" with the proper type
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "playbackRate" with the proper type
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "detune" with the proper type
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "loop" with the proper type
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "loopStart" with the proper type
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "loopEnd" with the proper type
+PASS AudioBufferSourceNode interface: new AudioBufferSourceNode(context) must inherit property "start(optional double, optional double, optional double)" with the proper type
+PASS AudioBufferSourceNode interface: calling start(optional double, optional double, optional double) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioScheduledSourceNode interface: new AudioBufferSourceNode(context) must inherit property "onended" with the proper type
+PASS AudioScheduledSourceNode interface: new AudioBufferSourceNode(context) must inherit property "start(optional double)" with the proper type
+PASS AudioScheduledSourceNode interface: calling start(optional double) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioScheduledSourceNode interface: new AudioBufferSourceNode(context) must inherit property "stop(optional double)" with the proper type
+PASS AudioScheduledSourceNode interface: calling stop(optional double) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "connect(AudioNode, optional unsigned long, optional unsigned long)" with the proper type
+PASS AudioNode interface: calling connect(AudioNode, optional unsigned long, optional unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "connect(AudioParam, optional unsigned long)" with the proper type
+PASS AudioNode interface: calling connect(AudioParam, optional unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect()" with the proper type
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(unsigned long)" with the proper type
+PASS AudioNode interface: calling disconnect(unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioNode)" with the proper type
+PASS AudioNode interface: calling disconnect(AudioNode) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioNode, unsigned long)" with the proper type
+PASS AudioNode interface: calling disconnect(AudioNode, unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioNode, unsigned long, unsigned long)" with the proper type
+PASS AudioNode interface: calling disconnect(AudioNode, unsigned long, unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioParam)" with the proper type
+PASS AudioNode interface: calling disconnect(AudioParam) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "disconnect(AudioParam, unsigned long)" with the proper type
+PASS AudioNode interface: calling disconnect(AudioParam, unsigned long) on new AudioBufferSourceNode(context) with too few arguments must throw TypeError
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "context" with the proper type
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "numberOfInputs" with the proper type
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "numberOfOutputs" with the proper type
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "channelCount" with the proper type
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "channelCountMode" with the proper type
+PASS AudioNode interface: new AudioBufferSourceNode(context) must inherit property "channelInterpretation" with the proper type
PASS AudioDestinationNode interface: existence and properties of interface object
PASS AudioDestinationNode interface object length
PASS AudioDestinationNode interface object name
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt (265232 => 265233)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -1,3 +1,3 @@
-FAIL Test that a DelayNode allows a feedback loop of a single rendering quantum function is not a constructor (evaluating 'new AudioBufferSourceNode(off, {buffer: b})')
+FAIL Test that a DelayNode allows a feedback loop of a single rendering quantum assert_equals: Silent audio found instead of a delayed impulse expected 1 but got 0
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt (265232 => 265233)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -6,7 +6,7 @@
PASS Executing "invalid option values"
FAIL Executing "default constructor" promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'buffer.numberOfChannels')"
PASS Executing "valid constructor"
-FAIL Executing "multiple contexts" promise_test: Unhandled rejection with value: object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(c1, {buffer: buffer})')"
+PASS Executing "multiple contexts"
PASS Audit report
PASS > [initialize]
PASS context = new OfflineAudioContext(...) did not throw an exception.
@@ -52,5 +52,9 @@
PASS buffer.getChannelData(3) threw IndexSizeError: "Index must be less than number of channels.".
PASS < [valid constructor] All assertions passed. (total 11 assertions)
PASS > [multiple contexts]
+PASS c1 result is identical to the array [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16...].
+PASS c2 result is identical to the array [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16...].
+PASS AudioBuffer shared between two different contexts correctly
+PASS < [multiple contexts] All assertions passed. (total 3 assertions)
FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 7 tasks were failed. assert_true: expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt (265232 => 265233)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -1,7 +1,20 @@
PASS # AUDIT TASK RUNNER STARTED.
-FAIL Executing "start/stop exceptions" promise_test: Unhandled rejection with value: object "TypeError: function is not a constructor (evaluating 'new AudioBufferSourceNode(context)')"
+PASS Executing "start/stop exceptions"
PASS Audit report
PASS > [start/stop exceptions]
-PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.
+PASS start(NaN) threw TypeError: "The provided value is non-finite".
+PASS start(Infinity) threw TypeError: "The provided value is non-finite".
+PASS start(-Infinity) threw TypeError: "The provided value is non-finite".
+PASS Calling stop() before start() threw InvalidStateError: "The object is in an invalid state.".
+FAIL X start(-1) threw "InvalidStateError" instead of EcmaScript error RangeError. assert_true: expected true got false
+FAIL X start(0,-1) threw "InvalidStateError" instead of EcmaScript error RangeError. assert_true: expected true got false
+FAIL X start(0,0,-1) threw "InvalidStateError" instead of EcmaScript error RangeError. assert_true: expected true got false
+FAIL X Calling start() twice did not throw an exception. assert_true: expected true got false
+FAIL X stop(-1) threw "InvalidStateError" instead of EcmaScript error RangeError. assert_true: expected true got false
+PASS stop(NaN) threw TypeError: "The provided value is non-finite".
+PASS stop(Infinity) threw TypeError: "The provided value is non-finite".
+PASS stop(-Infinity) threw TypeError: "The provided value is non-finite".
+FAIL < [start/stop exceptions] 5 out of 12 assertions were failed. assert_true: expected true got false
+FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt (265232 => 265233)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -2,24 +2,45 @@
PASS # AUDIT TASK RUNNER STARTED.
PASS Executing "initialize"
PASS Executing "invalid constructor"
-FAIL Executing "default constructor" promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'node.numberOfInputs')"
-FAIL Executing "nullable buffer" promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'node.buffer')"
-FAIL Executing "constructor options" promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'factoryNode.detune.value = options.detune')"
+PASS Executing "default constructor"
+PASS Executing "nullable buffer"
+PASS Executing "constructor options"
PASS Audit report
PASS > [initialize]
PASS context = new OfflineAudioContext(...) did not throw an exception.
PASS < [initialize] All assertions passed. (total 1 assertions)
PASS > [invalid constructor]
-PASS new AudioBufferSourceNode() threw TypeError: "function is not a constructor (evaluating 'new window[name]()')".
-PASS new AudioBufferSourceNode(1) threw TypeError: "function is not a constructor (evaluating 'new window[name](1)')".
-PASS new AudioBufferSourceNode(context, 42) threw TypeError: "function is not a constructor (evaluating 'new window[name](context, 42)')".
+PASS new AudioBufferSourceNode() threw TypeError: "Not enough arguments".
+PASS new AudioBufferSourceNode(1) threw TypeError: "Argument 1 ('context') to the AudioBufferSourceNode constructor must be an instance of BaseAudioContext".
+PASS new AudioBufferSourceNode(context, 42) threw TypeError: "Type error".
PASS < [invalid constructor] All assertions passed. (total 3 assertions)
PASS > [default constructor]
-FAIL X node0 = new AudioBufferSourceNode(context) incorrectly threw TypeError: "function is not a constructor (evaluating 'new window[name](context, options.constructorOptions)')". assert_true: expected true got false
-FAIL X node0 instanceof AudioBufferSourceNode is not equal to true. Got false. assert_true: expected true got false
+PASS node0 = new AudioBufferSourceNode(context) did not throw an exception.
+PASS node0 instanceof AudioBufferSourceNode is equal to true.
+PASS node0.numberOfInputs is equal to 0.
+PASS node0.numberOfOutputs is equal to 1.
+PASS node0.channelCount is equal to 2.
+PASS node0.channelCountMode is equal to max.
+PASS node0.channelInterpretation is equal to speakers.
+PASS node0.buffer is equal to null.
+PASS node0.detune.value is equal to 0.
+PASS node0.loop is equal to false.
+PASS node0.loopEnd is equal to 0.
+PASS node0.loopStart is equal to 0.
+PASS node0.playbackRate.value is equal to 1.
+PASS < [default constructor] All assertions passed. (total 13 assertions)
PASS > [nullable buffer]
-FAIL X node1 = new AudioBufferSourceNode(c, {"buffer":null} incorrectly threw TypeError: "function is not a constructor (evaluating 'new AudioBufferSourceNode(context, options)')". assert_true: expected true got false
+PASS node1 = new AudioBufferSourceNode(c, {"buffer":null} did not throw an exception.
+PASS node1.buffer is equal to null.
+PASS < [nullable buffer] All assertions passed. (total 2 assertions)
PASS > [constructor options]
-FAIL X node = new AudioBufferSourceNode(c, {"buffer":{},"detune":0.5,"loop":true,"loopEnd":0.010416666666666666,"loopStart":0.00010416666666666667,"playbackRate":0.75}) incorrectly threw TypeError: "function is not a constructor (evaluating 'new AudioBufferSourceNode(context, options)')". assert_true: expected true got false
-FAIL # AUDIT TASK RUNNER FINISHED: 3 out of 5 tasks were failed. assert_true: expected true got false
+PASS node = new AudioBufferSourceNode(c, {"buffer":{},"detune":0.5,"loop":true,"loopEnd":0.010416666666666666,"loopStart":0.00010416666666666667,"playbackRate":0.75}) did not throw an exception.
+PASS node2.buffer === buffer is equal to true.
+PASS node2.detune.value is equal to 0.5.
+PASS node2.loop is equal to true.
+PASS node2.loopEnd is equal to 0.010416666666666666.
+PASS node2.loopStart is equal to 0.00010416666666666667.
+PASS node2.playbackRate.value is equal to 0.75.
+PASS < [constructor options] All assertions passed. (total 7 assertions)
+PASS # AUDIT TASK RUNNER FINISHED: 5 tasks ran successfully.
Modified: trunk/Source/WebCore/CMakeLists.txt (265232 => 265233)
--- trunk/Source/WebCore/CMakeLists.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/CMakeLists.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -451,6 +451,7 @@
Modules/webaudio/AudioBufferCallback.idl
Modules/webaudio/AudioBufferOptions.idl
Modules/webaudio/AudioBufferSourceNode.idl
+ Modules/webaudio/AudioBufferSourceOptions.idl
Modules/webaudio/AudioContext.idl
Modules/webaudio/AudioContextLatencyCategory.idl
Modules/webaudio/AudioContextOptions.idl
Modified: trunk/Source/WebCore/ChangeLog (265232 => 265233)
--- trunk/Source/WebCore/ChangeLog 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/ChangeLog 2020-08-04 00:31:57 UTC (rev 265233)
@@ -1,3 +1,37 @@
+2020-08-03 Chris Dumez <[email protected]>
+
+ Add constructor for AudioBufferSourceNode
+ https://bugs.webkit.org/show_bug.cgi?id=215096
+
+ Reviewed by Darin Adler.
+
+ Add constructor for AudioBufferSourceNode as per:
+ - https://www.w3.org/TR/webaudio/#DelayNode
+
+ This patch also adds support for the detune attribute on AudioBufferSourceNode,
+ which gets initialized by the constructor.
+
+ No new tests, rebaselined existing tests.
+
+ * CMakeLists.txt:
+ * DerivedSources-input.xcfilelist:
+ * DerivedSources-output.xcfilelist:
+ * DerivedSources.make:
+ * Modules/webaudio/AudioBufferSourceNode.cpp:
+ (WebCore::AudioBufferSourceNode::create):
+ (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
+ (WebCore::AudioBufferSourceNode::process):
+ (WebCore::AudioBufferSourceNode::reset):
+ (WebCore::AudioBufferSourceNode::totalPitchRate):
+ * Modules/webaudio/AudioBufferSourceNode.h:
+ * Modules/webaudio/AudioBufferSourceNode.idl:
+ * Modules/webaudio/AudioBufferSourceOptions.h: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
+ * Modules/webaudio/AudioBufferSourceOptions.idl: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
+ * Modules/webaudio/BaseAudioContext.cpp:
+ (WebCore::BaseAudioContext::createBufferSource):
+ * Sources.txt:
+ * WebCore.xcodeproj/project.pbxproj:
+
2020-08-03 Simon Fraser <[email protected]>
Add an EventRegions log channel
Modified: trunk/Source/WebCore/DerivedSources-input.xcfilelist (265232 => 265233)
--- trunk/Source/WebCore/DerivedSources-input.xcfilelist 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/DerivedSources-input.xcfilelist 2020-08-04 00:31:57 UTC (rev 265233)
@@ -300,6 +300,7 @@
$(PROJECT_DIR)/Modules/webaudio/AudioBufferCallback.idl
$(PROJECT_DIR)/Modules/webaudio/AudioBufferOptions.idl
$(PROJECT_DIR)/Modules/webaudio/AudioBufferSourceNode.idl
+$(PROJECT_DIR)/Modules/webaudio/AudioBufferSourceOptions.idl
$(PROJECT_DIR)/Modules/webaudio/AudioContext.idl
$(PROJECT_DIR)/Modules/webaudio/AudioContextLatencyCategory.idl
$(PROJECT_DIR)/Modules/webaudio/AudioContextOptions.idl
Modified: trunk/Source/WebCore/DerivedSources-output.xcfilelist (265232 => 265233)
--- trunk/Source/WebCore/DerivedSources-output.xcfilelist 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/DerivedSources-output.xcfilelist 2020-08-04 00:31:57 UTC (rev 265233)
@@ -155,6 +155,8 @@
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioBufferOptions.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioBufferSourceNode.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioBufferSourceNode.h
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioBufferSourceOptions.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioBufferSourceOptions.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioConfiguration.cpp
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioConfiguration.h
$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSAudioContext.cpp
Modified: trunk/Source/WebCore/DerivedSources.make (265232 => 265233)
--- trunk/Source/WebCore/DerivedSources.make 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/DerivedSources.make 2020-08-04 00:31:57 UTC (rev 265233)
@@ -383,6 +383,7 @@
$(WebCore)/Modules/webaudio/AudioBufferCallback.idl \
$(WebCore)/Modules/webaudio/AudioBufferOptions.idl \
$(WebCore)/Modules/webaudio/AudioBufferSourceNode.idl \
+ $(WebCore)/Modules/webaudio/AudioBufferSourceOptions.idl \
$(WebCore)/Modules/webaudio/AudioContext.idl \
$(WebCore)/Modules/webaudio/AudioContextLatencyCategory.idl \
$(WebCore)/Modules/webaudio/AudioContextOptions.idl \
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp (265232 => 265233)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2020-08-04 00:31:57 UTC (rev 265233)
@@ -49,29 +49,38 @@
// to minimize linear interpolation aliasing.
const double MaxRate = 1024;
-Ref<AudioBufferSourceNode> AudioBufferSourceNode::create(BaseAudioContext& context, float sampleRate)
+ExceptionOr<Ref<AudioBufferSourceNode>> AudioBufferSourceNode::create(BaseAudioContext& context, AudioBufferSourceOptions&& options)
{
- return adoptRef(*new AudioBufferSourceNode(context, sampleRate));
+ if (context.isStopped())
+ return Exception { InvalidStateError };
+
+ context.lazyInitialize();
+
+ auto node = adoptRef(*new AudioBufferSourceNode(context));
+
+ node->setBuffer(WTFMove(options.buffer));
+ node->detune().setValue(options.detune);
+ node->setLoop(options.loop);
+ node->setLoopEnd(options.loopEnd);
+ node->setLoopStart(options.loopStart);
+ node->playbackRate().setValue(options.playbackRate);
+
+ // Because this is an AudioScheduledSourceNode, the context keeps a reference until it has finished playing.
+ // When this happens, AudioScheduledSourceNode::finish() calls BaseAudioContext::notifyNodeFinishedProcessing().
+ context.refNode(node);
+
+ return node;
}
-AudioBufferSourceNode::AudioBufferSourceNode(BaseAudioContext& context, float sampleRate)
- : AudioScheduledSourceNode(context, sampleRate)
- , m_buffer(nullptr)
- , m_isLooping(false)
- , m_loopStart(0)
- , m_loopEnd(0)
- , m_virtualReadIndex(0)
- , m_isGrain(false)
- , m_grainOffset(0.0)
+AudioBufferSourceNode::AudioBufferSourceNode(BaseAudioContext& context)
+ : AudioScheduledSourceNode(context, context.sampleRate())
+ , m_gain(AudioParam::create(context, "gain"_s, 1.0, 0.0, 1.0))
+ , m_detune(AudioParam::create(context, "detune"_s, 0.0, -FLT_MAX, FLT_MAX))
+ , m_playbackRate(AudioParam::create(context, "playbackRate"_s, 1.0, -FLT_MAX, FLT_MAX))
, m_grainDuration(DefaultGrainDuration)
- , m_lastGain(1.0)
- , m_pannerNode(nullptr)
{
setNodeType(NodeTypeAudioBufferSource);
- m_gain = AudioParam::create(context, "gain", 1.0, 0.0, 1.0);
- m_playbackRate = AudioParam::create(context, "playbackRate", 1.0, -MaxRate, MaxRate);
-
// Default to mono. A call to setBuffer() will set the number of output channels to that of the buffer.
addOutput(makeUnique<AudioNodeOutput>(this, 1));
@@ -133,7 +142,7 @@
}
// Apply the gain (in-place) to the output bus.
- float totalGain = gain()->value() * m_buffer->gain();
+ float totalGain = gain().value() * m_buffer->gain();
outputBus.copyWithGainFrom(outputBus, &m_lastGain, totalGain);
outputBus.clearSilentFlag();
}
@@ -404,7 +413,7 @@
void AudioBufferSourceNode::reset()
{
m_virtualReadIndex = 0;
- m_lastGain = gain()->value();
+ m_lastGain = gain().value();
}
void AudioBufferSourceNode::setBuffer(RefPtr<AudioBuffer>&& buffer)
@@ -516,11 +525,12 @@
if (buffer())
sampleRateFactor = buffer()->sampleRate() / sampleRate();
- double basePitchRate = playbackRate()->value();
+ double basePitchRate = playbackRate().value();
+ double detune = pow(2, m_detune->value() / 1200);
- double totalRate = dopplerRate * sampleRateFactor * basePitchRate;
+ double totalRate = dopplerRate * sampleRateFactor * basePitchRate * detune;
- totalRate = std::max(-MaxRate, std::min(MaxRate, totalRate));
+ totalRate = std::clamp(totalRate, -MaxRate, MaxRate);
bool isTotalRateValid = !std::isnan(totalRate) && !std::isinf(totalRate);
ASSERT(isTotalRateValid);
@@ -530,28 +540,6 @@
return totalRate;
}
-bool AudioBufferSourceNode::looping()
-{
- static bool firstTime = true;
- if (firstTime) {
- context().addConsoleMessage(MessageSource::JS, MessageLevel::Warning, "AudioBufferSourceNode 'looping' attribute is deprecated. Use 'loop' instead."_s);
- firstTime = false;
- }
-
- return m_isLooping;
-}
-
-void AudioBufferSourceNode::setLooping(bool looping)
-{
- static bool firstTime = true;
- if (firstTime) {
- context().addConsoleMessage(MessageSource::JS, MessageLevel::Warning, "AudioBufferSourceNode 'looping' attribute is deprecated. Use 'loop' instead."_s);
- firstTime = false;
- }
-
- m_isLooping = looping;
-}
-
bool AudioBufferSourceNode::propagatesSilence() const
{
return !isPlayingOrScheduled() || hasFinished() || !m_buffer;
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h (265232 => 265233)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h 2020-08-04 00:31:57 UTC (rev 265233)
@@ -24,6 +24,7 @@
#pragma once
+#include "AudioBufferSourceOptions.h"
#include "AudioScheduledSourceNode.h"
#include <wtf/Lock.h>
#include <wtf/UniqueArray.h>
@@ -32,6 +33,7 @@
class AudioBuffer;
class PannerNodeBase;
+struct AudioBufferSourceOptions;
// AudioBufferSourceNode is an AudioNode representing an audio source from an in-memory audio asset represented by an AudioBuffer.
// It generally will be used for short sounds which require a high degree of scheduling flexibility (can playback in rhythmically perfect ways).
@@ -40,6 +42,7 @@
WTF_MAKE_ISO_ALLOCATED(AudioBufferSourceNode);
public:
static Ref<AudioBufferSourceNode> create(BaseAudioContext&, float sampleRate);
+ static ExceptionOr<Ref<AudioBufferSourceNode>> create(BaseAudioContext&, AudioBufferSourceOptions&& = { });
virtual ~AudioBufferSourceNode();
@@ -71,13 +74,10 @@
void setLoopStart(double loopStart) { m_loopStart = loopStart; }
void setLoopEnd(double loopEnd) { m_loopEnd = loopEnd; }
- // Deprecated.
- bool looping();
- void setLooping(bool);
+ AudioParam& gain() { return m_gain.get(); }
+ AudioParam& detune() { return m_detune.get(); }
+ AudioParam& playbackRate() { return m_playbackRate.get(); }
- AudioParam* gain() { return m_gain.get(); }
- AudioParam* playbackRate() { return m_playbackRate.get(); }
-
// If a panner node is set, then we can incorporate doppler shift into the playback pitch rate.
void setPannerNode(PannerNodeBase*);
void clearPannerNode();
@@ -91,7 +91,7 @@
const char* activeDOMObjectName() const override { return "AudioBufferSourceNode"; }
private:
- AudioBufferSourceNode(BaseAudioContext&, float sampleRate);
+ explicit AudioBufferSourceNode(BaseAudioContext&);
double tailTime() const final { return 0; }
double latencyTime() const final { return 0; }
@@ -116,24 +116,25 @@
UniqueArray<const float*> m_sourceChannels;
UniqueArray<float*> m_destinationChannels;
- // Used for the "gain" and "playbackRate" attributes.
- RefPtr<AudioParam> m_gain;
- RefPtr<AudioParam> m_playbackRate;
+ // Used for the "gain", "detune" and "playbackRate" attributes.
+ Ref<AudioParam> m_gain;
+ Ref<AudioParam> m_detune;
+ Ref<AudioParam> m_playbackRate;
// If m_isLooping is false, then this node will be done playing and become inactive after it reaches the end of the sample data in the buffer.
// If true, it will wrap around to the start of the buffer each time it reaches the end.
- bool m_isLooping;
+ bool m_isLooping { false };
- double m_loopStart;
- double m_loopEnd;
+ double m_loopStart { 0 };
+ double m_loopEnd { 0 };
// m_virtualReadIndex is a sample-frame index into our buffer representing the current playback position.
// Since it's floating-point, it has sub-sample accuracy.
- double m_virtualReadIndex;
+ double m_virtualReadIndex { 0 };
// Granular playback
- bool m_isGrain;
- double m_grainOffset; // in seconds
+ bool m_isGrain { false };
+ double m_grainOffset { 0 }; // in seconds
double m_grainDuration; // in seconds
// totalPitchRate() returns the instantaneous pitch rate (non-time preserving).
@@ -141,11 +142,11 @@
double totalPitchRate();
// m_lastGain provides continuity when we dynamically adjust the gain.
- float m_lastGain;
+ float m_lastGain { 1.0 };
// We optionally keep track of a panner node which has a doppler shift that is incorporated into
// the pitch rate. We manually manage ref-counting because we want to use RefTypeConnection.
- PannerNodeBase* m_pannerNode;
+ PannerNodeBase* m_pannerNode { nullptr };
// This synchronizes process() with setBuffer() which can cause dynamic channel count changes.
mutable Lock m_processMutex;
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl (265232 => 265233)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2020-08-04 00:31:57 UTC (rev 265233)
@@ -27,6 +27,8 @@
Conditional=WEB_AUDIO,
JSGenerateToJSObject,
] interface AudioBufferSourceNode : AudioScheduledSourceNode {
+ [MayThrowException, EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional AudioBufferSourceOptions options);
+
attribute AudioBuffer? buffer;
const unsigned short UNSCHEDULED_STATE = 0;
@@ -34,15 +36,16 @@
const unsigned short PLAYING_STATE = 2;
const unsigned short FINISHED_STATE = 3;
- readonly attribute unsigned short playbackState;
+ readonly attribute unsigned short playbackState; // FIXME: This is not part of the specification.
- readonly attribute AudioParam gain;
+ readonly attribute AudioParam gain; // FIXME: This is not part of the specification.
+ [EnabledBySetting=ModernUnprefixedWebAudio] readonly attribute AudioParam detune;
readonly attribute AudioParam playbackRate;
attribute boolean loop;
- attribute unrestricted double loopStart;
- attribute unrestricted double loopEnd;
+ attribute double loopStart;
+ attribute double loopEnd;
- [MayThrowException, ImplementedAs=startLater] void start(optional unrestricted double when = 0, optional unrestricted double grainOffset = 0, optional unrestricted double grainDuration);
+ [MayThrowException, ImplementedAs=startLater] void start(optional double when = 0, optional double grainOffset = 0, optional double grainDuration);
};
Copied: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceOptions.h (from rev 265232, trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl) (0 => 265233)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceOptions.h (rev 0)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceOptions.h 2020-08-04 00:31:57 UTC (rev 265233)
@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2020, Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#if ENABLE(WEB_AUDIO)
+
+#include "AudioBuffer.h"
+
+namespace WebCore {
+
+struct AudioBufferSourceOptions {
+ RefPtr<AudioBuffer> buffer;
+ float detune { 0 };
+ bool loop { false };
+ double loopEnd { 0 };
+ double loopStart { 0 };
+ float playbackRate { 1 };
+};
+
+}
+
+#endif
Copied: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceOptions.idl (from rev 265232, trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl) (0 => 265233)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceOptions.idl (rev 0)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceOptions.idl 2020-08-04 00:31:57 UTC (rev 265233)
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2020, Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+[
+ Conditional=WEB_AUDIO
+] dictionary AudioBufferSourceOptions {
+ AudioBuffer? buffer;
+ float detune = 0;
+ boolean loop = false;
+ double loopEnd = 0;
+ double loopStart = 0;
+ float playbackRate = 1;
+};
Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp (265232 => 265233)
--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp 2020-08-04 00:31:57 UTC (rev 265233)
@@ -412,18 +412,7 @@
ALWAYS_LOG(LOGIDENTIFIER);
ASSERT(isMainThread());
-
- if (m_isStopScheduled)
- return Exception { InvalidStateError };
-
- lazyInitialize();
- Ref<AudioBufferSourceNode> node = AudioBufferSourceNode::create(*this, sampleRate());
-
- // Because this is an AudioScheduledSourceNode, the context keeps a reference until it has finished playing.
- // When this happens, AudioScheduledSourceNode::finish() calls BaseAudioContext::notifyNodeFinishedProcessing().
- refNode(node);
-
- return node;
+ return AudioBufferSourceNode::create(*this);
}
ExceptionOr<Ref<ScriptProcessorNode>> BaseAudioContext::createScriptProcessor(size_t bufferSize, size_t numberOfInputChannels, size_t numberOfOutputChannels)
Modified: trunk/Source/WebCore/Sources.txt (265232 => 265233)
--- trunk/Source/WebCore/Sources.txt 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/Sources.txt 2020-08-04 00:31:57 UTC (rev 265233)
@@ -2633,6 +2633,7 @@
JSAudioBufferCallback.cpp
JSAudioBufferOptions.cpp
JSAudioBufferSourceNode.cpp
+JSAudioBufferSourceOptions.cpp
JSAudioConfiguration.cpp
JSAudioContext.cpp
JSAudioContextLatencyCategory.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (265232 => 265233)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-08-04 00:24:07 UTC (rev 265232)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-08-04 00:31:57 UTC (rev 265233)
@@ -2480,6 +2480,7 @@
8372DB311A6780A800C697C5 /* DiagnosticLoggingResultType.h in Headers */ = {isa = PBXBuildFile; fileRef = 8372DB301A6780A800C697C5 /* DiagnosticLoggingResultType.h */; settings = {ATTRIBUTES = (Private, ); }; };
83745D0224D899D300FBDCC4 /* GainOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 83745CFF24D899C200FBDCC4 /* GainOptions.h */; };
83765F951DAC522F00C06537 /* MouseEventInit.h in Headers */ = {isa = PBXBuildFile; fileRef = 83765F941DAC521800C06537 /* MouseEventInit.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 8378878224D8A609000D4A5B /* AudioBufferSourceOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 8378877F24D8A5FC000D4A5B /* AudioBufferSourceOptions.h */; };
8379363F1FBBB0B400C8023C /* ServiceWorkerClientData.h in Headers */ = {isa = PBXBuildFile; fileRef = 8379363E1FBBB0A500C8023C /* ServiceWorkerClientData.h */; settings = {ATTRIBUTES = (Private, ); }; };
837964CF1F8DB69D00218EA0 /* GeolocationPositionDataIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = 837964CE1F8DB69A00218EA0 /* GeolocationPositionDataIOS.mm */; };
837A80131E1E127300026B9F /* Localizable.stringsdict in Resources */ = {isa = PBXBuildFile; fileRef = 837A80111E1E127300026B9F /* Localizable.stringsdict */; };
@@ -10534,6 +10535,8 @@
837609C81F54CC13000C122D /* ErrorCallback.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ErrorCallback.cpp; sourceTree = "<group>"; };
83765F931DAC521800C06537 /* MouseEventInit.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = MouseEventInit.idl; sourceTree = "<group>"; };
83765F941DAC521800C06537 /* MouseEventInit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MouseEventInit.h; sourceTree = "<group>"; };
+ 8378877F24D8A5FC000D4A5B /* AudioBufferSourceOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AudioBufferSourceOptions.h; sourceTree = "<group>"; };
+ 8378878124D8A5FC000D4A5B /* AudioBufferSourceOptions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = AudioBufferSourceOptions.idl; sourceTree = "<group>"; };
8379363C1FBBB0A400C8023C /* ServiceWorkerClientData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ServiceWorkerClientData.cpp; sourceTree = "<group>"; };
8379363E1FBBB0A500C8023C /* ServiceWorkerClientData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ServiceWorkerClientData.h; sourceTree = "<group>"; };
837964CE1F8DB69A00218EA0 /* GeolocationPositionDataIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = GeolocationPositionDataIOS.mm; path = Modules/geolocation/ios/GeolocationPositionDataIOS.mm; sourceTree = SOURCE_ROOT; };
@@ -15903,10 +15906,10 @@
E7E0352224CF60ED008DFEFB /* ChannelMergerOptions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = ChannelMergerOptions.idl; sourceTree = "<group>"; };
E7E0352424CF715E008DFEFB /* ChannelSplitterOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ChannelSplitterOptions.h; sourceTree = "<group>"; };
E7E0352524CF715E008DFEFB /* ChannelSplitterOptions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = ChannelSplitterOptions.idl; sourceTree = "<group>"; };
+ E7E0355724D346DF008DFEFB /* AudioBufferOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AudioBufferOptions.h; sourceTree = "<group>"; };
+ E7E0355924D346DF008DFEFB /* AudioBufferOptions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = AudioBufferOptions.idl; sourceTree = "<group>"; };
E7E0356F24D4E190008DFEFB /* AnalyserOptions.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = AnalyserOptions.idl; sourceTree = "<group>"; };
E7E0357124D4E191008DFEFB /* AnalyserOptions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AnalyserOptions.h; sourceTree = "<group>"; };
- E7E0355724D346DF008DFEFB /* AudioBufferOptions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AudioBufferOptions.h; sourceTree = "<group>"; };
- E7E0355924D346DF008DFEFB /* AudioBufferOptions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = AudioBufferOptions.idl; sourceTree = "<group>"; };
EB081CD81696084400553730 /* TypeConversions.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = TypeConversions.h; sourceTree = "<group>"; };
EB081CD91696084400553730 /* TypeConversions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = TypeConversions.idl; sourceTree = "<group>"; };
EBE5B224245A26EE003A5A88 /* SQLiteStatementAutoResetScope.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SQLiteStatementAutoResetScope.h; sourceTree = "<group>"; };
@@ -29501,6 +29504,8 @@
FD315FB112B0267500C1A359 /* AudioBufferSourceNode.cpp */,
FD315FB212B0267500C1A359 /* AudioBufferSourceNode.h */,
FD315FB312B0267500C1A359 /* AudioBufferSourceNode.idl */,
+ 8378877F24D8A5FC000D4A5B /* AudioBufferSourceOptions.h */,
+ 8378878124D8A5FC000D4A5B /* AudioBufferSourceOptions.idl */,
FD315FBA12B0267500C1A359 /* AudioContext.cpp */,
FD315FBB12B0267500C1A359 /* AudioContext.h */,
FD315FBC12B0267500C1A359 /* AudioContext.idl */,
@@ -30053,6 +30058,7 @@
FD315FF912B0267600C1A359 /* AudioBuffer.h in Headers */,
FD5686CC13AC181400B69C68 /* AudioBufferCallback.h in Headers */,
FD315FFC12B0267600C1A359 /* AudioBufferSourceNode.h in Headers */,
+ 8378878224D8A609000D4A5B /* AudioBufferSourceOptions.h in Headers */,
FD31607C12B026F700C1A359 /* AudioBus.h in Headers */,
FD31607E12B026F700C1A359 /* AudioChannel.h in Headers */,
FD31600512B0267600C1A359 /* AudioContext.h in Headers */,