Title: [265244] trunk/Source/WebCore
- Revision
- 265244
- Author
- you...@apple.com
- Date
- 2020-08-04 09:01:26 -0700 (Tue, 04 Aug 2020)
Log Message
Remove AudioSampleDataSource::setPaused
https://bugs.webkit.org/show_bug.cgi?id=215125
Reviewed by Geoffrey Garen.
m_paused is unused except for setting m_transitioningFromPaused.
setPaused is only used in AudioMediaStreamTrackRenderCocoa at creation of the source.
We can remove the call for setPaused(true) and remove setPaused/m_paused.
* platform/audio/mac/AudioSampleDataSource.h:
* platform/audio/mac/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::setPaused): Deleted.
* platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (265243 => 265244)
--- trunk/Source/WebCore/ChangeLog 2020-08-04 07:40:12 UTC (rev 265243)
+++ trunk/Source/WebCore/ChangeLog 2020-08-04 16:01:26 UTC (rev 265244)
@@ -1,3 +1,20 @@
+2020-08-04 Youenn Fablet <you...@apple.com>
+
+ Remove AudioSampleDataSource::setPaused
+ https://bugs.webkit.org/show_bug.cgi?id=215125
+
+ Reviewed by Geoffrey Garen.
+
+ m_paused is unused except for setting m_transitioningFromPaused.
+ setPaused is only used in AudioMediaStreamTrackRenderCocoa at creation of the source.
+ We can remove the call for setPaused(true) and remove setPaused/m_paused.
+
+ * platform/audio/mac/AudioSampleDataSource.h:
+ * platform/audio/mac/AudioSampleDataSource.mm:
+ (WebCore::AudioSampleDataSource::setPaused): Deleted.
+ * platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
+ (WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
+
2020-08-04 Rob Buis <rb...@igalia.com>
Performance.getEntriesByName/Type should match case sensitive
Modified: trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.h (265243 => 265244)
--- trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.h 2020-08-04 07:40:12 UTC (rev 265243)
+++ trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.h 2020-08-04 16:01:26 UTC (rev 265244)
@@ -65,8 +65,6 @@
bool pullAvalaibleSamplesAsChunks(AudioBufferList&, size_t frameCount, uint64_t timeStamp, Function<void()>&&);
- void setPaused(bool);
-
void setVolume(float volume) { m_volume = volume; }
float volume() const { return m_volume; }
@@ -115,7 +113,6 @@
float m_volume { 1.0 };
bool m_muted { false };
- bool m_paused { true };
bool m_transitioningFromPaused { true };
#if !RELEASE_LOG_DISABLED
Modified: trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm (265243 => 265244)
--- trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm 2020-08-04 07:40:12 UTC (rev 265243)
+++ trunk/Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm 2020-08-04 16:01:26 UTC (rev 265244)
@@ -75,15 +75,6 @@
}
}
-void AudioSampleDataSource::setPaused(bool paused)
-{
- if (paused == m_paused)
- return;
-
- m_transitioningFromPaused = m_paused;
- m_paused = paused;
-}
-
OSStatus AudioSampleDataSource::setupConverter()
{
ASSERT(m_inputDescription && m_outputDescription);
Modified: trunk/Source/WebCore/platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp (265243 => 265244)
--- trunk/Source/WebCore/platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp 2020-08-04 07:40:12 UTC (rev 265243)
+++ trunk/Source/WebCore/platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp 2020-08-04 16:01:26 UTC (rev 265244)
@@ -91,7 +91,6 @@
if (oldSource)
AudioMediaStreamTrackRendererUnit::singleton().removeSource(*oldSource);
- newSource->setPaused(false);
newSource->setVolume(volume());
AudioMediaStreamTrackRendererUnit::singleton().addSource(WTFMove(newSource));
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
