Title: [265267] trunk/Source/WebKit
- Revision
- 265267
- Author
- pvol...@apple.com
- Date
- 2020-08-04 16:10:17 -0700 (Tue, 04 Aug 2020)
Log Message
[iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid
https://bugs.webkit.org/show_bug.cgi?id=214965
Unreviewed, address review comments.
Add comment explaining why a set of MobileGestalt queries are performed when starting up the WebContent process on iOS.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265266 => 265267)
--- trunk/Source/WebKit/ChangeLog 2020-08-04 23:01:49 UTC (rev 265266)
+++ trunk/Source/WebKit/ChangeLog 2020-08-04 23:10:17 UTC (rev 265267)
@@ -1,5 +1,17 @@
2020-08-04 Per Arne Vollan <pvol...@apple.com>
+ [iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid
+ https://bugs.webkit.org/show_bug.cgi?id=214965
+
+ Unreviewed, address review comments.
+
+ Add comment explaining why a set of MobileGestalt queries are performed when starting up the WebContent process on iOS.
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::platformInitializeWebProcess):
+
+2020-08-04 Per Arne Vollan <pvol...@apple.com>
+
[iOS] Check that Accessibility is enabled when receiving the enable Accessibility notification
https://bugs.webkit.org/show_bug.cgi?id=215112
<rdar://problem/66498397>
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (265266 => 265267)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2020-08-04 23:01:49 UTC (rev 265266)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2020-08-04 23:10:17 UTC (rev 265267)
@@ -207,6 +207,12 @@
if (auto extension = SandboxExtension::create(WTFMove(*parameters.mobileGestaltExtensionHandle))) {
bool ok = extension->consume();
ASSERT_UNUSED(ok, ok);
+ // If we have an extension handle for MobileGestalt, it means the MobileGestalt cache is invalid.
+ // In this case, we perform a set of MobileGestalt queries while having access to the daemon,
+ // which will populate the MobileGestalt in-memory cache with correct values.
+ // The set of queries below was determined by finding all possible queries that have cachable
+ // values, and would reach out to the daemon for the answer. That way, the in-memory cache
+ // should be identical to a valid MobileGestalt cache after having queried all of these values.
#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)
MGGetFloat32Answer(kMGQMainScreenScale, 0);
MGGetSInt32Answer(kMGQMainScreenPitch, 0);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
