Title: [265288] trunk/LayoutTests
- Revision
- 265288
- Author
- [email protected]
- Date
- 2020-08-05 09:11:59 -0700 (Wed, 05 Aug 2020)
Log Message
[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215088
<rdar://problem/66489006>
Reviewed by Eric Carlson.
* platform/mac-wk2/TestExpectations:
* webrtc/datachannel/gather-candidates-networkprocess-crash.html:
Sending IPC to the network process is now happening in a background thread and in case of network process crash
we might need to wait a little bit longer since the socket creation/sending is not blocked on getting a proper connection.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (265287 => 265288)
--- trunk/LayoutTests/ChangeLog 2020-08-05 15:50:58 UTC (rev 265287)
+++ trunk/LayoutTests/ChangeLog 2020-08-05 16:11:59 UTC (rev 265288)
@@ -1,3 +1,16 @@
+2020-08-05 Youenn Fablet <[email protected]>
+
+ [ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=215088
+ <rdar://problem/66489006>
+
+ Reviewed by Eric Carlson.
+
+ * platform/mac-wk2/TestExpectations:
+ * webrtc/datachannel/gather-candidates-networkprocess-crash.html:
+ Sending IPC to the network process is now happening in a background thread and in case of network process crash
+ we might need to wait a little bit longer since the socket creation/sending is not blocked on getting a proper connection.
+
2020-08-05 Hector Lopez <[email protected]>
[ iOS ] imported/mozilla/svg/image/image-filter-01.svg is a constant failure
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (265287 => 265288)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-08-05 15:50:58 UTC (rev 265287)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-08-05 16:11:59 UTC (rev 265288)
@@ -1090,5 +1090,3 @@
webkit.org/b/214683 [ Debug ] imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit.html [ Pass Failure ]
webkit.org/b/214824 [ Debug ] js/throw-large-string-oom.html [ Skip ]
-
-webkit.org/b/215088 webrtc/datachannel/gather-candidates-networkprocess-crash.html [ Pass Timeout ]
\ No newline at end of file
Modified: trunk/LayoutTests/webrtc/datachannel/gather-candidates-networkprocess-crash.html (265287 => 265288)
--- trunk/LayoutTests/webrtc/datachannel/gather-candidates-networkprocess-crash.html 2020-08-05 15:50:58 UTC (rev 265287)
+++ trunk/LayoutTests/webrtc/datachannel/gather-candidates-networkprocess-crash.html 2020-08-05 16:11:59 UTC (rev 265288)
@@ -14,15 +14,25 @@
let offer = await pc.createOffer();
pc.setLocalDescription(offer);
// This test is a bit racy, we are trying to have network process crash between the time it receives a monitor start request and the time it answers that request.
- if (window.testRunner && testRunner.terminateNetworkProcess)
+ if (window.testRunner && testRunner.terminateNetworkProcess) {
setTimeout(() => testRunner.terminateNetworkProcess(), 0);
- await fetch(".").then(() => { }, () => { });
+ await new Promise(resolve => setTimeout(resolve, 50));
+ let hasResponse = false;
+ while (!hasResponse) {
+ const response = await fetch(".").then(r => r, () => { return { status : -1 } });
+ hasResponse = response.status !== -1;
+ }
+ }
+
let pc2 = new RTCPeerConnection();
pc2.createDataChannel('sendDataChannel');
- const iceCandidatePromise = new Promise(r => pc2._onicecandidate_ = r);
+ const iceCandidatePromise = new Promise((resolve, reject) => {
+ pc2._onicecandidate_ = resolve;
+ setTimeout(() => reject('ice candidate event time out'), 10000);
+ });
offer = await pc2.createOffer();
pc2.setLocalDescription(offer);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes