Title: [265419] trunk/Source/_javascript_Core
- Revision
- 265419
- Author
- [email protected]
- Date
- 2020-08-09 13:41:43 -0700 (Sun, 09 Aug 2020)
Log Message
[JSC] Make CommandLine on Worker agent (JSC shell feature for testing) work on iOS
https://bugs.webkit.org/show_bug.cgi?id=215311
<rdar://problem/66660053>
Reviewed by Mark Lam.
We should not reconfigure Options since this is once initialized. Since Options are frozen,
this results in crash.
* jsc.cpp:
(CommandLine::CommandLine):
(functionDollarAgentStart):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (265418 => 265419)
--- trunk/Source/_javascript_Core/ChangeLog 2020-08-09 18:23:44 UTC (rev 265418)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-08-09 20:41:43 UTC (rev 265419)
@@ -1,3 +1,18 @@
+2020-08-09 Yusuke Suzuki <[email protected]>
+
+ [JSC] Make CommandLine on Worker agent (JSC shell feature for testing) work on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=215311
+ <rdar://problem/66660053>
+
+ Reviewed by Mark Lam.
+
+ We should not reconfigure Options since this is once initialized. Since Options are frozen,
+ this results in crash.
+
+ * jsc.cpp:
+ (CommandLine::CommandLine):
+ (functionDollarAgentStart):
+
2020-08-09 Commit Queue <[email protected]>
Unreviewed, reverting r263195, r263252, and r265394.
Modified: trunk/Source/_javascript_Core/jsc.cpp (265418 => 265419)
--- trunk/Source/_javascript_Core/jsc.cpp 2020-08-09 18:23:44 UTC (rev 265418)
+++ trunk/Source/_javascript_Core/jsc.cpp 2020-08-09 20:41:43 UTC (rev 265419)
@@ -397,6 +397,11 @@
parseArguments(argc, argv);
}
+ enum CommandLineForWorkersTag { CommandLineForWorkers };
+ CommandLine(CommandLineForWorkersTag)
+ {
+ }
+
Vector<Script> m_scripts;
Vector<String> m_arguments;
String m_profilerOutput;
@@ -1869,7 +1874,7 @@
Thread::create(
"JSC Agent",
[sourceCode, &didStartLock, &didStartCondition, &didStart] () {
- CommandLine commandLine(0, nullptr);
+ CommandLine commandLine(CommandLine::CommandLineForWorkers);
commandLine.m_interactive = false;
runJSC(
commandLine, true,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
