Title: [265424] trunk/Source/WebKitLegacy/ios
- Revision
- 265424
- Author
- [email protected]
- Date
- 2020-08-10 01:18:02 -0700 (Mon, 10 Aug 2020)
Log Message
REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=215319
<rdar://problem/66688560>
Reviewed by Devin Rousso.
* WebCoreSupport/WebVisiblePosition.mm:
(+[DOMRange rangeForFirstPosition:second:]):
We want to ensure that firstPosition is *before* secondPosition, so
the change in r265176 got the condition backwards. Swap it.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (265423 => 265424)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2020-08-10 07:38:24 UTC (rev 265423)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2020-08-10 08:18:02 UTC (rev 265424)
@@ -1,3 +1,16 @@
+2020-08-10 Tim Horton <[email protected]>
+
+ REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=215319
+ <rdar://problem/66688560>
+
+ Reviewed by Devin Rousso.
+
+ * WebCoreSupport/WebVisiblePosition.mm:
+ (+[DOMRange rangeForFirstPosition:second:]):
+ We want to ensure that firstPosition is *before* secondPosition, so
+ the change in r265176 got the condition backwards. Swap it.
+
2020-08-04 Darin Adler <[email protected]>
Try to fix Catalyst build
Modified: trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm (265423 => 265424)
--- trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm 2020-08-10 07:38:24 UTC (rev 265423)
+++ trunk/Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm 2020-08-10 08:18:02 UTC (rev 265424)
@@ -478,7 +478,7 @@
{
auto firstPosition = [first _visiblePosition];
auto secondPosition = [second _visiblePosition];
- if (firstPosition < secondPosition)
+ if (secondPosition < firstPosition)
std::swap(firstPosition, secondPosition);
return kit(makeSimpleRange(firstPosition, secondPosition));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
