Title: [265427] trunk/Source/WebKit
- Revision
- 265427
- Author
- [email protected]
- Date
- 2020-08-10 08:23:44 -0700 (Mon, 10 Aug 2020)
Log Message
Add required entitlement for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=215244
Reviewed by Darin Adler.
The entitlement 'com.apple.private.webkit.use-xpc-endpoint' should be added to the WebContent process on Catalyst as well,
since it is needed on all Apple platforms. This entitlement is needed to support direct XPC communication between WebKit
processes, which is used to send the Launch Services database to the WebContent process from the Networking process. Also,
add some more logging related to this, to detect if it takes a long time for the WebContent process to receive the database.
* Scripts/process-entitlements.sh:
* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformDidReceiveLoadParameters):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265426 => 265427)
--- trunk/Source/WebKit/ChangeLog 2020-08-10 14:52:16 UTC (rev 265426)
+++ trunk/Source/WebKit/ChangeLog 2020-08-10 15:23:44 UTC (rev 265427)
@@ -1,3 +1,19 @@
+2020-08-10 Per Arne Vollan <[email protected]>
+
+ Add required entitlement for Catalyst
+ https://bugs.webkit.org/show_bug.cgi?id=215244
+
+ Reviewed by Darin Adler.
+
+ The entitlement 'com.apple.private.webkit.use-xpc-endpoint' should be added to the WebContent process on Catalyst as well,
+ since it is needed on all Apple platforms. This entitlement is needed to support direct XPC communication between WebKit
+ processes, which is used to send the Launch Services database to the WebContent process from the Networking process. Also,
+ add some more logging related to this, to detect if it takes a long time for the WebContent process to receive the database.
+
+ * Scripts/process-entitlements.sh:
+ * WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
+ (WebKit::WebPage::platformDidReceiveLoadParameters):
+
2020-08-09 Said Abou-Hallawa <[email protected]>
[macOS] Drag/drop an image of a unsupported format to an file input element should convert it to a supported format
Modified: trunk/Source/WebKit/Scripts/process-entitlements.sh (265426 => 265427)
--- trunk/Source/WebKit/Scripts/process-entitlements.sh 2020-08-10 14:52:16 UTC (rev 265426)
+++ trunk/Source/WebKit/Scripts/process-entitlements.sh 2020-08-10 15:23:44 UTC (rev 265427)
@@ -104,6 +104,7 @@
{
plistbuddy Add :com.apple.security.cs.allow-jit bool YES
plistbuddy Add :com.apple.runningboard.assertions.webkit bool YES
+ plistbuddy Add :com.apple.private.webkit.use-xpc-endpoint bool YES
if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 110000 ))
then
plistbuddy Add :com.apple.pac.shared_region_id string WebContent
@@ -122,6 +123,7 @@
plistbuddy Add :com.apple.private.network.socket-delegate bool YES
plistbuddy Add :com.apple.security.network.client bool YES
plistbuddy Add :com.apple.runningboard.assertions.webkit bool YES
+ plistbuddy Add :com.apple.private.webkit.use-xpc-endpoint bool YES
plistbuddy Add :com.apple.private.tcc.manager.check-by-audit-token array
plistbuddy Add :com.apple.private.tcc.manager.check-by-audit-token:0 string kTCCServiceWebKitIntelligentTrackingPrevention
Modified: trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm (265426 => 265427)
--- trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm 2020-08-10 14:52:16 UTC (rev 265426)
+++ trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm 2020-08-10 15:23:44 UTC (rev 265427)
@@ -65,10 +65,14 @@
void WebPage::platformDidReceiveLoadParameters(const LoadParameters& parameters)
{
#if HAVE(LSDATABASECONTEXT)
- bool databaseUpdated = LaunchServicesDatabaseManager::singleton().waitForDatabaseUpdate(5_s);
+ auto startTime = WallTime::now();
+ bool databaseUpdated = LaunchServicesDatabaseManager::singleton().waitForDatabaseUpdate(1_s);
+ auto elapsedTime = WallTime::now() - startTime;
+ if (elapsedTime.value() > 0.5)
+ RELEASE_LOG(Loading, "Waiting for Launch Services database update took %f seconds", elapsedTime.value());
ASSERT_UNUSED(databaseUpdated, databaseUpdated);
if (!databaseUpdated)
- WTFLogAlways("Timed out waiting for Launch Services database update.");
+ RELEASE_LOG_ERROR(Loading, "Timed out waiting for Launch Services database update.");
#endif
m_dataDetectionContext = parameters.dataDetectionContext;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
