Title: [265454] branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios
- Revision
- 265454
- Author
- [email protected]
- Date
- 2020-08-10 14:50:39 -0700 (Mon, 10 Aug 2020)
Log Message
Cherry-pick r265424. rdar://problem/66797266
REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=215319
<rdar://problem/66688560>
Reviewed by Devin Rousso.
* WebCoreSupport/WebVisiblePosition.mm:
(+[DOMRange rangeForFirstPosition:second:]):
We want to ensure that firstPosition is *before* secondPosition, so
the change in r265176 got the condition backwards. Swap it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios/ChangeLog (265453 => 265454)
--- branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios/ChangeLog 2020-08-10 21:13:18 UTC (rev 265453)
+++ branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios/ChangeLog 2020-08-10 21:50:39 UTC (rev 265454)
@@ -1,3 +1,33 @@
+2020-08-10 Russell Epstein <[email protected]>
+
+ Cherry-pick r265424. rdar://problem/66797266
+
+ REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=215319
+ <rdar://problem/66688560>
+
+ Reviewed by Devin Rousso.
+
+ * WebCoreSupport/WebVisiblePosition.mm:
+ (+[DOMRange rangeForFirstPosition:second:]):
+ We want to ensure that firstPosition is *before* secondPosition, so
+ the change in r265176 got the condition backwards. Swap it.
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-08-10 Tim Horton <[email protected]>
+
+ REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=215319
+ <rdar://problem/66688560>
+
+ Reviewed by Devin Rousso.
+
+ * WebCoreSupport/WebVisiblePosition.mm:
+ (+[DOMRange rangeForFirstPosition:second:]):
+ We want to ensure that firstPosition is *before* secondPosition, so
+ the change in r265176 got the condition backwards. Swap it.
+
2020-08-01 Darin Adler <[email protected]>
Remove Range::create and many more uses of live ranges
Modified: branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm (265453 => 265454)
--- branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm 2020-08-10 21:13:18 UTC (rev 265453)
+++ branches/safari-610.1.25.1-branch/Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm 2020-08-10 21:50:39 UTC (rev 265454)
@@ -477,7 +477,7 @@
{
auto firstVP = [first _visiblePosition];
auto secondVP = [second _visiblePosition];
- if (firstVP < secondVP)
+ if (secondVP < firstVP)
std::swap(firstVP, secondVP);
return kit(makeSimpleRange(firstVP, secondVP));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
