Title: [265528] trunk/Source/WebCore
Revision
265528
Author
[email protected]
Date
2020-08-11 15:36:06 -0700 (Tue, 11 Aug 2020)

Log Message

Have render tree dumps show overflow information
https://bugs.webkit.org/show_bug.cgi?id=215385

Reviewed by Zalan Bujtas.

Add code to RenderObject::outputRenderObject() to show layout/visual overflow, as we do
for render tree dumps.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::outputRenderObject const):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (265527 => 265528)


--- trunk/Source/WebCore/ChangeLog	2020-08-11 22:32:33 UTC (rev 265527)
+++ trunk/Source/WebCore/ChangeLog	2020-08-11 22:36:06 UTC (rev 265528)
@@ -1,3 +1,16 @@
+2020-08-11  Simon Fraser  <[email protected]>
+
+        Have render tree dumps show overflow information
+        https://bugs.webkit.org/show_bug.cgi?id=215385
+
+        Reviewed by Zalan Bujtas.
+
+        Add code to RenderObject::outputRenderObject() to show layout/visual overflow, as we do
+        for render tree dumps.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::outputRenderObject const):
+
 2020-08-11  Brady Eidson  <[email protected]>
 
         Add a "use stored credentials" setting to WKWebView.

Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (265527 => 265528)


--- trunk/Source/WebCore/rendering/RenderObject.cpp	2020-08-11 22:32:33 UTC (rev 265527)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2020-08-11 22:36:06 UTC (rev 265528)
@@ -1189,6 +1189,20 @@
         if (renderer.continuation())
             stream << " continuation->(" << renderer.continuation() << ")";
     }
+
+    if (is<RenderBox>(*this)) {
+        const auto& box = downcast<RenderBox>(*this);
+        if (box.hasRenderOverflow()) {
+            auto layoutOverflow = box.layoutOverflowRect();
+            stream << " (layout overflow " << layoutOverflow.x().toInt() << "," << layoutOverflow.y().toInt() << " " << layoutOverflow.width().toInt() << "x" << layoutOverflow.height().toInt() << ")";
+            
+            if (box.hasVisualOverflow()) {
+                auto visualOverflow = box.visualOverflowRect();
+                stream << " (visual overflow " << visualOverflow.x().toInt() << "," << visualOverflow.y().toInt() << " " << visualOverflow.width().toInt() << "x" << visualOverflow.height().toInt() << ")";
+            }
+        }
+    }
+
     outputRegionsInformation(stream);
     if (needsLayout()) {
         stream << " layout->";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to