Title: [104716] trunk/Source/WebCore
- Revision
- 104716
- Author
- [email protected]
- Date
- 2012-01-11 09:36:20 -0800 (Wed, 11 Jan 2012)
Log Message
Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
https://bugs.webkit.org/show_bug.cgi?id=76062
Patch by Peter Rybin <[email protected]> on 2012-01-11
Reviewed by Yury Semikhatsky.
This only changes how constants are named in generated .h file.
* inspector/CodeGeneratorInspector.py:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (104715 => 104716)
--- trunk/Source/WebCore/ChangeLog 2012-01-11 17:19:52 UTC (rev 104715)
+++ trunk/Source/WebCore/ChangeLog 2012-01-11 17:36:20 UTC (rev 104716)
@@ -1,3 +1,14 @@
+2012-01-11 Peter Rybin <[email protected]>
+
+ Web Inspector: CodeGeneratorInspector.py: fix codestyle of generated enums
+ https://bugs.webkit.org/show_bug.cgi?id=76062
+
+ Reviewed by Yury Semikhatsky.
+
+ This only changes how constants are named in generated .h file.
+
+ * inspector/CodeGeneratorInspector.py:
+
2012-01-11 Pavel Feldman <[email protected]>
Web Inspector: "undefined" instead of error message in the SourceFrame.
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (104715 => 104716)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-01-11 17:19:52 UTC (rev 104715)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py 2012-01-11 17:36:20 UTC (rev 104716)
@@ -707,14 +707,14 @@
writer.newline_multiline(
""" enum {
- NO_FIELDS_SET = 0,
+ NoFieldsSet = 0,
""")
state_enum_items = []
if len(main_properties) > 0:
pos = 0
for p in main_properties:
- item_name = Capitalizer.camel_case_to_capitalized_with_underscores(p["name"]) + "_SET"
+ item_name = Capitalizer.lower_camel_case_to_upper(p["name"]) + "Set"
state_enum_items.append(item_name)
writer.newline(" %s = 1 << %s,\n" % (item_name, pos))
pos += 1
@@ -723,7 +723,7 @@
all_fields_set_value = "0"
writer.newline_multiline(
-""" ALL_FIELDS_SET = %s
+""" AllFieldsSet = %s
};
template<int STATE>
@@ -738,7 +738,7 @@
Builder(PassRefPtr<%s> ptr)
{
- COMPILE_ASSERT(STATE == NO_FIELDS_SET, builder_created_in_non_init_state);
+ COMPILE_ASSERT(STATE == NoFieldsSet, builder_created_in_non_init_state);
m_result = ptr;
}
friend class %s;
@@ -779,7 +779,7 @@
writer.newline_multiline("""
operator RefPtr<%s>& ()
{
- COMPILE_ASSERT(STATE == ALL_FIELDS_SET, result_is_not_ready);
+ COMPILE_ASSERT(STATE == AllFieldsSet, result_is_not_ready);
return *reinterpret_cast<RefPtr<%s>*>(&m_result);
}
@@ -800,9 +800,9 @@
writer.append_multiline(";\n */\n")
writer.newline_multiline(
-""" static Builder<NO_FIELDS_SET> create()
+""" static Builder<NoFieldsSet> create()
{
- return Builder<NO_FIELDS_SET>(adoptRef(new %s()));
+ return Builder<NoFieldsSet>(adoptRef(new %s()));
}
""" % class_name)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
