Title: [265626] trunk/Source/WebKitLegacy/ios
Revision
265626
Author
[email protected]
Date
2020-08-13 15:19:15 -0700 (Thu, 13 Aug 2020)

Log Message

macCatalyst: Granting location permission doesn't allow geolocation access
https://bugs.webkit.org/show_bug.cgi?id=215464
<rdar://problem/64719458>

Reviewed by Wenson Hsieh.

* Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
Un-ifdef this code that was ifdeffed in r229963 during macCatalyst
bring-up and doesn't need to be anymore.

Modified Paths

Diff

Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (265625 => 265626)


--- trunk/Source/WebKitLegacy/ios/ChangeLog	2020-08-13 22:09:56 UTC (rev 265625)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog	2020-08-13 22:19:15 UTC (rev 265626)
@@ -1,3 +1,16 @@
+2020-08-13  Tim Horton  <[email protected]>
+
+        macCatalyst: Granting location permission doesn't allow geolocation access
+        https://bugs.webkit.org/show_bug.cgi?id=215464
+        <rdar://problem/64719458>
+
+        Reviewed by Wenson Hsieh.
+
+        * Misc/WebGeolocationCoreLocationProvider.mm:
+        (-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
+        Un-ifdef this code that was ifdeffed in r229963 during macCatalyst
+        bring-up and doesn't need to be anymore.
+
 2020-08-10  Tim Horton  <[email protected]>
 
         REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy 

Modified: trunk/Source/WebKitLegacy/ios/Misc/WebGeolocationCoreLocationProvider.mm (265625 => 265626)


--- trunk/Source/WebKitLegacy/ios/Misc/WebGeolocationCoreLocationProvider.mm	2020-08-13 22:09:56 UTC (rev 265625)
+++ trunk/Source/WebKitLegacy/ios/Misc/WebGeolocationCoreLocationProvider.mm	2020-08-13 22:19:15 UTC (rev 265626)
@@ -89,10 +89,6 @@
 
 - (void)requestGeolocationAuthorization
 {
-#if PLATFORM(MACCATALYST)
-    [_positionListener geolocationAuthorizationDenied];
-    return;
-#else
     if (![getCLLocationManagerClass() locationServicesEnabled]) {
         [_positionListener geolocationAuthorizationDenied];
         return;
@@ -116,7 +112,6 @@
         [_positionListener geolocationAuthorizationDenied];
         break;
     }
-#endif
 }
 
 static bool isAuthorizationGranted(CLAuthorizationStatus authorizationStatus)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to