Title: [265635] trunk/Source/WebCore
- Revision
- 265635
- Author
- [email protected]
- Date
- 2020-08-13 15:59:22 -0700 (Thu, 13 Aug 2020)
Log Message
Pocket City game play area is blank (WebGL is broken in Catalyst)
https://bugs.webkit.org/show_bug.cgi?id=215251
Follow-up review comments from Darin Adler.
* platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (265634 => 265635)
--- trunk/Source/WebCore/ChangeLog 2020-08-13 22:50:46 UTC (rev 265634)
+++ trunk/Source/WebCore/ChangeLog 2020-08-13 22:59:22 UTC (rev 265635)
@@ -1,3 +1,13 @@
+2020-08-13 Dean Jackson <[email protected]>
+
+ Pocket City game play area is blank (WebGL is broken in Catalyst)
+ https://bugs.webkit.org/show_bug.cgi?id=215251
+
+ Follow-up review comments from Darin Adler.
+
+ * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+ (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+
2020-08-13 Zalan Bujtas <[email protected]>
Add RenderTreeMutationDisallowedScope to track intrusive render tree mutations
Modified: trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm (265634 => 265635)
--- trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2020-08-13 22:50:46 UTC (rev 265634)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm 2020-08-13 22:59:22 UTC (rev 265635)
@@ -400,8 +400,11 @@
extensions.ensureEnabled(requiredExtensions[i]);
}
+#endif // PLATFORM(MAC) || PLATFORM(MACCATALYST)
#if PLATFORM(MAC)
+ // FIXME: It's unclear if MACCATALYST should take these steps as well, but that
+ // would require the PlatformScreenMac code to be exposed to Catalyst too.
EGLDeviceEXT device = nullptr;
EGL_QueryDisplayAttribEXT(m_displayObj, EGL_DEVICE_EXT, reinterpret_cast<EGLAttrib*>(&device));
CGLContextObj cglContext = nullptr;
@@ -414,10 +417,6 @@
UNUSED_PARAM(hostWindow);
#endif
-#else
- UNUSED_PARAM(hostWindow);
-#endif // PLATFORM(MAC)
-
#endif // #elif USE(ANGLE)
validateAttributes();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
