Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (265674 => 265675)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-14 17:22:40 UTC (rev 265675)
@@ -1,3 +1,26 @@
+2020-08-14 Patrick Angle <[email protected]>
+
+ REGRESSION (r265224): Web Inspector: LOCALIZED STRING NOT FOUND next to the Image checkbox in the Sources prefs panel
+ https://bugs.webkit.org/show_bug.cgi?id=215387
+ <rdar://problem/66855263>
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/LoadLocalizedStrings.js:
+ (WI.repeatedUIString.showTransparencyGridTooltip):
+ * UserInterface/Views/CanvasContentView.js:
+ (WI.CanvasContentView):
+ * UserInterface/Views/GraphicsOverviewContentView.js:
+ (WI.GraphicsOverviewContentView):
+ * UserInterface/Views/ImageResourceContentView.js:
+ * UserInterface/Views/RecordingContentView.js:
+ (WI.RecordingContentView):
+ * UserInterface/Views/ResourceCollectionContentView.js:
+ (WI.ResourceCollectionContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createSourcesSettingsView):
+
2020-08-12 Devin Rousso <[email protected]>
Web Inspector: REGRESSION(r259170): text inputs in box-shadow editor push sliders offscreen
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -1147,8 +1147,10 @@
localizedStrings["Show rulers"] = "Show rulers";
localizedStrings["Show the details sidebar (%s)"] = "Show the details sidebar (%s)";
localizedStrings["Show the navigation sidebar (%s)"] = "Show the navigation sidebar (%s)";
+/* Settings tab checkbox label for whether the transparency grid is shown by default */
+localizedStrings["Show transparency grid (settings label)"] = "Show transparency grid";
+/* Tooltip for showing the checkered transparency grid under images and canvases */
localizedStrings["Show transparency grid (tooltip)"] = "Show transparency grid";
-localizedStrings["Show transparency grid (settings label)"] = "Show transparency grid";
localizedStrings["Show type information"] = "Show type information";
localizedStrings["Show:"] = "Show:";
localizedStrings["Site-specific Hacks"] = "Site-specific Hacks";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/LoadLocalizedStrings.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Base/LoadLocalizedStrings.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/LoadLocalizedStrings.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -110,3 +110,7 @@
WI.repeatedUIString.revealInDOMTree = function() {
return WI.UIString("Reveal in DOM Tree", "Open Elements tab and select this node in DOM tree");
};
+
+WI.repeatedUIString.showTransparencyGridTooltip = function() {
+ return WI.UIString("Show transparency grid", "Show transparency grid (tooltip)", "Tooltip for showing the checkered transparency grid under images and canvases")
+};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -47,7 +47,7 @@
this._refreshButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this.handleRefreshButtonClicked, this);
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.repeatedUIString.showTransparencyGridTooltip(), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -39,7 +39,7 @@
this._refreshButtonNavigationItem = new WI.ButtonNavigationItem("refresh", WI.UIString("Refresh"), "Images/ReloadFull.svg", 13, 13);
this._refreshButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleRefreshButtonClicked, this);
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.repeatedUIString.showTransparencyGridTooltip(), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleShowGridButtonClicked, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -35,7 +35,7 @@
this._draggingInternalImageElement = false;
this._disableDropZone = disableDropZone || false;
- const toolTip = WI.UIString("Show transparency grid", "Show transparency grid (tooltip)");
+ const toolTip = WI.repeatedUIString.showTransparencyGridTooltip();
const activatedToolTip = WI.UIString("Hide transparency grid");
this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", toolTip, activatedToolTip, "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -58,7 +58,7 @@
this._showPathButtonNavigationItem.activated = !!WI.settings.showCanvasPath.value;
}
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.repeatedUIString.showTransparencyGridTooltip(), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._showGridButtonClicked, this);
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCollectionContentView.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -38,7 +38,7 @@
this.element.classList.add("resource-collection");
if (collection.resourceType === WI.Resource.Type.Image) {
- this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.UIString("Show transparency grid", "Show transparency grid (tooltip)"), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
+ this._showGridButtonNavigationItem = new WI.ActivateButtonNavigationItem("show-grid", WI.repeatedUIString.showTransparencyGridTooltip(), WI.UIString("Hide transparency grid"), "Images/NavigationItemCheckers.svg", 13, 13);
this._showGridButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleShowGridButtonClicked, this);
this._showGridButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._showGridButtonNavigationItem.activated = !!WI.settings.showImageGrid.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (265674 => 265675)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2020-08-14 16:47:17 UTC (rev 265674)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2020-08-14 17:22:40 UTC (rev 265675)
@@ -300,7 +300,7 @@
sourcesSettingsView.addSeparator();
- sourcesSettingsView.addSetting(WI.UIString("Images:"), WI.settings.showImageGrid, WI.UIString("Show transparency grid", "Show transparency grid (settings label)"));
+ sourcesSettingsView.addSetting(WI.UIString("Images:"), WI.settings.showImageGrid, WI.UIString("Show transparency grid", "Show transparency grid (settings label)", "Settings tab checkbox label for whether the transparency grid is shown by default"));
this._createReferenceLink(sourcesSettingsView);
