Title: [265686] trunk/Source/WebCore
Revision
265686
Author
[email protected]
Date
2020-08-14 11:53:02 -0700 (Fri, 14 Aug 2020)

Log Message

Simplify HTMLFrameElementBase::openURL
https://bugs.webkit.org/show_bug.cgi?id=215504

Patch by Rob Buis <[email protected]> on 2020-08-14
Reviewed by Darin Adler.

The _expression_ effectively uses the indirection document -> frame -> document, but
we can just use the document directly.

* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::openURL):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (265685 => 265686)


--- trunk/Source/WebCore/ChangeLog	2020-08-14 18:42:54 UTC (rev 265685)
+++ trunk/Source/WebCore/ChangeLog	2020-08-14 18:53:02 UTC (rev 265686)
@@ -1,3 +1,16 @@
+2020-08-14  Rob Buis  <[email protected]>
+
+        Simplify HTMLFrameElementBase::openURL
+        https://bugs.webkit.org/show_bug.cgi?id=215504
+
+        Reviewed by Darin Adler.
+
+        The _expression_ effectively uses the indirection document -> frame -> document, but
+        we can just use the document directly.
+
+        * html/HTMLFrameElementBase.cpp:
+        (WebCore::HTMLFrameElementBase::openURL):
+
 2020-08-14  Chris Dumez  <[email protected]>
 
         Make sure OfflineAudioContext::startOfflineRendering() does lazy initialization

Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.cpp (265685 => 265686)


--- trunk/Source/WebCore/html/HTMLFrameElementBase.cpp	2020-08-14 18:42:54 UTC (rev 265685)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.cpp	2020-08-14 18:53:02 UTC (rev 265686)
@@ -93,7 +93,7 @@
     if (!parentFrame)
         return;
 
-    document().willLoadFrameElement(parentFrame->document()->completeURL(m_URL));
+    document().willLoadFrameElement(document().completeURL(m_URL));
 
     String frameName = getNameAttribute();
     if (frameName.isNull() && UNLIKELY(document().settings().needsFrameNameFallbackToIdQuirk()))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to