Title: [265734] trunk/Source/WebCore
- Revision
- 265734
- Author
- [email protected]
- Date
- 2020-08-15 10:49:39 -0700 (Sat, 15 Aug 2020)
Log Message
Revert unnecessary change for https://bugs.webkit.org/show_bug.cgi?id=215521.
https://bugs.webkit.org/show_bug.cgi?id=215541
Reviewed by Chris Fleizach.
These additional checks are no longer necessary since makeSimpleRange
returns a null Optional if any of the VisiblePosition parameters is
null. Darin Adler already fixed the crasher in
https://bugs.webkit.org/show_bug.cgi?id=215521
with the patch
https://trac.webkit.org/changeset/265044/webkit.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rangeMatchesTextNearRange):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (265733 => 265734)
--- trunk/Source/WebCore/ChangeLog 2020-08-15 17:29:21 UTC (rev 265733)
+++ trunk/Source/WebCore/ChangeLog 2020-08-15 17:49:39 UTC (rev 265734)
@@ -1,3 +1,20 @@
+2020-08-15 Andres Gonzalez <[email protected]>
+
+ Revert unnecessary change for https://bugs.webkit.org/show_bug.cgi?id=215521.
+ https://bugs.webkit.org/show_bug.cgi?id=215541
+
+ Reviewed by Chris Fleizach.
+
+ These additional checks are no longer necessary since makeSimpleRange
+ returns a null Optional if any of the VisiblePosition parameters is
+ null. Darin Adler already fixed the crasher in
+ https://bugs.webkit.org/show_bug.cgi?id=215521
+ with the patch
+ https://trac.webkit.org/changeset/265044/webkit.
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::rangeMatchesTextNearRange):
+
2020-08-15 Youenn Fablet <[email protected]>
WritableStream rejected promises should be marked as handled as per spec
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (265733 => 265734)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2020-08-15 17:29:21 UTC (rev 265733)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2020-08-15 17:49:39 UTC (rev 265734)
@@ -2002,8 +2002,6 @@
startPosition = firstPositionInOrBeforeNode(originalRange.start.container.ptr());
if (endPosition.isNull())
endPosition = lastPositionInOrAfterNode(originalRange.end.container.ptr());
- if (startPosition.isNull() || endPosition.isNull())
- return WTF::nullopt;
auto searchRange = makeSimpleRange(startPosition, endPosition);
if (!searchRange || searchRange->collapsed())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
