Title: [265758] trunk/Source/WebKit
- Revision
- 265758
- Author
- [email protected]
- Date
- 2020-08-17 10:07:32 -0700 (Mon, 17 Aug 2020)
Log Message
Remove message check in WebSocketTask::readNextMessage
https://bugs.webkit.org/show_bug.cgi?id=215561
Reviewed by Alex Christensen.
This if check was added as a workaround to cases where both error and message were null.
This is no longer the case as per running existing tests with NSURLSession WebSocket code path on BigSur.
* NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::readNextMessage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265757 => 265758)
--- trunk/Source/WebKit/ChangeLog 2020-08-17 17:03:12 UTC (rev 265757)
+++ trunk/Source/WebKit/ChangeLog 2020-08-17 17:07:32 UTC (rev 265758)
@@ -1,5 +1,18 @@
2020-08-17 Youenn Fablet <[email protected]>
+ Remove message check in WebSocketTask::readNextMessage
+ https://bugs.webkit.org/show_bug.cgi?id=215561
+
+ Reviewed by Alex Christensen.
+
+ This if check was added as a workaround to cases where both error and message were null.
+ This is no longer the case as per running existing tests with NSURLSession WebSocket code path on BigSur.
+
+ * NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
+ (WebKit::WebSocketTask::readNextMessage):
+
+2020-08-17 Youenn Fablet <[email protected]>
+
Remove Cocoa WebSocketTask::send workaround
https://bugs.webkit.org/show_bug.cgi?id=215564
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm (265757 => 265758)
--- trunk/Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm 2020-08-17 17:03:12 UTC (rev 265757)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm 2020-08-17 17:07:32 UTC (rev 265758)
@@ -74,11 +74,6 @@
didClose(WebCore::WebSocketChannel::CloseEventCodeAbnormalClosure, emptyString());
return;
}
- if (!message) {
- // FIXME: this is a workaround and we should probably never get there.
- didClose(1000, "Unknown error");
- return;
- }
if (message.type == NSURLSessionWebSocketMessageTypeString)
m_channel.didReceiveText(message.string);
else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
