Diff
Modified: trunk/JSTests/ChangeLog (266179 => 266180)
--- trunk/JSTests/ChangeLog 2020-08-26 18:49:00 UTC (rev 266179)
+++ trunk/JSTests/ChangeLog 2020-08-26 19:36:45 UTC (rev 266180)
@@ -1,5 +1,15 @@
2020-08-26 Yusuke Suzuki <[email protected]>
+ [JSC] Enable Intl.Segmenter
+ https://bugs.webkit.org/show_bug.cgi?id=215854
+
+ Reviewed by Ross Kirsling.
+
+ * stress/intl-segmenter.js:
+ * test262/config.yaml:
+
+2020-08-26 Yusuke Suzuki <[email protected]>
+
[JSC] Add ASCII comparison fast path for IntlCollator
https://bugs.webkit.org/show_bug.cgi?id=215798
Modified: trunk/JSTests/stress/intl-segmenter.js (266179 => 266180)
--- trunk/JSTests/stress/intl-segmenter.js 2020-08-26 18:49:00 UTC (rev 266179)
+++ trunk/JSTests/stress/intl-segmenter.js 2020-08-26 19:36:45 UTC (rev 266180)
@@ -1,7 +1,5 @@
//@ skip if $architecture == "mips" # Due to ICU version. MIPS maintainer can look into the results and update.
-//@ runDefault("--useIntlSegmenter=1")
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error('bad value: ' + actual);
Modified: trunk/JSTests/test262/config.yaml (266179 => 266180)
--- trunk/JSTests/test262/config.yaml 2020-08-26 18:49:00 UTC (rev 266179)
+++ trunk/JSTests/test262/config.yaml 2020-08-26 19:36:45 UTC (rev 266180)
@@ -6,7 +6,6 @@
FinalizationRegistry: useWeakRefs
class-fields-public: usePublicClassFields
class-fields-private: usePrivateClassFields
- Intl.Segmenter: useIntlSegmenter
skip:
features:
- SharedArrayBuffer
Modified: trunk/Source/_javascript_Core/ChangeLog (266179 => 266180)
--- trunk/Source/_javascript_Core/ChangeLog 2020-08-26 18:49:00 UTC (rev 266179)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-08-26 19:36:45 UTC (rev 266180)
@@ -1,5 +1,18 @@
2020-08-26 Yusuke Suzuki <[email protected]>
+ [JSC] Enable Intl.Segmenter
+ https://bugs.webkit.org/show_bug.cgi?id=215854
+
+ Reviewed by Ross Kirsling.
+
+ This is already stage-3 and all the features are implemented. Let's just enable it.
+
+ * runtime/IntlObject.cpp:
+ (JSC::IntlObject::finishCreation):
+ * runtime/OptionsList.h:
+
+2020-08-26 Yusuke Suzuki <[email protected]>
+
[JSC] Add ASCII comparison fast path for IntlCollator
https://bugs.webkit.org/show_bug.cgi?id=215798
Modified: trunk/Source/_javascript_Core/runtime/IntlObject.cpp (266179 => 266180)
--- trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2020-08-26 18:49:00 UTC (rev 266179)
+++ trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2020-08-26 19:36:45 UTC (rev 266180)
@@ -143,6 +143,7 @@
NumberFormat createNumberFormatConstructor DontEnum|PropertyCallback
PluralRules createPluralRulesConstructor DontEnum|PropertyCallback
RelativeTimeFormat createRelativeTimeFormatConstructor DontEnum|PropertyCallback
+ Segmenter createSegmenterConstructor DontEnum|PropertyCallback
@end
*/
@@ -182,8 +183,6 @@
#else
UNUSED_PARAM(createDisplayNamesConstructor);
#endif
- if (Options::useIntlSegmenter())
- putDirectWithoutTransition(vm, vm.propertyNames->Segmenter, createSegmenterConstructor(vm, this), static_cast<unsigned>(PropertyAttribute::DontEnum));
}
Structure* IntlObject::createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype)
Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (266179 => 266180)
--- trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-08-26 18:49:00 UTC (rev 266179)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-08-26 19:36:45 UTC (rev 266180)
@@ -490,7 +490,6 @@
/* FIXME: We should make sure finalizers don't run for detached windows before enabling WeakRefs by default. https://bugs.webkit.org/show_bug.cgi?id=214508 */ \
v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \
v(Bool, useBigInt, true, Normal, "If true, we will enable BigInt support.") \
- v(Bool, useIntlSegmenter, false, Normal, "Expose the Intl.Segmenter constructor.") \
v(Bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.") \
v(Bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.") \
v(Bool, forceMiniVMMode, false, Normal, "If true, it will force mini VM mode on.") \
