Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-08-28 17:24:00 UTC (rev 266283)
@@ -1,3 +1,21 @@
+2020-08-28 Youenn Fablet <[email protected]>
+
+ initializeReadableStream should check for highWaterMark be undefined
+ https://bugs.webkit.org/show_bug.cgi?id=215890
+
+ Reviewed by Alex Christensen.
+
+ * web-platform-tests/streams/transform-streams/backpressure.any-expected.txt:
+ * web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt:
+ * web-platform-tests/streams/transform-streams/errors.any-expected.txt:
+ * web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt:
+ * web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt:
+ * web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt:
+ * web-platform-tests/streams/transform-streams/strategies.any-expected.txt:
+ * web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt:
+ * web-platform-tests/streams/transform-streams/terminate.any-expected.txt:
+ * web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt:
+
2020-08-28 Chris Lord <[email protected]>
Add WebGL(2) context support to OffscreenCanvas
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -1,6 +1,6 @@
CONSOLE MESSAGE: Unhandled Promise Rejection: error1: error1 message
-FAIL backpressure allows no transforms with a default identity transform and no reader assert_array_equals: transform should not be called lengths differ, expected array [] length 0, got ["transform", "a"] length 2
+PASS backpressure allows no transforms with a default identity transform and no reader
PASS backpressure only allows one transform() with a identity transform with a readable HWM of 1 and no reader
PASS transform() should keep being called as long as there is no backpressure
PASS writes should resolve as soon as transform completes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/backpressure.any.worker-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -1,5 +1,5 @@
-FAIL backpressure allows no transforms with a default identity transform and no reader assert_array_equals: transform should not be called lengths differ, expected array [] length 0, got ["transform", "a"] length 2
+PASS backpressure allows no transforms with a default identity transform and no reader
PASS backpressure only allows one transform() with a identity transform with a readable HWM of 1 and no reader
PASS transform() should keep being called as long as there is no backpressure
PASS writes should resolve as soon as transform completes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -17,6 +17,6 @@
PASS controller.error() should do nothing after writable.abort() has completed
PASS controller.error() should do nothing after a transformer method has thrown an exception
PASS erroring during write with backpressure should result in the write failing
-FAIL a write() that was waiting for backpressure should reject if the writable is aborted assert_unreached: Should have rejected: read() should reject Reached unreachable code
+PASS a write() that was waiting for backpressure should reject if the writable is aborted
PASS the readable should be errored with the reason passed to the writable abort() method
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/errors.any.worker-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -17,6 +17,6 @@
PASS controller.error() should do nothing after writable.abort() has completed
PASS controller.error() should do nothing after a transformer method has thrown an exception
PASS erroring during write with backpressure should result in the write failing
-FAIL a write() that was waiting for backpressure should reject if the writable is aborted assert_unreached: Should have rejected: read() should reject Reached unreachable code
+PASS a write() that was waiting for backpressure should reject if the writable is aborted
PASS the readable should be errored with the reason passed to the writable abort() method
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -5,7 +5,7 @@
PASS desiredSize inside size() should work
PASS readable cancel() inside size() should work
PASS pipeTo() inside size() should work
-FAIL read() inside of size() should work assert_false: expected false got true
+PASS read() inside of size() should work
PASS writer.write() inside size() should work
PASS synchronous writer.write() inside size() should work
PASS writer.close() inside size() should work
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.worker-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -5,7 +5,7 @@
PASS desiredSize inside size() should work
PASS readable cancel() inside size() should work
PASS pipeTo() inside size() should work
-FAIL read() inside of size() should work assert_false: expected false got true
+PASS read() inside of size() should work
PASS writer.write() inside size() should work
PASS synchronous writer.write() inside size() should work
PASS writer.close() inside size() should work
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -3,7 +3,7 @@
PASS readableStrategy highWaterMark should work
PASS writable should have the correct size() function
PASS default writable strategy should be equivalent to { highWaterMark: 1 }
-FAIL default readable strategy should be equivalent to { highWaterMark: 0 } assert_equals: desiredSize should be 0 expected 0 but got 1
+PASS default readable strategy should be equivalent to { highWaterMark: 0 }
PASS a RangeError should be thrown for an invalid highWaterMark
PASS writableStrategy highWaterMark should be converted to a number
PASS readableStrategy highWaterMark should be converted to a number
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/strategies.any.worker-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -3,7 +3,7 @@
PASS readableStrategy highWaterMark should work
PASS writable should have the correct size() function
PASS default writable strategy should be equivalent to { highWaterMark: 1 }
-FAIL default readable strategy should be equivalent to { highWaterMark: 0 } assert_equals: desiredSize should be 0 expected 0 but got 1
+PASS default readable strategy should be equivalent to { highWaterMark: 0 }
PASS a RangeError should be thrown for an invalid highWaterMark
PASS writableStrategy highWaterMark should be converted to a number
PASS readableStrategy highWaterMark should be converted to a number
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -1,6 +1,9 @@
CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: the stream has been terminated
+CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: the stream has been terminated
-FAIL controller.terminate() should error pipeTo() assert_array_equals: transform() should have seen no chunks lengths differ, expected array [] length 0, got ["transform", 0] length 2
+Harness Error (FAIL), message = Unhandled rejection: the stream has been terminated
+
+PASS controller.terminate() should error pipeTo()
PASS controller.terminate() should prevent remaining chunks from being processed
PASS controller.enqueue() should throw after controller.terminate()
PASS controller.error() after controller.terminate() with queued chunk should error the readable
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt (266282 => 266283)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/terminate.any.worker-expected.txt 2020-08-28 17:24:00 UTC (rev 266283)
@@ -1,5 +1,7 @@
-FAIL controller.terminate() should error pipeTo() assert_array_equals: transform() should have seen no chunks lengths differ, expected array [] length 0, got ["transform", 0] length 2
+Harness Error (FAIL), message = Unhandled rejection: the stream has been terminated
+
+PASS controller.terminate() should error pipeTo()
PASS controller.terminate() should prevent remaining chunks from being processed
PASS controller.enqueue() should throw after controller.terminate()
PASS controller.error() after controller.terminate() with queued chunk should error the readable
Modified: trunk/Source/WebCore/ChangeLog (266282 => 266283)
--- trunk/Source/WebCore/ChangeLog 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/Source/WebCore/ChangeLog 2020-08-28 17:24:00 UTC (rev 266283)
@@ -1,3 +1,15 @@
+2020-08-28 Youenn Fablet <[email protected]>
+
+ initializeReadableStream should check for highWaterMark be undefined
+ https://bugs.webkit.org/show_bug.cgi?id=215890
+
+ Reviewed by Alex Christensen.
+
+ Covered by updated tests.
+
+ * Modules/streams/ReadableStream.js:
+ (initializeReadableStream):
+
2020-08-28 Ryosuke Niwa <[email protected]>
Remove adopted node from TextManipulationController
Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.js (266282 => 266283)
--- trunk/Source/WebCore/Modules/streams/ReadableStream.js 2020-08-28 17:14:51 UTC (rev 266282)
+++ trunk/Source/WebCore/Modules/streams/ReadableStream.js 2020-08-28 17:24:00 UTC (rev 266283)
@@ -51,7 +51,7 @@
if (@getByIdDirectPrivate(underlyingSource, "pull") !== @undefined) {
const size = @getByIdDirectPrivate(strategy, "size");
const highWaterMark = @getByIdDirectPrivate(strategy, "highWaterMark");
- @setupReadableStreamDefaultController(this, underlyingSource, size, highWaterMark ? highWaterMark : 1, @getByIdDirectPrivate(underlyingSource, "start"), @getByIdDirectPrivate(underlyingSource, "pull"), @getByIdDirectPrivate(underlyingSource, "cancel"));
+ @setupReadableStreamDefaultController(this, underlyingSource, size, highWaterMark !== @undefined ? highWaterMark : 1, @getByIdDirectPrivate(underlyingSource, "start"), @getByIdDirectPrivate(underlyingSource, "pull"), @getByIdDirectPrivate(underlyingSource, "cancel"));
return this;
}
