Title: [266288] trunk
- Revision
- 266288
- Author
- [email protected]
- Date
- 2020-08-28 11:37:58 -0700 (Fri, 28 Aug 2020)
Log Message
Fix text-transform inheritance to ::marker
https://bugs.webkit.org/show_bug.cgi?id=214359
Patch by Tyler Wilcock <[email protected]> on 2020-08-28
Reviewed by Darin Adler.
Per https://github.com/w3c/csswg-drafts/issues/4206, default ::marker
pseudoelement style to `text-transform: none` in the UA stylesheet to
avoid surprising effects from inheritance.
No tests added -- change is tested by existing WPTs.
* css/html.css:
(::marker):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-default-styles-expected.txt (266287 => 266288)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-default-styles-expected.txt 2020-08-28 18:33:52 UTC (rev 266287)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-default-styles-expected.txt 2020-08-28 18:37:58 UTC (rev 266288)
@@ -1,18 +1,18 @@
FAIL Computed value of 'unicode-bidi' for outside symbol assert_equals: expected "isolate" but got "normal"
-FAIL Computed value of 'font-variant-numeric' for outside symbol assert_equals: expected "tabular-nums" but got "normal"
+PASS Computed value of 'font-variant-numeric' for outside symbol
FAIL Computed value of 'unicode-bidi' for outside decimal assert_equals: expected "isolate" but got "normal"
-FAIL Computed value of 'font-variant-numeric' for outside decimal assert_equals: expected "tabular-nums" but got "normal"
+PASS Computed value of 'font-variant-numeric' for outside decimal
FAIL Computed value of 'unicode-bidi' for outside string assert_equals: expected "isolate" but got "normal"
-FAIL Computed value of 'font-variant-numeric' for outside string assert_equals: expected "tabular-nums" but got "normal"
+PASS Computed value of 'font-variant-numeric' for outside string
FAIL Computed value of 'unicode-bidi' for outside marker assert_equals: expected "isolate" but got "normal"
PASS Computed value of 'font-variant-numeric' for outside marker
FAIL Computed value of 'unicode-bidi' for inside symbol assert_equals: expected "isolate" but got "normal"
-FAIL Computed value of 'font-variant-numeric' for inside symbol assert_equals: expected "tabular-nums" but got "normal"
+PASS Computed value of 'font-variant-numeric' for inside symbol
FAIL Computed value of 'unicode-bidi' for inside decimal assert_equals: expected "isolate" but got "normal"
-FAIL Computed value of 'font-variant-numeric' for inside decimal assert_equals: expected "tabular-nums" but got "normal"
+PASS Computed value of 'font-variant-numeric' for inside decimal
FAIL Computed value of 'unicode-bidi' for inside string assert_equals: expected "isolate" but got "normal"
-FAIL Computed value of 'font-variant-numeric' for inside string assert_equals: expected "tabular-nums" but got "normal"
+PASS Computed value of 'font-variant-numeric' for inside string
FAIL Computed value of 'unicode-bidi' for inside marker assert_equals: expected "isolate" but got "normal"
PASS Computed value of 'font-variant-numeric' for inside marker
outside symbol
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-reverted-styles-expected.txt (266287 => 266288)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-reverted-styles-expected.txt 2020-08-28 18:33:52 UTC (rev 266287)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-reverted-styles-expected.txt 2020-08-28 18:37:58 UTC (rev 266288)
@@ -1,11 +1,11 @@
-FAIL Reverted computed values for outside symbol assert_object_equals: property "font-variant-numeric" expected "normal" got "tabular-nums"
-FAIL Reverted computed values for outside decimal assert_object_equals: property "font-variant-numeric" expected "normal" got "tabular-nums"
-FAIL Reverted computed values for outside string assert_object_equals: property "font-variant-numeric" expected "normal" got "tabular-nums"
+PASS Reverted computed values for outside symbol
+PASS Reverted computed values for outside decimal
+PASS Reverted computed values for outside string
PASS Reverted computed values for outside marker
-FAIL Reverted computed values for inside symbol assert_object_equals: property "font-variant-numeric" expected "normal" got "tabular-nums"
-FAIL Reverted computed values for inside decimal assert_object_equals: property "font-variant-numeric" expected "normal" got "tabular-nums"
-FAIL Reverted computed values for inside string assert_object_equals: property "font-variant-numeric" expected "normal" got "tabular-nums"
+PASS Reverted computed values for inside symbol
+PASS Reverted computed values for inside decimal
+PASS Reverted computed values for inside string
PASS Reverted computed values for inside marker
outside symbol
outside decimal
Modified: trunk/Source/WebCore/ChangeLog (266287 => 266288)
--- trunk/Source/WebCore/ChangeLog 2020-08-28 18:33:52 UTC (rev 266287)
+++ trunk/Source/WebCore/ChangeLog 2020-08-28 18:37:58 UTC (rev 266288)
@@ -1,3 +1,19 @@
+2020-08-28 Tyler Wilcock <[email protected]>
+
+ Fix text-transform inheritance to ::marker
+ https://bugs.webkit.org/show_bug.cgi?id=214359
+
+ Reviewed by Darin Adler.
+
+ Per https://github.com/w3c/csswg-drafts/issues/4206, default ::marker
+ pseudoelement style to `text-transform: none` in the UA stylesheet to
+ avoid surprising effects from inheritance.
+
+ No tests added -- change is tested by existing WPTs.
+
+ * css/html.css:
+ (::marker):
+
2020-08-28 Said Abou-Hallawa <[email protected]>
Remove the system tracing from DisplayList::Replayer::replay()
Modified: trunk/Source/WebCore/css/html.css (266287 => 266288)
--- trunk/Source/WebCore/css/html.css 2020-08-28 18:33:52 UTC (rev 266287)
+++ trunk/Source/WebCore/css/html.css 2020-08-28 18:37:58 UTC (rev 266288)
@@ -302,6 +302,10 @@
text-align: -webkit-match-parent;
}
+::marker {
+ text-transform: none;
+}
+
ul ul, ol ul {
list-style-type: circle;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
