Title: [104793] trunk/Source/WebCore
- Revision
- 104793
- Author
- [email protected]
- Date
- 2012-01-11 23:07:16 -0800 (Wed, 11 Jan 2012)
Log Message
QuerySelector should not have side effect.
https://bugs.webkit.org/show_bug.cgi?id=75298
Patch by Shinya Kawanaka <[email protected]> on 2012-01-11
Reviewed by Antti Koivisto.
Since SelectorChecker is not collecting-rules-only mode, it may set some flags in render styles
if some pseudo types (e.g. first-of-type) are used.
No new tests. Covered by existing tests.
* dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::SelectorQuery):
Made collecting rules only.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (104792 => 104793)
--- trunk/Source/WebCore/ChangeLog 2012-01-12 06:58:58 UTC (rev 104792)
+++ trunk/Source/WebCore/ChangeLog 2012-01-12 07:07:16 UTC (rev 104793)
@@ -1,3 +1,19 @@
+2012-01-11 Shinya Kawanaka <[email protected]>
+
+ QuerySelector should not have side effect.
+ https://bugs.webkit.org/show_bug.cgi?id=75298
+
+ Reviewed by Antti Koivisto.
+
+ Since SelectorChecker is not collecting-rules-only mode, it may set some flags in render styles
+ if some pseudo types (e.g. first-of-type) are used.
+
+ No new tests. Covered by existing tests.
+
+ * dom/SelectorQuery.cpp:
+ (WebCore::SelectorQuery::SelectorQuery):
+ Made collecting rules only.
+
2012-01-11 Dan Bernstein <[email protected]>
<rdar://problem/10679035> Implement font-variant-ligatures: {no-}common-ligatures
Modified: trunk/Source/WebCore/dom/SelectorQuery.cpp (104792 => 104793)
--- trunk/Source/WebCore/dom/SelectorQuery.cpp 2012-01-12 06:58:58 UTC (rev 104792)
+++ trunk/Source/WebCore/dom/SelectorQuery.cpp 2012-01-12 07:07:16 UTC (rev 104793)
@@ -37,6 +37,8 @@
: m_rootNode(rootNode)
, m_selectorChecker(rootNode->document(), !rootNode->document()->inQuirksMode())
{
+ m_selectorChecker.setCollectingRulesOnly(true);
+
for (CSSSelector* selector = selectorList.first(); selector; selector = CSSSelectorList::next(selector))
m_selectors.append(SelectorData(selector, SelectorChecker::isFastCheckableSelector(selector)));
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
