Title: [104809] trunk/PerformanceTests
- Revision
- 104809
- Author
- [email protected]
- Date
- 2012-01-12 04:06:08 -0800 (Thu, 12 Jan 2012)
Log Message
Web Inspector: performance tests: fix memory leak in first-open-resources test.
https://bugs.webkit.org/show_bug.cgi?id=76049
first-open-resources doesn't reset resource panel properly after test run.
Reviewed by Yury Semikhatsky.
* inspector/first-open-resources.html:
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (104808 => 104809)
--- trunk/PerformanceTests/ChangeLog 2012-01-12 11:54:41 UTC (rev 104808)
+++ trunk/PerformanceTests/ChangeLog 2012-01-12 12:06:08 UTC (rev 104809)
@@ -1,3 +1,14 @@
+2012-01-12 Ilya Tikhonovsky <[email protected]>
+
+ Web Inspector: performance tests: fix memory leak in first-open-resources test.
+ https://bugs.webkit.org/show_bug.cgi?id=76049
+
+ first-open-resources doesn't reset resource panel properly after test run.
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/first-open-resources.html:
+
2012-01-10 Ilya Tikhonovsky <[email protected]>
Unreviewed. WebInspector: Remove unnecessary logging from the test.
Modified: trunk/PerformanceTests/inspector/first-open-resources.html (104808 => 104809)
--- trunk/PerformanceTests/inspector/first-open-resources.html 2012-01-12 11:54:41 UTC (rev 104808)
+++ trunk/PerformanceTests/inspector/first-open-resources.html 2012-01-12 12:06:08 UTC (rev 104809)
@@ -12,18 +12,26 @@
function test(timer)
{
WebInspector.showPanel("audits");
+ var resources = WebInspector.panels.resources;
+ resources.reset();
+ var treeModel = WebInspector.resourceTreeModel;
+ treeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameAdded, resources._frameAdded, resources);
+ treeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameNavigated, resources._frameNavigated, resources);
+ treeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameDetached, resources._frameDetached, resources);
+ treeModel.removeEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, resources._resourceAdded, resources);
+ resources._initialized = false;
+ InspectorTest.addBackendResponseSniffer(ApplicationCacheAgent, "getFramesWithManifests", finish);
var showPanelTimerCookie = timer.start("first-open-resources");
- InspectorTest.addBackendResponseSniffer(PageAgent, "getResourceTree", function() {
+ treeModel._fetchResourceTree();
+ WebInspector.showPanel("resources");
+
+ function finish()
+ {
timer.finish(showPanelTimerCookie);
timer.done("first-open");
- });
- WebInspector.panels.resources.reset();
- WebInspector.panels.resources._initialized = false;
- WebInspector.resourceTreeModel._fetchResourceTree();
- WebInspector.showPanel("resources");
+ }
}
-
InspectorTest.runPerformanceTest(test, 5000);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
