Diff
Modified: trunk/LayoutTests/ChangeLog (266445 => 266446)
--- trunk/LayoutTests/ChangeLog 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/ChangeLog 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,3 +1,15 @@
+2020-09-01 Hector Lopez <[email protected]>
+
+ Unreviewed, reverting r266408.
+
+ Revision caused constant crashes on iOS and macOS
+
+ Reverted changeset:
+
+ "Convert runtime flag to setting for lazy image loading"
+ https://bugs.webkit.org/show_bug.cgi?id=215610
+ https://trac.webkit.org/changeset/266408
+
2020-09-01 Dean Jackson <[email protected]>
REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
Modified: trunk/LayoutTests/TestExpectations (266445 => 266446)
--- trunk/LayoutTests/TestExpectations 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/TestExpectations 2020-09-02 01:56:22 UTC (rev 266446)
@@ -550,7 +550,6 @@
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-modify-scrolling-attr-to-yes.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adopt-from-image-document.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow-aspect-ratio.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/dynamic-content-change-rendering.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/reset-algorithm-rendering.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/multiline-placeholder-cr.html [ ImageOnlyFailure ]
@@ -575,6 +574,7 @@
imported/w3c/web-platform-tests/html/webappapis/update-rendering/child-document-raf-order.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-lazy.tentative.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative.html [ Failure Pass ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/semantics/forms/autofocus/update-the-rendering.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/muted-errors.sub.html [ Failure Pass ]
imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.any.html [ Failure Pass ]
Modified: trunk/LayoutTests/http/tests/lazyload/attribute.html (266445 => 266446)
--- trunk/LayoutTests/http/tests/lazyload/attribute.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/http/tests/lazyload/attribute.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,13 +1,8 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<script src=""
<script src=""
<script src=""
-<script>
- if (window.internals)
- internals.settings.setLazyImageLoadingEnabled(true);
-</script>
-
<body>
<div style="height:10000px;"></div>
<img id="no_attribute_img" src=''>
Modified: trunk/LayoutTests/http/tests/lazyload/js-image.html (266445 => 266446)
--- trunk/LayoutTests/http/tests/lazyload/js-image.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/http/tests/lazyload/js-image.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<script src=""
<script src=""
<script src=""
@@ -8,8 +8,6 @@
</body>
<script>
- if (window.internals)
- internals.settings.setLazyImageLoadingEnabled(true);
async_test(function(t) {
const img = new Image();
img._onload_ = t.step_func_done(function() {
Modified: trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html (266445 => 266446)
--- trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,10 +1,8 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<script src=""
<script src=""
<script src=""
<script>
- if (window.internals)
- internals.settings.setLazyImageLoadingEnabled(true);
var t = async_test("Verify that iframe's with scripting off disallow lazy image loading.");
function finish() {
assert_equals(is_image_fully_loaded(document.getElementById('sandboxedframe').contentWindow.document.getElementById('below_viewport')), true);
Modified: trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html (266445 => 266446)
--- trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,10 +1,8 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<script src=""
<script src=""
<script src=""
<script>
- if (window.internals)
- internals.settings.setLazyImageLoadingEnabled(true);
var t = async_test("Verify that iframe's with sandbox='allow-scripts' allow lazy image loading.");
function finish() {
assert_equals(is_image_fully_loaded(document.getElementById('sandboxedframe').contentWindow.document.getElementById('below_viewport')), false);
Modified: trunk/LayoutTests/http/tests/lazyload/lazy.html (266445 => 266446)
--- trunk/LayoutTests/http/tests/lazyload/lazy.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/http/tests/lazyload/lazy.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,13 +1,8 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<script src=""
<script src=""
<script src=""
-<script>
- if (window.internals)
- internals.settings.setLazyImageLoadingEnabled(true);
-</script>
-
<body>
<img id="in_viewport" src=''>
<div style="height:10000px;"></div>
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,3 +1,15 @@
+2020-09-01 Hector Lopez <[email protected]>
+
+ Unreviewed, reverting r266408.
+
+ Revision caused constant crashes on iOS and macOS
+
+ Reverted changeset:
+
+ "Convert runtime flag to setting for lazy image loading"
+ https://bugs.webkit.org/show_bug.cgi?id=215610
+ https://trac.webkit.org/changeset/266408
+
2020-09-01 Chris Dumez <[email protected]>
Make sure BiquadFilterNode tail is getting processed
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Below-viewport loading=lazy images do not block the window load event
when scrolled into viewport</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<script src=""
<script src=""
<body>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='eager' load immediately regardless of their
position with respect to the viewport</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-PASS When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time.
+FAIL When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time. assert_true: Below-viewport loading=lazy images do not block the window load event expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-PASS When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time.
+FAIL When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time. assert_true: Below-viewport loading=lazy images do not block the window load event expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Below viewport images with loading='lazy' and changed to
loading='eager' load and do not block the window load event</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Deferred images with loading='lazy' use the latest crossorigin attribute</title>
<link rel="author" title="Raj T" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,5 +1,5 @@
-PASS A below-viewport loading=lazy image in a cross origin iframe loads only
- when scrolled into viewport
+FAIL A below-viewport loading=lazy image in a cross origin iframe loads only
+ when scrolled into viewport assert_equals: The loading=lazy image should not block the iframe's load event expected "window_loaded" but got "image_loaded"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,5 +1,5 @@
-PASS A loading=lazy image in a below-viewport cross-origin iframe loads only
- when the cross-origin iframe is scrolled into view
+FAIL A loading=lazy image in a below-viewport cross-origin iframe loads only
+ when the cross-origin iframe is scrolled into view assert_equals: The loading=lazy image should not block the iframe's load event expected "window_loaded" but got "image_loaded"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='lazy' in script disabled iframe are not handled
as 'lazy'</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>In viewport images with loading='lazy' and changed to loading='eager'
do not block the window load event</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>In-viewport loading=lazy images do not block the window load event</title>
<link rel="author" title="Rob Buis" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Moving loading='lazy' image into another top level document</title>
<link rel="help" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>A loading='lazy' image starts loading when the element is moved into
an iframe where script is disabled</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='lazy' load when in the viewport</title>
<link rel="author" title="Chris Harrelson" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-FAIL Images with loading='lazy' can be lazy loaded multiple times assert_unreached: The loading=lazy below-viewport image should lazily load its second image, and not load it eagerly when the `src` attribute is changed Reached unreachable code
+FAIL Images with loading='lazy' can be lazy loaded multiple times assert_true: The loading=lazy below-viewport image should not block the window load event expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Deferred loading=lazy images are fetched with the latest
`referrerpolicy` attribute</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,7 +1,10 @@
-
+CONSOLE MESSAGE: Error: assert_false: below-viewport-1 image should never load expected false got true
+
-PASS Images are lazyloaded
-PASS Image referrerPolicy mutation does not cause deferred loading=lazy images to be fetched
-PASS Image crossOrigin mutation does not cause deferred loading=lazy images to be fetched
-PASS Image src mutation does not cause deferred loading=lazy images to be fetched
+Harness Error (FAIL), message = Error: assert_false: below-viewport-1 image should never load expected false got true
+TIMEOUT Images are lazyloaded Test timed out
+NOTRUN Image referrerPolicy mutation does not cause deferred loading=lazy images to be fetched
+NOTRUN Image crossOrigin mutation does not cause deferred loading=lazy images to be fetched
+NOTRUN Image src mutation does not cause deferred loading=lazy images to be fetched
+
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -4,8 +4,6 @@
<link rel="author" title="Chris Harrelson" href=""
<link rel="help" href=""
- <script src=""
- <script src=""
<script src=""
<img id=target loading="lazy"
width="330" height="254" style="border: 1px solid black">
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-PASS loading='lazy' image with srcset
+FAIL loading='lazy' image with srcset assert_equals: lazy-load images with srcset shouldn't be loaded yet expected 0 but got 2
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-PASS Below-viewport images with loading='lazy' load when set to loading='eager' or the `loading` attribute is removed
+FAIL Below-viewport images with loading='lazy' load when set to loading='eager' or the `loading` attribute is removed assert_unreached: #img_1 should not load before the window load event Reached unreachable code
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='lazy' load only when in the viewport</title>
<link rel="author" title="Scott Little" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Test that below-viewport invisible images that are not marked
loading=lazy still load, and block the window load event</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='lazy' load being moved to another document
and then scrolled to</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Below-viewport loading=lazy not-rendered images should never load,
even when scrolled into view</title>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>In-viewport loading=lazy not-rendered images should never load</title>
<link rel="author" title="Rob Buis" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='lazy' in picture elements load when near the viewport</title>
<link rel="author" title="Raj T" href=""
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html (266445 => 266446)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->
<head>
<title>Images with loading='lazy' load being removed and then scrolled to</title>
<script src=""
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (266445 => 266446)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -900,7 +900,7 @@
PASS HTMLImageElement interface: attribute currentSrc
PASS HTMLImageElement interface: attribute referrerPolicy
PASS HTMLImageElement interface: attribute decoding
-PASS HTMLImageElement interface: attribute loading
+FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false
PASS HTMLImageElement interface: operation decode()
PASS HTMLImageElement interface: attribute name
PASS HTMLImageElement interface: attribute lowsrc
@@ -926,7 +926,7 @@
PASS HTMLImageElement interface: document.createElement("img") must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "lowsrc" with the proper type
@@ -952,7 +952,7 @@
PASS HTMLImageElement interface: new Image() must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "lowsrc" with the proper type
Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (266445 => 266446)
--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -900,7 +900,7 @@
PASS HTMLImageElement interface: attribute currentSrc
PASS HTMLImageElement interface: attribute referrerPolicy
PASS HTMLImageElement interface: attribute decoding
-PASS HTMLImageElement interface: attribute loading
+FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false
PASS HTMLImageElement interface: operation decode()
PASS HTMLImageElement interface: attribute name
PASS HTMLImageElement interface: attribute lowsrc
@@ -926,7 +926,7 @@
PASS HTMLImageElement interface: document.createElement("img") must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "lowsrc" with the proper type
@@ -952,7 +952,7 @@
PASS HTMLImageElement interface: new Image() must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "lowsrc" with the proper type
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (266445 => 266446)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-09-02 01:56:22 UTC (rev 266446)
@@ -179,8 +179,6 @@
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html [ Skip ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html [ Skip ]
-imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html [ Skip ]
-imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager.html [ Skip ]
# testRunner.queueLoad() does not support loading data URLs in Mac WK1
http/tests/security/contentSecurityPolicy/navigate-self-to-data-url.html [ Skip ]
Modified: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (266445 => 266446)
--- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -900,7 +900,7 @@
PASS HTMLImageElement interface: attribute currentSrc
PASS HTMLImageElement interface: attribute referrerPolicy
PASS HTMLImageElement interface: attribute decoding
-PASS HTMLImageElement interface: attribute loading
+FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false
PASS HTMLImageElement interface: operation decode()
PASS HTMLImageElement interface: attribute name
PASS HTMLImageElement interface: attribute lowsrc
@@ -926,7 +926,7 @@
PASS HTMLImageElement interface: document.createElement("img") must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "lowsrc" with the proper type
@@ -952,7 +952,7 @@
PASS HTMLImageElement interface: new Image() must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "lowsrc" with the proper type
Modified: trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (266445 => 266446)
--- trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -900,7 +900,7 @@
PASS HTMLImageElement interface: attribute currentSrc
PASS HTMLImageElement interface: attribute referrerPolicy
PASS HTMLImageElement interface: attribute decoding
-PASS HTMLImageElement interface: attribute loading
+FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false
PASS HTMLImageElement interface: operation decode()
PASS HTMLImageElement interface: attribute name
PASS HTMLImageElement interface: attribute lowsrc
@@ -926,7 +926,7 @@
PASS HTMLImageElement interface: document.createElement("img") must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "lowsrc" with the proper type
@@ -952,7 +952,7 @@
PASS HTMLImageElement interface: new Image() must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "lowsrc" with the proper type
Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (266445 => 266446)
--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-02 01:56:22 UTC (rev 266446)
@@ -900,7 +900,7 @@
PASS HTMLImageElement interface: attribute currentSrc
PASS HTMLImageElement interface: attribute referrerPolicy
PASS HTMLImageElement interface: attribute decoding
-PASS HTMLImageElement interface: attribute loading
+FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false
PASS HTMLImageElement interface: operation decode()
PASS HTMLImageElement interface: attribute name
PASS HTMLImageElement interface: attribute lowsrc
@@ -926,7 +926,7 @@
PASS HTMLImageElement interface: document.createElement("img") must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type
PASS HTMLImageElement interface: document.createElement("img") must inherit property "lowsrc" with the proper type
@@ -952,7 +952,7 @@
PASS HTMLImageElement interface: new Image() must inherit property "currentSrc" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type
-PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type
+FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain
PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type
PASS HTMLImageElement interface: new Image() must inherit property "lowsrc" with the proper type
Modified: trunk/LayoutTests/resources/testharnessreport.js (266445 => 266446)
--- trunk/LayoutTests/resources/testharnessreport.js 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/LayoutTests/resources/testharnessreport.js 2020-09-02 01:56:22 UTC (rev 266446)
@@ -30,10 +30,8 @@
Object.defineProperty(self, "OfflineAudioContext", Object.getOwnPropertyDescriptor(self, "webkitOfflineAudioContext"));
if (window.webkitAudioPannerNode && !window.PannerNode)
Object.defineProperty(self, "PannerNode", Object.getOwnPropertyDescriptor(self, "webkitAudioPannerNode"));
- if (self.internals) {
+ if (self.internals)
internals.settings.setLazyIframeLoadingEnabled(location.pathname.indexOf('iframe-loading-lazy') !== -1);
- internals.settings.setLazyImageLoadingEnabled(true);
- }
}
if (testRunner.setStatisticsShouldDowngradeReferrer)
Modified: trunk/Source/WebCore/ChangeLog (266445 => 266446)
--- trunk/Source/WebCore/ChangeLog 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Source/WebCore/ChangeLog 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,3 +1,15 @@
+2020-09-01 Hector Lopez <[email protected]>
+
+ Unreviewed, reverting r266408.
+
+ Revision caused constant crashes on iOS and macOS
+
+ Reverted changeset:
+
+ "Convert runtime flag to setting for lazy image loading"
+ https://bugs.webkit.org/show_bug.cgi?id=215610
+ https://trac.webkit.org/changeset/266408
+
2020-09-01 Dean Jackson <[email protected]>
REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
Modified: trunk/Source/WebCore/loader/ImageLoader.cpp (266445 => 266446)
--- trunk/Source/WebCore/loader/ImageLoader.cpp 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Source/WebCore/loader/ImageLoader.cpp 2020-09-02 01:56:22 UTC (rev 266446)
@@ -43,7 +43,7 @@
#include "Page.h"
#include "RenderImage.h"
#include "RenderSVGImage.h"
-#include "Settings.h"
+#include "RuntimeEnabledFeatures.h"
#include <wtf/NeverDestroyed.h>
#if ENABLE(VIDEO)
Modified: trunk/Source/WebKit/ChangeLog (266445 => 266446)
--- trunk/Source/WebKit/ChangeLog 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Source/WebKit/ChangeLog 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,3 +1,15 @@
+2020-09-01 Hector Lopez <[email protected]>
+
+ Unreviewed, reverting r266408.
+
+ Revision caused constant crashes on iOS and macOS
+
+ Reverted changeset:
+
+ "Convert runtime flag to setting for lazy image loading"
+ https://bugs.webkit.org/show_bug.cgi?id=215610
+ https://trac.webkit.org/changeset/266408
+
2020-09-01 Kate Cheney <[email protected]>
Pass the correct data size for the SharedMemory::Handle in WebCompiledContentRuleListData::encode
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (266445 => 266446)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-09-02 01:56:22 UTC (rev 266446)
@@ -2230,6 +2230,16 @@
return toImpl(preferencesRef)->referrerPolicyAttributeEnabled();
}
+void WKPreferencesSetLazyImageLoadingEnabled(WKPreferencesRef preferencesRef, bool flag)
+{
+ toImpl(preferencesRef)->setLazyImageLoadingEnabled(flag);
+}
+
+bool WKPreferencesGetLazyImageLoadingEnabled(WKPreferencesRef preferencesRef)
+{
+ return toImpl(preferencesRef)->lazyImageLoadingEnabled();
+}
+
bool WKPreferencesGetRemotePlaybackEnabled(WKPreferencesRef preferencesRef)
{
return WebKit::toImpl(preferencesRef)->remotePlaybackEnabled();
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (266445 => 266446)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-09-02 01:56:22 UTC (rev 266446)
@@ -615,6 +615,10 @@
WK_EXPORT void WKPreferencesSetReferrerPolicyAttributeEnabled(WKPreferencesRef, bool flag);
WK_EXPORT bool WKPreferencesGetReferrerPolicyAttributeEnabled(WKPreferencesRef);
+// Defaults to false
+WK_EXPORT void WKPreferencesSetLazyImageLoadingEnabled(WKPreferencesRef, bool flag);
+WK_EXPORT bool WKPreferencesGetLazyImageLoadingEnabled(WKPreferencesRef);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Tools/ChangeLog (266445 => 266446)
--- trunk/Tools/ChangeLog 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Tools/ChangeLog 2020-09-02 01:56:22 UTC (rev 266446)
@@ -1,3 +1,15 @@
+2020-09-01 Hector Lopez <[email protected]>
+
+ Unreviewed, reverting r266408.
+
+ Revision caused constant crashes on iOS and macOS
+
+ Reverted changeset:
+
+ "Convert runtime flag to setting for lazy image loading"
+ https://bugs.webkit.org/show_bug.cgi?id=215610
+ https://trac.webkit.org/changeset/266408
+
2020-09-01 Rob Buis <[email protected]>
Convert runtime flag to setting for lazy image loading
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (266445 => 266446)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-09-02 01:56:22 UTC (rev 266446)
@@ -921,6 +921,7 @@
WKPreferencesSetColorFilterEnabled(preferences, options.enableColorFilter);
WKPreferencesSetPunchOutWhiteBackgroundsInDarkMode(preferences, options.punchOutWhiteBackgroundsInDarkMode);
WKPreferencesSetPageCacheEnabled(preferences, options.enableBackForwardCache);
+ WKPreferencesSetLazyImageLoadingEnabled(preferences, options.enableLazyImageLoading);
static WKStringRef defaultTextEncoding = WKStringCreateWithUTF8CString("ISO-8859-1");
WKPreferencesSetDefaultTextEncodingName(preferences, defaultTextEncoding);
@@ -1550,6 +1551,8 @@
testOptions.enableAppNap = parseBooleanTestHeaderValue(value);
else if (key == "enableBackForwardCache")
testOptions.enableBackForwardCache = parseBooleanTestHeaderValue(value);
+ else if (key == "enableLazyImageLoading")
+ testOptions.enableLazyImageLoading = parseBooleanTestHeaderValue(value);
else if (key == "allowsLinkPreview")
testOptions.allowsLinkPreview = parseBooleanTestHeaderValue(value);
else if (key == "enableCaptureVideoInUIProcess")
Modified: trunk/Tools/WebKitTestRunner/TestOptions.h (266445 => 266446)
--- trunk/Tools/WebKitTestRunner/TestOptions.h 2020-09-02 01:55:30 UTC (rev 266445)
+++ trunk/Tools/WebKitTestRunner/TestOptions.h 2020-09-02 01:56:22 UTC (rev 266446)
@@ -96,6 +96,7 @@
bool shouldPresentPopovers { true };
bool enableAppNap { false };
bool enableBackForwardCache { false };
+ bool enableLazyImageLoading { false };
bool allowsLinkPreview { true };
bool enableCaptureVideoInUIProcess { false };
bool enableCaptureVideoInGPUProcess { false };
@@ -164,6 +165,7 @@
|| applicationBundleIdentifier != options.applicationBundleIdentifier
|| enableAppNap != options.enableAppNap
|| enableBackForwardCache != options.enableBackForwardCache
+ || enableLazyImageLoading != options.enableLazyImageLoading
|| allowsLinkPreview != options.allowsLinkPreview
|| enableCaptureVideoInUIProcess != options.enableCaptureVideoInUIProcess
|| enableCaptureVideoInGPUProcess != options.enableCaptureVideoInGPUProcess
