Title: [266530] trunk/Source/_javascript_Core
- Revision
- 266530
- Author
- [email protected]
- Date
- 2020-09-03 10:20:45 -0700 (Thu, 03 Sep 2020)
Log Message
AbstractMacroAssembler::Jump class has uninitialized instance variables
<https://webkit.org/b/216082>
Reviewed by Michael Saboff.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump):
- Switch to default constructor syntax.
- Provide defaults for instance variables.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (266529 => 266530)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-03 17:04:09 UTC (rev 266529)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-03 17:20:45 UTC (rev 266530)
@@ -1,3 +1,15 @@
+2020-09-03 David Kilzer <[email protected]>
+
+ AbstractMacroAssembler::Jump class has uninitialized instance variables
+ <https://webkit.org/b/216082>
+
+ Reviewed by Michael Saboff.
+
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::Jump):
+ - Switch to default constructor syntax.
+ - Provide defaults for instance variables.
+
2020-09-03 Ross Kirsling <[email protected]>
[JSC] Add missing detached buffer errors for DataView
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (266529 => 266530)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2020-09-03 17:04:09 UTC (rev 266529)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2020-09-03 17:20:45 UTC (rev 266530)
@@ -579,10 +579,8 @@
friend struct DFG::OSRExit;
friend class LinkBuffer;
public:
- Jump()
- {
- }
-
+ Jump() = default;
+
#if CPU(ARM_THUMB2)
// Fixme: this information should be stored in the instruction stream, not in the Jump object.
Jump(AssemblerLabel jmp, ARMv7Assembler::JumpType type = ARMv7Assembler::JumpNoCondition, ARMv7Assembler::Condition condition = ARMv7Assembler::ConditionInvalid)
@@ -679,14 +677,14 @@
private:
AssemblerLabel m_label;
#if CPU(ARM_THUMB2)
- ARMv7Assembler::JumpType m_type;
- ARMv7Assembler::Condition m_condition;
+ ARMv7Assembler::JumpType m_type { ARMv7Assembler::JumpNoCondition };
+ ARMv7Assembler::Condition m_condition { ARMv7Assembler::ConditionInvalid };
#elif CPU(ARM64)
- ARM64Assembler::JumpType m_type;
- ARM64Assembler::Condition m_condition;
- bool m_is64Bit;
- unsigned m_bitNumber;
- ARM64Assembler::RegisterID m_compareRegister;
+ ARM64Assembler::JumpType m_type { ARM64Assembler::JumpNoCondition };
+ ARM64Assembler::Condition m_condition { ARM64Assembler::ConditionInvalid };
+ bool m_is64Bit { false };
+ unsigned m_bitNumber { 0 };
+ ARM64Assembler::RegisterID m_compareRegister { ARM64Registers::InvalidGPRReg };
#endif
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
