Title: [266532] trunk/Source/_javascript_Core
- Revision
- 266532
- Author
- [email protected]
- Date
- 2020-09-03 10:39:07 -0700 (Thu, 03 Sep 2020)
Log Message
Finish comment describing the various *Stack SSA nodes in DFG
https://bugs.webkit.org/show_bug.cgi?id=216110
Reviewed by Sam Weinig.
* dfg/DFGNodeType.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (266531 => 266532)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-03 17:22:27 UTC (rev 266531)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-03 17:39:07 UTC (rev 266532)
@@ -1,3 +1,12 @@
+2020-09-03 Keith Miller <[email protected]>
+
+ Finish comment describing the various *Stack SSA nodes in DFG
+ https://bugs.webkit.org/show_bug.cgi?id=216110
+
+ Reviewed by Sam Weinig.
+
+ * dfg/DFGNodeType.h:
+
2020-09-03 David Kilzer <[email protected]>
AbstractMacroAssembler::Jump class has uninitialized instance variables
Modified: trunk/Source/_javascript_Core/dfg/DFGNodeType.h (266531 => 266532)
--- trunk/Source/_javascript_Core/dfg/DFGNodeType.h 2020-09-03 17:22:27 UTC (rev 266531)
+++ trunk/Source/_javascript_Core/dfg/DFGNodeType.h 2020-09-03 17:39:07 UTC (rev 266532)
@@ -74,7 +74,9 @@
macro(GetLocal, NodeResultJS | NodeMustGenerate) \
macro(SetLocal, 0) \
\
- /* These are used in SSA form to represent to track */\
+ /* These are used in SSA form to represent OSR availability on the stack. As long as a local is */\
+ /* available on the stack from all paths into a merge point we don't need to have a Phi. Since OSR */\
+ /* exits are rare this is preferable to representing availability directly in SSA. */\
macro(PutStack, NodeMustGenerate) \
macro(KillStack, NodeMustGenerate) \
macro(GetStack, NodeResultJS) \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
