Title: [266661] trunk/Source/WebCore
Revision
266661
Author
[email protected]
Date
2020-09-05 08:57:35 -0700 (Sat, 05 Sep 2020)

Log Message

-Wreturn-type warning in BaseAudioContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=216215

Patch by Michael Catanzaro <[email protected]> on 2020-09-05
Reviewed by Darin Adler.

* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::periodicWave):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (266660 => 266661)


--- trunk/Source/WebCore/ChangeLog	2020-09-05 15:45:27 UTC (rev 266660)
+++ trunk/Source/WebCore/ChangeLog	2020-09-05 15:57:35 UTC (rev 266661)
@@ -1,3 +1,13 @@
+2020-09-05  Michael Catanzaro  <[email protected]>
+
+        -Wreturn-type warning in BaseAudioContext.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=216215
+
+        Reviewed by Darin Adler.
+
+        * Modules/webaudio/BaseAudioContext.cpp:
+        (WebCore::BaseAudioContext::periodicWave):
+
 2020-09-05  Darin Adler  <[email protected]>
 
         CSS revert should serialize as "revert", not "Revert"

Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp (266660 => 266661)


--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp	2020-09-05 15:45:27 UTC (rev 266660)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.cpp	2020-09-05 15:57:35 UTC (rev 266661)
@@ -1316,15 +1316,13 @@
             m_cachedPeriodicWaveTriangle = PeriodicWave::createTriangle(sampleRate());
         return *m_cachedPeriodicWaveTriangle;
     case OscillatorType::Custom:
-        ASSERT_NOT_REACHED();
-#ifdef NDEBUG
-        FALLTHROUGH;
-#endif
+        RELEASE_ASSERT_NOT_REACHED();
     case OscillatorType::Sine:
         if (!m_cachedPeriodicWaveSine)
             m_cachedPeriodicWaveSine = PeriodicWave::createSine(sampleRate());
         return *m_cachedPeriodicWaveSine;
     }
+    RELEASE_ASSERT_NOT_REACHED();
 }
 
 #if !RELEASE_LOG_DISABLED
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to