[webkit-changes] [266684] trunk

Sun, 06 Sep 2020 16:11:19 -0700

Title: [266684] trunk
Revision
266684
Author
[email protected]
Date
2020-09-06 16:09:39 -0700 (Sun, 06 Sep 2020)

Log Message

ConvolverNode incorrectly outputs silence because m_reverb is null
https://bugs.webkit.org/show_bug.cgi?id=216230

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Unreviewed, rebaseline tests that are now passing.

* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

ConvolverNode relies on m_reverb to to audio processing. m_reverb would get initialized
when calling ConvolverNode::setBuffer(). However, setting the buffer would cause
ConvolverNode::checkNumberOfChannelsForInput(), which could cause unitialize() and then
initialize() to get called. The issue was that unitialize() would null out m_reverb
and nothing would re-initialize it.

No new tests, rebaselined existing tests.

* Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::initialize): Deleted.
(WebCore::ConvolverNode::uninitialize): Deleted.
* Modules/webaudio/ConvolverNode.h:

LayoutTests:

Unreviewed, unskip tests that should hopefully not be flaky anymore, not that they
are passing.

* TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (266683 => 266684)


--- trunk/LayoutTests/ChangeLog	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/ChangeLog	2020-09-06 23:09:39 UTC (rev 266684)
@@ -1,3 +1,15 @@
+2020-09-06  Chris Dumez  <[email protected]>
+
+        ConvolverNode incorrectly outputs silence because m_reverb is null
+        https://bugs.webkit.org/show_bug.cgi?id=216230
+
+        Reviewed by Darin Adler.
+
+        Unreviewed, unskip tests that should hopefully not be flaky anymore, not that they
+        are passing.
+
+        * TestExpectations:
+
 2020-09-06  Myles C. Maxfield  <[email protected]>
 
         Letter-spacing should disable ligatures

Modified: trunk/LayoutTests/TestExpectations (266683 => 266684)


--- trunk/LayoutTests/TestExpectations	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/TestExpectations	2020-09-06 23:09:39 UTC (rev 266684)
@@ -324,9 +324,6 @@
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering.html [ Pass Failure ]
-imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html [ Pass Failure ]
-imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html [ Pass Failure ]
-imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay.html [ Pass Failure ]
@@ -336,10 +333,11 @@
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter.html [ Pass Failure ]
 
 # These tests pass but print different values almost every time.
+imported/w3c/web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter.html [ Pass Failure ]
+imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan.html [ Pass Failure ]
+imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan.html [ Pass Failure ]
-imported/w3c/web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter.html [ Pass Failure ]
 
-
 # Some of the subchecks are failing and print out a different value every time.
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting.html [ Pass Failure ]
 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html [ Pass Failure ]

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (266683 => 266684)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-09-06 23:09:39 UTC (rev 266684)
@@ -1,3 +1,18 @@
+2020-09-06  Chris Dumez  <[email protected]>
+
+        ConvolverNode incorrectly outputs silence because m_reverb is null
+        https://bugs.webkit.org/show_bug.cgi?id=216230
+
+        Reviewed by Darin Adler.
+
+        Unreviewed, rebaseline tests that are now passing.
+
+        * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
+        * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
+        * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
+        * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
+        * web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
+
 2020-09-06  Myles C. Maxfield  <[email protected]>
 
         Letter-spacing should disable ligatures

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt (266683 => 266684)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt	2020-09-06 23:09:39 UTC (rev 266684)
@@ -17,155 +17,45 @@
 PASS < [initialize] All assertions passed. (total 1 assertions) 
 PASS > [1-channel input] produces 1-channel output 
 PASS   1: Channel 1 contains only the constant 0. 
-PASS   Convolver output equals [0,0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247789382935...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   Convolver output equals [0,0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247193336487...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS < [1-channel input] All assertions passed. (total 2 assertions) 
 PASS > [2-channel input] produces 2-channel output 
-FAIL X 2: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 235.
-	[235]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 2: Channel 1 does not equal [0,0,0.9947001934051514,0.770577609539032,0.9109301567077637,0.7706682085990906,0.9842367172241211,0.3202291429042816,-0.9348859190940857,-0.8055058121681213,-0.8837443590164185,-0.8007677793502808,-0.9286618232727051,-0.6026888489723206,0.7909701466560364,0.8679973483085632...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.9470019340515137e-1	9.9470019340515137e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	7.7057760953903198e-1	7.7057760953903198e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	9.1093015670776367e-1	9.1093015670776367e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	7.7066820859909058e-1	7.7066820859909058e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	9.8423671722412109e-1	9.8423671722412109e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1272 more errors.
-	Max AbsError of 9.9796342849731445e-1 at index of 273.
-	[273]	0.0000000000000000e+0	-9.9796342849731445e-1	9.9796342849731445e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL < [2-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   2: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   2: Channel 1 equals [0,0,0.9947002530097961,0.7705776691436768,0.9109301567077637,0.7706682085990906,0.9842367768287659,0.3202291429042816,-0.9348859786987305,-0.8055058717727661,-0.8837442994117737,-0.8007678389549255,-0.9286617636680603,-0.6026888489723206,0.7909700870513916,0.8679973483085632...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [2-channel input] All assertions passed. (total 2 assertions) 
 PASS > [3-channel input] 3->2 downmix producing 2-channel output 
-FAIL X 3: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 235.
-	[235]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 3: Channel 1 does not equal [0,0,0.9947001934051514,0.770577609539032,0.9109301567077637,0.7706682085990906,0.9842367172241211,0.3202291429042816,-0.9348859190940857,-0.8055058121681213,-0.8837443590164185,-0.8007677793502808,-0.9286618232727051,-0.6026888489723206,0.7909701466560364,0.8679973483085632...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.9470019340515137e-1	9.9470019340515137e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	7.7057760953903198e-1	7.7057760953903198e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	9.1093015670776367e-1	9.1093015670776367e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	7.7066820859909058e-1	7.7066820859909058e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	9.8423671722412109e-1	9.8423671722412109e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1272 more errors.
-	Max AbsError of 9.9796342849731445e-1 at index of 273.
-	[273]	0.0000000000000000e+0	-9.9796342849731445e-1	9.9796342849731445e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL < [3-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   3: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   3: Channel 1 equals [0,0,0.9947002530097961,0.7705776691436768,0.9109301567077637,0.7706682085990906,0.9842367768287659,0.3202291429042816,-0.9348859786987305,-0.8055058717727661,-0.8837442994117737,-0.8007678389549255,-0.9286617636680603,-0.6026888489723206,0.7909700870513916,0.8679973483085632...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [3-channel input] All assertions passed. (total 2 assertions) 
 PASS > [4-channel input] 4->2 downmix producing 2-channel output 
-FAIL X 4: Channel 0 does not equal [0,0,0.9734256267547607,0.8085750341415405,0.8596615791320801,0.8377397060394287,0.18206259608268738,-0.06961163878440857,0.037733376026153564,-0.007562130689620972,-0.018085792660713196,0.029709041118621826,-0.02168998122215271,-0.005516946315765381,0.05647379159927368,-0.4439384341239929...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.7342562675476074e-1	9.7342562675476074e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.0857503414154053e-1	8.0857503414154053e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.5966157913208008e-1	8.5966157913208008e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.3773970603942871e-1	8.3773970603942871e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	1.8206259608268738e-1	1.8206259608268738e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 1.0024597644805908e+0 at index of 428.
-	[428]	0.0000000000000000e+0	-1.0024597644805908e+0	1.0024597644805908e+0	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 4: Channel 1 does not equal [0,0,0.971980094909668,0.8049001097679138,0.8850501775741577,0.18059252202510834,0.027723312377929688,-0.2852807641029358,-0.7788606882095337,-0.03758403658866882,-0.008258670568466187,0.07240843772888184,-0.33466455340385437,-0.7563190460205078,-0.020491331815719604,-0.031466513872146606...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.7198009490966797e-1	9.7198009490966797e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.0490010976791382e-1	8.0490010976791382e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.8505017757415771e-1	8.8505017757415771e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	1.8059252202510834e-1	1.8059252202510834e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	2.7723312377929688e-2	2.7723312377929688e-2	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1272 more errors.
-	Max AbsError of 9.7500616312026978e-1 at index of 484.
-	[484]	0.0000000000000000e+0	-9.7500616312026978e-1	9.7500616312026978e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL < [4-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   4: Channel 0 equals [0,0,0.9734256267547607,0.8085750341415405,0.8596616387367249,0.8377397060394287,0.18206259608268738,-0.06961160898208618,0.037733376026153564,-0.007562130689620972,-0.01808580756187439,0.029709041118621826,-0.02168998122215271,-0.005516916513442993,0.05647379159927368,-0.4439384341239929...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   4: Channel 1 equals [0,0,0.971980094909668,0.8049001693725586,0.8850501775741577,0.18059252202510834,0.027723312377929688,-0.2852807641029358,-0.7788607478141785,-0.03758406639099121,-0.008258640766143799,0.07240837812423706,-0.334664523601532,-0.7563190460205078,-0.020491361618041992,-0.031466543674468994...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [4-channel input] All assertions passed. (total 2 assertions) 
 PASS > [5.1-channel input] 5.1->2 downmix producing 2-channel output 
-FAIL X 5.1: Channel 0 does not equal [0,0,2.302107334136963,2.0779101848602295,1.536412000656128,0.8359496593475342,-0.2123139351606369,-0.0052925655618309975,0.8362105488777161,1.0198440551757812,0.32619065046310425,-0.6783384680747986,-1.0576409101486206,-0.5491995811462402,0.2516634166240692,-0.10923532396554947...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	2.3021073341369629e+0	2.3021073341369629e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	[3]	0.0000000000000000e+0	2.0779101848602295e+0	2.0779101848602295e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	[4]	0.0000000000000000e+0	1.5364120006561279e+0	1.5364120006561279e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	[5]	0.0000000000000000e+0	8.3594965934753418e-1	8.3594965934753418e-1	1.0000000000000000e+0	1.1511867343774294e-6
-	[6]	0.0000000000000000e+0	-2.1231393516063690e-1	2.1231393516063690e-1	1.0000000000000000e+0	1.1511867343774294e-6
-	...and 1271 more errors.
-	Max AbsError of 2.4404382705688477e+0 at index of 896.
-	[896]	0.0000000000000000e+0	2.4404382705688477e+0	2.4404382705688477e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 5.1: Channel 1 does not equal [0,0,2.407027244567871,1.851643443107605,1.2457610368728638,0.5805020928382874,0.3625302314758301,0.1648862212896347,-0.7450207471847534,-1.5345407724380493,-1.904326319694519,-0.7297847867012024,0.01058983150869608,0.7125816941261292,1.75357985496521,0.26786839962005615...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	2.4070272445678711e+0	2.4070272445678711e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	[3]	0.0000000000000000e+0	1.8516434431076050e+0	1.8516434431076050e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	[4]	0.0000000000000000e+0	1.2457610368728638e+0	1.2457610368728638e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	[5]	0.0000000000000000e+0	5.8050209283828735e-1	5.8050209283828735e-1	1.0000000000000000e+0	1.1511867343774294e-6
-	[6]	0.0000000000000000e+0	3.6253023147583008e-1	3.6253023147583008e-1	1.0000000000000000e+0	1.1511867343774294e-6
-	...and 1272 more errors.
-	Max AbsError of 2.4601652622222900e+0 at index of 186.
-	[186]	0.0000000000000000e+0	-2.4601652622222900e+0	2.4601652622222900e+0	1.0000000000000000e+0	1.1511867343774294e-6
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL < [5.1-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   5.1: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,1.536412000656128,0.8359496593475342,-0.2123139351606369,-0.005292520858347416,0.8362105488777161,1.0198440551757812,0.32619062066078186,-0.6783384680747986,-1.0576409101486206,-0.5491995215415955,0.2516634166240692,-0.10923532396554947...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
+PASS   5.1: Channel 1 equals [0,0,2.407027244567871,1.8516435623168945,1.2457610368728638,0.5805020928382874,0.36253032088279724,0.16488628089427948,-0.7450209259986877,-1.5345407724380493,-1.9043262004852295,-0.7297848463058472,0.010589891113340855,0.7125816941261292,1.7535797357559204,0.26786839962005615...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
+PASS < [5.1-channel input] All assertions passed. (total 2 assertions) 
 PASS > [3-channel input, explicit] 3->2 explicit downmix producing 2-channel output 
-FAIL X 3 chan downmix explicit: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 235.
-	[235]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 3 chan downmix explicit: Channel 1 does not equal [0,0,0.9947001934051514,0.770577609539032,0.9109301567077637,0.7706682085990906,0.9842367172241211,0.3202291429042816,-0.9348859190940857,-0.8055058121681213,-0.8837443590164185,-0.8007677793502808,-0.9286618232727051,-0.6026888489723206,0.7909701466560364,0.8679973483085632...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.9470019340515137e-1	9.9470019340515137e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	7.7057760953903198e-1	7.7057760953903198e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	9.1093015670776367e-1	9.1093015670776367e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	7.7066820859909058e-1	7.7066820859909058e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	9.8423671722412109e-1	9.8423671722412109e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1272 more errors.
-	Max AbsError of 9.9796342849731445e-1 at index of 273.
-	[273]	0.0000000000000000e+0	-9.9796342849731445e-1	9.9796342849731445e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL < [3-channel input, explicit] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   3 chan downmix explicit: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   3 chan downmix explicit: Channel 1 equals [0,0,0.9947002530097961,0.7705776691436768,0.9109301567077637,0.7706682085990906,0.9842367768287659,0.3202291429042816,-0.9348859786987305,-0.8055058717727661,-0.8837442994117737,-0.8007678389549255,-0.9286617636680603,-0.6026888489723206,0.7909700870513916,0.8679973483085632...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [3-channel input, explicit] All assertions passed. (total 2 assertions) 
 PASS > [4-channel input, explicit] 4->2 explicit downmix producing 2-channel output 
-PASS   4 chan downmix explicit: Channel 0 equals [0,0,0.9734256267547607,0.8085750341415405,0.8596615791320801,0.8377397060394287,0.18206259608268738,-0.06961163878440857,0.037733376026153564,-0.007562130689620972,-0.018085792660713196,0.029709041118621826,-0.02168998122215271,-0.005516946315765381,0.05647379159927368,-0.4439384341239929...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
-PASS   4 chan downmix explicit: Channel 1 equals [0,0,0.971980094909668,0.8049001097679138,0.8850501775741577,0.18059252202510834,0.027723312377929688,-0.2852807641029358,-0.7788606882095337,-0.03758403658866882,-0.008258670568466187,0.07240843772888184,-0.33466455340385437,-0.7563190460205078,-0.020491331815719604,-0.031466513872146606...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   4 chan downmix explicit: Channel 0 equals [0,0,0.9734256267547607,0.8085750341415405,0.8596616387367249,0.8377397060394287,0.18206259608268738,-0.06961160898208618,0.037733376026153564,-0.007562130689620972,-0.01808580756187439,0.029709041118621826,-0.02168998122215271,-0.005516916513442993,0.05647379159927368,-0.4439384341239929...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   4 chan downmix explicit: Channel 1 equals [0,0,0.971980094909668,0.8049001693725586,0.8850501775741577,0.18059252202510834,0.027723312377929688,-0.2852807641029358,-0.7788607478141785,-0.03758406639099121,-0.008258640766143799,0.07240837812423706,-0.334664523601532,-0.7563190460205078,-0.020491361618041992,-0.031466543674468994...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS < [4-channel input, explicit] All assertions passed. (total 2 assertions) 
 PASS > [5.1-channel input, explicit] 5.1->2 explicit downmix producing 2-channel output 
-PASS   5.1 chan downmix explicit: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,1.536412000656128,0.8359496593475342,-0.2123139351606369,-0.0052925655618309975,0.8362105488777161,1.0198440551757812,0.32619065046310425,-0.6783384680747986,-1.0576409101486206,-0.5491995811462402,0.2516634166240692,-0.10923532396554947...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
-PASS   5.1 chan downmix explicit: Channel 1 equals [0,0,2.407027244567871,1.851643443107605,1.2457610368728638,0.5805020928382874,0.3625302314758301,0.1648862212896347,-0.7450207471847534,-1.5345407724380493,-1.904326319694519,-0.7297847867012024,0.01058983150869608,0.7125816941261292,1.75357985496521,0.26786839962005615...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
+PASS   5.1 chan downmix explicit: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,1.536412000656128,0.8359496593475342,-0.2123139351606369,-0.005292520858347416,0.8362105488777161,1.0198440551757812,0.32619062066078186,-0.6783384680747986,-1.0576409101486206,-0.5491995215415955,0.2516634166240692,-0.10923532396554947...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
+PASS   5.1 chan downmix explicit: Channel 1 equals [0,0,2.407027244567871,1.8516435623168945,1.2457610368728638,0.5805020928382874,0.36253032088279724,0.16488628089427948,-0.7450209259986877,-1.5345407724380493,-1.9043262004852295,-0.7297848463058472,0.010589891113340855,0.7125816941261292,1.7535797357559204,0.26786839962005615...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
 PASS < [5.1-channel input, explicit] All assertions passed. (total 2 assertions) 
 PASS > [mono-upmix-explicit] 1->2 upmix, count mode explicit 
 PASS   new ConvolverNode({channelCountMode: 'explicit'}) did not throw an exception. 
-PASS   1->2 explicit upmix: channel 0 equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247789382935,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
-PASS   1->2 explicit upmix: channel 1 equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247789382935,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   1->2 explicit upmix: channel 0 equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247193336487,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   1->2 explicit upmix: channel 1 equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247193336487,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS < [mono-upmix-explicit] All assertions passed. (total 3 assertions) 
 PASS > [mono-upmix-clamped-max] 1->2 upmix, count mode clamped-max 
 PASS   new ConvolverNode({channelCountMode: 'clamped-max'}) did not throw an exception. 
-PASS   1->2 clamped-max upmix: channel 0 equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247789382935,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   1->2 clamped-max upmix: channel 0 equals [0,0.3311063051223755,0.6248595118522644,0.8481203317642212,0.9757022261619568,0.9932120442390442,0.898674488067627,0.7027547955513,0.4275550842285156,0.10412158071994781,-0.23105812072753906,-0.5401715040206909,-0.7883464097976685,-0.9475855827331543,-0.9999247193336487,-0.9394593238830566...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS   1->2 clamped-max upmix: channel 1 contains only the constant 0. 
 PASS < [mono-upmix-clamped-max] All assertions passed. (total 3 assertions) 
-FAIL # AUDIT TASK RUNNER FINISHED: 5 out of 11 tasks were failed. assert_true: expected true got false
+PASS # AUDIT TASK RUNNER FINISHED: 11 tasks ran successfully.

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt (266683 => 266684)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt	2020-09-06 23:09:39 UTC (rev 266684)
@@ -15,150 +15,40 @@
 PASS   new AudioBuffer({numberOfChannels: 2, length: 4, sampleRate: 8192}) did not throw an exception. 
 PASS < [initialize] All assertions passed. (total 1 assertions) 
 PASS > [1-channel input] produces 2-channel output 
-PASS   1: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
-PASS   1: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   1: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   1: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS < [1-channel input] All assertions passed. (total 2 assertions) 
 PASS > [2-channel input] produces 2-channel output 
-PASS   2: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
-PASS   2: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   2: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   2: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS < [2-channel input] All assertions passed. (total 2 assertions) 
 PASS > [3-channel input] 3->2 downmix producing 2-channel output 
-FAIL X 3: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 235.
-	[235]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 3: Channel 1 does not equal [0,0,0,0.9947001934051514,0.770577609539032,0.9109301567077637,0.7706682085990906,0.9842367172241211,0.3202291429042816,-0.9348859190940857,-0.8055058121681213,-0.8837443590164185,-0.8007677793502808,-0.9286618232727051,-0.6026888489723206,0.7909701466560364...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[3]	0.0000000000000000e+0	9.9470019340515137e-1	9.9470019340515137e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	7.7057760953903198e-1	7.7057760953903198e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	9.1093015670776367e-1	9.1093015670776367e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	7.7066820859909058e-1	7.7066820859909058e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[7]	0.0000000000000000e+0	9.8423671722412109e-1	9.8423671722412109e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9796342849731445e-1 at index of 274.
-	[274]	0.0000000000000000e+0	-9.9796342849731445e-1	9.9796342849731445e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 3.
- assert_true: expected true got false
-FAIL < [3-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   3: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   3: Channel 1 equals [0,0,0,0.9947002530097961,0.7705776691436768,0.9109301567077637,0.7706682085990906,0.9842367768287659,0.3202291429042816,-0.9348859786987305,-0.8055058717727661,-0.8837442994117737,-0.8007678389549255,-0.9286617636680603,-0.6026888489723206,0.7909700870513916...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [3-channel input] All assertions passed. (total 2 assertions) 
 PASS > [4-channel input] 4->2 downmix producing 2-channel output 
-FAIL X 4: Channel 0 does not equal [0,0,0.9734256267547607,0.8085750341415405,0.8596615791320801,0.8377397060394287,0.18206259608268738,-0.06961163878440857,0.037733376026153564,-0.007562130689620972,-0.018085792660713196,0.029709041118621826,-0.02168998122215271,-0.005516946315765381,0.05647379159927368,-0.4439384341239929...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.7342562675476074e-1	9.7342562675476074e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.0857503414154053e-1	8.0857503414154053e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.5966157913208008e-1	8.5966157913208008e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.3773970603942871e-1	8.3773970603942871e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	1.8206259608268738e-1	1.8206259608268738e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 1.0024597644805908e+0 at index of 428.
-	[428]	0.0000000000000000e+0	-1.0024597644805908e+0	1.0024597644805908e+0	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 4: Channel 1 does not equal [0,0,0,0.971980094909668,0.8049001097679138,0.8850501775741577,0.18059252202510834,0.027723312377929688,-0.2852807641029358,-0.7788606882095337,-0.03758403658866882,-0.008258670568466187,0.07240843772888184,-0.33466455340385437,-0.7563190460205078,-0.020491331815719604...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[3]	0.0000000000000000e+0	9.7198009490966797e-1	9.7198009490966797e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.0490010976791382e-1	8.0490010976791382e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.8505017757415771e-1	8.8505017757415771e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	1.8059252202510834e-1	1.8059252202510834e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[7]	0.0000000000000000e+0	2.7723312377929688e-2	2.7723312377929688e-2	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.7500616312026978e-1 at index of 485.
-	[485]	0.0000000000000000e+0	-9.7500616312026978e-1	9.7500616312026978e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 3.
- assert_true: expected true got false
-FAIL < [4-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   4: Channel 0 equals [0,0,0.9734256267547607,0.8085750341415405,0.8596616387367249,0.8377397060394287,0.18206259608268738,-0.06961160898208618,0.037733376026153564,-0.007562130689620972,-0.01808580756187439,0.029709041118621826,-0.02168998122215271,-0.005516916513442993,0.05647379159927368,-0.4439384341239929...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   4: Channel 1 equals [0,0,0,0.971980094909668,0.8049001693725586,0.8850501775741577,0.18059252202510834,0.027723312377929688,-0.2852807641029358,-0.7788607478141785,-0.03758406639099121,-0.008258640766143799,0.07240837812423706,-0.334664523601532,-0.7563190460205078,-0.020491361618041992...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [4-channel input] All assertions passed. (total 2 assertions) 
 PASS > [5.1-channel input] 5.1->2 downmix producing 2-channel output 
-PASS   5.1: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,1.536412000656128,0.8359496593475342,-0.2123139351606369,-0.0052925655618309975,0.8362105488777161,1.0198440551757812,0.32619065046310425,-0.6783384680747986,-1.0576409101486206,-0.5491995811462402,0.2516634166240692,-0.10923532396554947...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
-PASS   5.1: Channel 1 equals [0,0,0,2.407027244567871,1.851643443107605,1.2457610368728638,0.5805020928382874,0.3625302314758301,0.1648862212896347,-0.7450207471847534,-1.5345407724380493,-1.904326319694519,-0.7297847867012024,0.01058983150869608,0.7125816941261292,1.75357985496521...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
+PASS   5.1: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,1.536412000656128,0.8359496593475342,-0.2123139351606369,-0.005292520858347416,0.8362105488777161,1.0198440551757812,0.32619062066078186,-0.6783384680747986,-1.0576409101486206,-0.5491995215415955,0.2516634166240692,-0.10923532396554947...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
+PASS   5.1: Channel 1 equals [0,0,0,2.407027244567871,1.8516435623168945,1.2457610368728638,0.5805020928382874,0.36253032088279724,0.16488628089427948,-0.7450209259986877,-1.5345407724380493,-1.9043262004852295,-0.7297848463058472,0.010589891113340855,0.7125816941261292,1.7535797357559204...] with an element-wise tolerance of {"absoluteThreshold":0.0000011511867343774294,"relativeThreshold":0}. 
 PASS < [5.1-channel input] All assertions passed. (total 2 assertions) 
 PASS > [2-channel input, explicit mode] produces 2-channel output 
-FAIL X 2-in explicit mode: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 235.
-	[235]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 2-in explicit mode: Channel 1 does not equal [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[3]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[7]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1270 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 236.
-	[236]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 3.
- assert_true: expected true got false
-FAIL < [2-channel input, explicit mode] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   2-in explicit mode: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   2-in explicit mode: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [2-channel input, explicit mode] All assertions passed. (total 2 assertions) 
 PASS > [3-channel input explicit mode] 3->1 downmix producing 2-channel output 
-FAIL X 3-in explicit: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1271 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 235.
-	[235]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 3-in explicit: Channel 1 does not equal [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837583899497986,-0.7808233499526978,-0.9249736070632935,-0.7918891906738281,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[3]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[4]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[5]	0.0000000000000000e+0	8.2335621118545532e-1	8.2335621118545532e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[6]	0.0000000000000000e+0	8.6454612016677856e-1	8.6454612016677856e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	[7]	0.0000000000000000e+0	8.4542512893676758e-1	8.4542512893676758e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	...and 1270 more errors.
-	Max AbsError of 9.9012923240661621e-1 at index of 236.
-	[236]	0.0000000000000000e+0	-9.9012923240661621e-1	9.9012923240661621e-1	1.0000000000000000e+0	4.7683715820312500e-7
-	Max RelError of 1.0000000000000000e+0 at index of 3.
- assert_true: expected true got false
-FAIL < [3-channel input explicit mode] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   3-in explicit: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248,-0.8348914980888367...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   3-in explicit: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,0.8233562111854553,0.8645461201667786,0.8454251289367676,0.858031690120697,0.7955960035324097,0.9893835186958313,0.39837580919265747,-0.7808233499526978,-0.9249736070632935,-0.7918891310691833,-0.875220775604248...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS < [3-channel input explicit mode] All assertions passed. (total 2 assertions) 
 PASS > [4-channel input explicit mode] 4->1 downmix producing 2-channel output 
-PASS   4-in explicit: Channel 0 equals [0,0,0.9727029204368591,0.8067376017570496,0.8723558783531189,0.5091661214828491,0.10489296913146973,-0.17744621634483337,-0.37056368589401245,-0.022573083639144897,-0.013172224164009094,0.05105873942375183,-0.17817726731300354,-0.3809179663658142,0.01799122989177704,-0.23770247399806976...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
-PASS   4-in explicit: Channel 1 equals [0,0,0,0.9727029204368591,0.8067376017570496,0.8723558783531189,0.5091661214828491,0.10489296913146973,-0.17744621634483337,-0.37056368589401245,-0.022573083639144897,-0.013172224164009094,0.05105873942375183,-0.17817726731300354,-0.3809179663658142,0.01799122989177704...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   4-in explicit: Channel 0 equals [0,0,0.9727029204368591,0.8067376017570496,0.8723558783531189,0.5091661214828491,0.10489295423030853,-0.17744620144367218,-0.37056368589401245,-0.02257309854030609,-0.013172224164009094,0.05105872452259064,-0.17817723751068115,-0.3809179663658142,0.017991214990615845,-0.23770248889923096...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
+PASS   4-in explicit: Channel 1 equals [0,0,0,0.9727029204368591,0.8067376017570496,0.8723558783531189,0.5091661214828491,0.10489295423030853,-0.17744620144367218,-0.37056368589401245,-0.02257309854030609,-0.013172224164009094,0.05105872452259064,-0.17817723751068115,-0.3809179663658142,0.017991214990615845...] with an element-wise tolerance of {"absoluteThreshold":4.76837158203125e-7,"relativeThreshold":0}. 
 PASS < [4-channel input explicit mode] All assertions passed. (total 2 assertions) 
 PASS > [5.1-channel input explicit mode] 5.1->1 downmix producing 2-channel output 
-FAIL X 5.1-in explicit: Channel 0 does not equal [0,0,3.3298611640930176,2.778614044189453,1.967293381690979,1.0015825033187866,0.10621887445449829,0.11284977197647095,0.06448096036911011,-0.36394545435905457,-1.115910291671753,-0.9956934452056885,-0.740376889705658,0.1155286431312561,1.4179210662841797,0.11217048764228821...] with an element-wise tolerance of {"absoluteThreshold":0.0000016280238925805544,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	3.3298611640930176e+0	3.3298611640930176e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[3]	0.0000000000000000e+0	2.7786140441894531e+0	2.7786140441894531e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[4]	0.0000000000000000e+0	1.9672933816909790e+0	1.9672933816909790e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[5]	0.0000000000000000e+0	1.0015825033187866e+0	1.0015825033187866e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[6]	0.0000000000000000e+0	1.0621887445449829e-1	1.0621887445449829e-1	1.0000000000000000e+0	1.6280238925805544e-6
-	...and 1272 more errors.
-	Max AbsError of 3.4554493427276611e+0 at index of 37.
-	[37]	0.0000000000000000e+0	-3.4554493427276611e+0	3.4554493427276611e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 5.1-in explicit: Channel 1 does not equal [0,0,0,3.3298611640930176,2.778614044189453,1.967293381690979,1.0015825033187866,0.10621887445449829,0.11284977197647095,0.06448096036911011,-0.36394545435905457,-1.115910291671753,-0.9956934452056885,-0.740376889705658,0.1155286431312561,1.4179210662841797...] with an element-wise tolerance of {"absoluteThreshold":0.0000016280238925805544,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[3]	0.0000000000000000e+0	3.3298611640930176e+0	3.3298611640930176e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[4]	0.0000000000000000e+0	2.7786140441894531e+0	2.7786140441894531e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[5]	0.0000000000000000e+0	1.9672933816909790e+0	1.9672933816909790e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[6]	0.0000000000000000e+0	1.0015825033187866e+0	1.0015825033187866e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	[7]	0.0000000000000000e+0	1.0621887445449829e-1	1.0621887445449829e-1	1.0000000000000000e+0	1.6280238925805544e-6
-	...and 1271 more errors.
-	Max AbsError of 3.4554493427276611e+0 at index of 38.
-	[38]	0.0000000000000000e+0	-3.4554493427276611e+0	3.4554493427276611e+0	1.0000000000000000e+0	1.6280238925805544e-6
-	Max RelError of 1.0000000000000000e+0 at index of 3.
- assert_true: expected true got false
-FAIL < [5.1-channel input explicit mode] 2 out of 2 assertions were failed. assert_true: expected true got false
-FAIL # AUDIT TASK RUNNER FINISHED: 5 out of 10 tasks were failed. assert_true: expected true got false
+PASS   5.1-in explicit: Channel 0 equals [0,0,3.3298611640930176,2.778614044189453,1.967293620109558,1.0015825033187866,0.10621900856494904,0.11284983158111572,0.06448087096214294,-0.36394551396369934,-1.115910291671753,-0.995693564414978,-0.740376889705658,0.11552870273590088,1.4179210662841797,0.11217048764228821...] with an element-wise tolerance of {"absoluteThreshold":0.0000016280238925805544,"relativeThreshold":0}. 
+PASS   5.1-in explicit: Channel 1 equals [0,0,0,3.3298611640930176,2.778614044189453,1.967293620109558,1.0015825033187866,0.10621900856494904,0.11284983158111572,0.06448087096214294,-0.36394551396369934,-1.115910291671753,-0.995693564414978,-0.740376889705658,0.11552870273590088,1.4179210662841797...] with an element-wise tolerance of {"absoluteThreshold":0.0000016280238925805544,"relativeThreshold":0}. 
+PASS < [5.1-channel input explicit mode] All assertions passed. (total 2 assertions) 
+PASS # AUDIT TASK RUNNER FINISHED: 10 tasks ran successfully.

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt (266683 => 266684)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt	2020-09-06 23:09:39 UTC (rev 266684)
@@ -15,97 +15,39 @@
 PASS   new AudioBuffer({numberOfChannels: 2, length: 4, sampleRate: 8192}) did not throw an exception. 
 PASS < [initialize] All assertions passed. (total 1 assertions) 
 PASS > [1-channel input] produces 2-channel output 
-PASS   1: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.5265977382659912,-1.5727125406265259,-1.8001943826675415,-1.6267807483673096...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
-PASS   1: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.5265977382659912,-1.5727125406265259,-1.8001943826675415...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   1: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.526597797870636,-1.5727124214172363,-1.8001943826675415,-1.62678062915802...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   1: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.526597797870636,-1.5727124214172363,-1.8001943826675415...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
 PASS < [1-channel input] All assertions passed. (total 2 assertions) 
 PASS > [2-channel input] produces 2-channel output 
-PASS   2: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,1.818056344985962,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798327207565308,1.3096126317977905,-0.5365101099014282,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531,-1.4375803470611572...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
-PASS   2: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,1.818056344985962,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798327207565308,1.3096126317977905,-0.5365101099014282,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   2: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,1.8180564641952515,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798328399658203,1.3096126317977905,-0.536510169506073,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531,-1.4375803470611572...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   2: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,1.8180564641952515,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798328399658203,1.3096126317977905,-0.536510169506073,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
 PASS < [2-channel input] All assertions passed. (total 2 assertions) 
 PASS > [3-channel input] 3->2 downmix producing 2-channel output 
-FAIL X 3: Channel 0 does not equal [0,0,0.9485263228416443,0.8472320437431335,1.818056344985962,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798327207565308,1.3096126317977905,-0.5365101099014282,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531,-1.4375803470611572...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	7.1525573730468750e-7
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	7.1525573730468750e-7
-	[4]	0.0000000000000000e+0	1.8180563449859619e+0	1.8180563449859619e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	[5]	0.0000000000000000e+0	1.6351237297058105e+0	1.6351237297058105e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	[6]	0.0000000000000000e+0	1.7563552856445313e+0	1.7563552856445313e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	...and 1273 more errors.
-	Max AbsError of 1.9512100219726563e+0 at index of 542.
-	[542]	0.0000000000000000e+0	1.9512100219726563e+0	1.9512100219726563e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	Max RelError of 1.0000000000000000e+0 at index of 2.
- assert_true: expected true got false
-FAIL X 3: Channel 1 does not equal [0,0,0,0.9485263228416443,0.8472320437431335,1.818056344985962,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798327207565308,1.3096126317977905,-0.5365101099014282,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}.
-	Index	Actual			Expected		AbsError		RelError		Test threshold
-	[3]	0.0000000000000000e+0	9.4852632284164429e-1	9.4852632284164429e-1	1.0000000000000000e+0	7.1525573730468750e-7
-	[4]	0.0000000000000000e+0	8.4723204374313354e-1	8.4723204374313354e-1	1.0000000000000000e+0	7.1525573730468750e-7
-	[5]	0.0000000000000000e+0	1.8180563449859619e+0	1.8180563449859619e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	[6]	0.0000000000000000e+0	1.6351237297058105e+0	1.6351237297058105e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	[7]	0.0000000000000000e+0	1.7563552856445313e+0	1.7563552856445313e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	...and 1272 more errors.
-	Max AbsError of 1.9512100219726563e+0 at index of 543.
-	[543]	0.0000000000000000e+0	1.9512100219726563e+0	1.9512100219726563e+0	1.0000000000000000e+0	7.1525573730468750e-7
-	Max RelError of 1.0000000000000000e+0 at index of 3.
- assert_true: expected true got false
-FAIL < [3-channel input] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   3: Channel 0 equals [0,0,0.9485263228416443,0.8472320437431335,1.8180564641952515,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798328399658203,1.3096126317977905,-0.536510169506073,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531,-1.4375803470611572...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   3: Channel 1 equals [0,0,0,0.9485263228416443,0.8472320437431335,1.8180564641952515,1.6351237297058105,1.7563552856445312,1.6286998987197876,1.7798328399658203,1.3096126317977905,-0.536510169506073,-1.5863292217254639,-1.808717966079712,-1.5926569700241089,-1.8038825988769531...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS < [3-channel input] All assertions passed. (total 2 assertions) 
 PASS > [4-channel input] 4->2 downmix producing 2-channel output 
-PASS   4: Channel 0 equals [0,0,0.9734256267547607,0.8085750341415405,1.831641674041748,1.6426398754119873,1.0671128034591675,0.11098088324069977,0.06545668840408325,-0.29284289479255676,-0.7969464659690857,-0.007874995470046997,-0.029948651790618896,0.06689149141311646,-0.2781907618045807,-1.2002575397491455...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
-PASS   4: Channel 1 equals [0,0,0,0.9734256267547607,0.8085750341415405,1.831641674041748,1.6426398754119873,1.0671128034591675,0.11098088324069977,0.06545668840408325,-0.29284289479255676,-0.7969464659690857,-0.007874995470046997,-0.029948651790618896,0.06689149141311646,-0.2781907618045807...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   4: Channel 0 equals [0,0,0.9734256267547607,0.8085750341415405,1.831641674041748,1.6426398754119873,1.0671128034591675,0.11098091304302216,0.06545668840408325,-0.29284289479255676,-0.7969465255737305,-0.007875025272369385,-0.02994862198829651,0.06689146161079407,-0.2781907320022583,-1.2002575397491455...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
+PASS   4: Channel 1 equals [0,0,0,0.9734256267547607,0.8085750341415405,1.831641674041748,1.6426398754119873,1.0671128034591675,0.11098091304302216,0.06545668840408325,-0.29284289479255676,-0.7969465255737305,-0.007875025272369385,-0.02994862198829651,0.06689146161079407,-0.2781907320022583...] with an element-wise tolerance of {"absoluteThreshold":7.152557373046875e-7,"relativeThreshold":0}. 
 PASS < [4-channel input] All assertions passed. (total 2 assertions) 
 PASS > [5.1-channel input] 5.1->2 downmix producing 2-channel output 
-PASS   5.1: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,3.943439245223999,2.6875929832458496,1.0334471464157104,0.5752094984054565,1.1987407207489014,1.1847302913665771,-0.41883009672164917,-2.212879180908203,-2.9619672298431396,-1.2789843082427979,0.2622532546520233,0.6033463478088379...] with an element-wise tolerance of {"absoluteThreshold":0.0000017267801015661442,"relativeThreshold":0}. 
-PASS   5.1: Channel 1 equals [0,0,0,2.302107334136963,2.0779101848602295,3.943439245223999,2.6875929832458496,1.0334471464157104,0.5752094984054565,1.1987407207489014,1.1847302913665771,-0.41883009672164917,-2.212879180908203,-2.9619672298431396,-1.2789843082427979,0.2622532546520233...] with an element-wise tolerance of {"absoluteThreshold":0.0000017267801015661442,"relativeThreshold":0}. 
+PASS   5.1: Channel 0 equals [0,0,2.302107334136963,2.0779101848602295,3.943439245223999,2.6875932216644287,1.0334471464157104,0.5752095580101013,1.198740839958191,1.1847302913665771,-0.4188303053379059,-2.212879180908203,-2.9619669914245605,-1.2789843082427979,0.2622533142566681,0.6033463478088379...] with an element-wise tolerance of {"absoluteThreshold":0.0000017267801015661442,"relativeThreshold":0}. 
+PASS   5.1: Channel 1 equals [0,0,0,2.302107334136963,2.0779101848602295,3.943439245223999,2.6875932216644287,1.0334471464157104,0.5752095580101013,1.198740839958191,1.1847302913665771,-0.4188303053379059,-2.212879180908203,-2.9619669914245605,-1.2789843082427979,0.2622533142566681...] with an element-wise tolerance of {"absoluteThreshold":0.0000017267801015661442,"relativeThreshold":0}. 
 PASS < [5.1-channel input] All assertions passed. (total 2 assertions) 
 PASS > [delayed buffer set] Delayed set of 4-channel response 
 PASS   Output with delayed setting of convolver buffer is not constantly 0 (contains 767 different values). 
 PASS < [delayed buffer set] All assertions passed. (total 1 assertions) 
 PASS > [count 1, 2-channel in] 2->1 downmix because channel count is 1 
-FAIL X Convolver count 1, stereo in: output 0 expected to be equal to the array [0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.5265977382659912,-1.5727125406265259,-1.8001943826675415,-1.6267807483673096...] but differs in 1278 places:
-	Index	Actual			Expected
-	[2]	0.0000000000000000e+0	9.4852632284164429e-1
-	[3]	0.0000000000000000e+0	8.4723204374313354e-1
-	[4]	0.0000000000000000e+0	1.7718825340270996e+0
-	[5]	0.0000000000000000e+0	1.7117781639099121e+0
-	...and 1274 more errors. assert_true: expected true got false
-FAIL X Convolver count 1, stereo in: output 1 expected to be equal to the array [0,0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.5265977382659912,-1.5727125406265259,-1.8001943826675415...] but differs in 1277 places:
-	Index	Actual			Expected
-	[3]	0.0000000000000000e+0	9.4852632284164429e-1
-	[4]	0.0000000000000000e+0	8.4723204374313354e-1
-	[5]	0.0000000000000000e+0	1.7718825340270996e+0
-	[6]	0.0000000000000000e+0	1.7117781639099121e+0
-	...and 1273 more errors. assert_true: expected true got false
-FAIL < [count 1, 2-channel in] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   Convolver count 1, stereo in: output 0 is identical to the array [0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.526597797870636,-1.5727124214172363,-1.8001943826675415,-1.62678062915802...]. 
+PASS   Convolver count 1, stereo in: output 1 is identical to the array [0,0,0,0.9485263228416443,0.8472320437431335,1.7718825340270996,1.711778163909912,1.6687812805175781,1.7225778102874756,1.6410211324691772,1.8474152088165283,1.193971872329712,0.20856016874313354,-0.526597797870636,-1.5727124214172363,-1.8001943826675415...]. 
+PASS < [count 1, 2-channel in] All assertions passed. (total 2 assertions) 
 PASS > [count 1, 4-channel in] 4->1 downmix because channel count is 1 
-FAIL X Convolver count 1, 4-channel in: output 0 expected to be equal to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] but differs in 1278 places:
-	Index	Actual			Expected
-	[2]	9.7270292043685913e-1	0.0000000000000000e+0
-	[3]	8.0673760175704956e-1	0.0000000000000000e+0
-	[4]	1.8450587987899780e+0	0.0000000000000000e+0
-	[5]	1.3159036636352539e+0	0.0000000000000000e+0
-	...and 1274 more errors. assert_true: expected true got false
-FAIL X Convolver count 1, 4-channel in: output 1 expected to be equal to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] but differs in 1277 places:
-	Index	Actual			Expected
-	[3]	9.7270292043685913e-1	0.0000000000000000e+0
-	[4]	8.0673760175704956e-1	0.0000000000000000e+0
-	[5]	1.8450587987899780e+0	0.0000000000000000e+0
-	[6]	1.3159036636352539e+0	0.0000000000000000e+0
-	...and 1273 more errors. assert_true: expected true got false
-FAIL < [count 1, 4-channel in] 2 out of 2 assertions were failed. assert_true: expected true got false
+PASS   Convolver count 1, 4-channel in: output 0 is identical to the array [0,0,0.9727029204368591,0.8067376017570496,1.845058798789978,1.315903663635254,0.9772488474845886,0.33171993494033813,-0.2656707167625427,-0.20001929998397827,-0.38373589515686035,0.028485625982284546,-0.19134946167469025,-0.32985925674438477,-0.1601860225200653,-0.6186204552650452...]. 
+PASS   Convolver count 1, 4-channel in: output 1 is identical to the array [0,0,0,0.9727029204368591,0.8067376017570496,1.845058798789978,1.315903663635254,0.9772488474845886,0.33171993494033813,-0.2656707167625427,-0.20001929998397827,-0.38373589515686035,0.028485625982284546,-0.19134946167469025,-0.32985925674438477,-0.1601860225200653...]. 
+PASS < [count 1, 4-channel in] All assertions passed. (total 2 assertions) 
 PASS > [count 1, 5.1-channel in] 5.1->1 downmix because channel count is 1 
-FAIL X Convolver count 1, 5.1 channel in: output 0 expected to be equal to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] but differs in 1278 places:
-	Index	Actual			Expected
-	[2]	3.3298611640930176e+0	0.0000000000000000e+0
-	[3]	2.7786140441894531e+0	0.0000000000000000e+0
-	[4]	5.2971544265747070e+0	0.0000000000000000e+0
-	[5]	3.7801966667175293e+0	0.0000000000000000e+0
-	...and 1274 more errors. assert_true: expected true got false
-FAIL X Convolver count 1, 5.1 channel in: output 1 expected to be equal to the array [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] but differs in 1277 places:
-	Index	Actual			Expected
-	[3]	3.3298611640930176e+0	0.0000000000000000e+0
-	[4]	2.7786140441894531e+0	0.0000000000000000e+0
-	[5]	5.2971544265747070e+0	0.0000000000000000e+0
-	[6]	3.7801966667175293e+0	0.0000000000000000e+0
-	...and 1273 more errors. assert_true: expected true got false
-FAIL < [count 1, 5.1-channel in] 2 out of 2 assertions were failed. assert_true: expected true got false
-FAIL # AUDIT TASK RUNNER FINISHED: 4 out of 10 tasks were failed. assert_true: expected true got false
+PASS   Convolver count 1, 5.1 channel in: output 0 is identical to the array [0,0,3.3298611640930176,2.778614044189453,5.297154903411865,3.7801966667175293,2.073512554168701,1.1144323348999023,0.17069987952709198,-0.2510956823825836,-1.0514293909072876,-1.359639048576355,-1.8562872409820557,-0.8801648616790771,0.6775441765785217,0.2276991903781891...]. 
+PASS   Convolver count 1, 5.1 channel in: output 1 is identical to the array [0,0,0,3.3298611640930176,2.778614044189453,5.297154903411865,3.7801966667175293,2.073512554168701,1.1144323348999023,0.17069987952709198,-0.2510956823825836,-1.0514293909072876,-1.359639048576355,-1.8562872409820557,-0.8801648616790771,0.6775441765785217...]. 
+PASS < [count 1, 5.1-channel in] All assertions passed. (total 2 assertions) 
+PASS # AUDIT TASK RUNNER FINISHED: 10 tasks ran successfully.

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt (266683 => 266684)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt	2020-09-06 23:09:39 UTC (rev 266684)
@@ -1,5 +1,5 @@
 
-FAIL speakers, initially mono assert_approx_equals: output at 242 in channel 0 expected 0.49999764561653137 +/- 7.152557373046875e-7 but got 0
-FAIL discrete assert_approx_equals: output at 242 in channel 0 expected 0.49999764561653137 +/- 7.152557373046875e-7 but got 0
-FAIL speakers, initially stereo assert_approx_equals: output at 242 in channel 0 expected 0.49999764561653137 +/- 7.152557373046875e-7 but got 0
+PASS speakers, initially mono 
+PASS discrete 
+PASS speakers, initially stereo

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt (266683 => 266684)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt	2020-09-06 23:09:39 UTC (rev 266684)
@@ -3,7 +3,7 @@
 PASS Executing "test" 
 PASS Audit report 
 PASS > [test] Test convolver with real-time context 
-FAIL X SNR is not greater than or equal to 88.457. Got 77.00623887904952. assert_true: expected true got false
-FAIL < [test] 1 out of 1 assertions were failed. assert_true: expected true got false
-FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 1 tasks were failed. assert_true: expected true got false
+PASS   SNR is greater than or equal to 88.457. 
+PASS < [test] All assertions passed. (total 1 assertions) 
+PASS # AUDIT TASK RUNNER FINISHED: 1 tasks ran successfully.

Modified: trunk/Source/WebCore/ChangeLog (266683 => 266684)


--- trunk/Source/WebCore/ChangeLog	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/Source/WebCore/ChangeLog	2020-09-06 23:09:39 UTC (rev 266684)
@@ -1,3 +1,23 @@
+2020-09-06  Chris Dumez  <[email protected]>
+
+        ConvolverNode incorrectly outputs silence because m_reverb is null
+        https://bugs.webkit.org/show_bug.cgi?id=216230
+
+        Reviewed by Darin Adler.
+
+        ConvolverNode relies on m_reverb to to audio processing. m_reverb would get initialized
+        when calling ConvolverNode::setBuffer(). However, setting the buffer would cause
+        ConvolverNode::checkNumberOfChannelsForInput(), which could cause unitialize() and then
+        initialize() to get called. The issue was that unitialize() would null out m_reverb
+        and nothing would re-initialize it.
+
+        No new tests, rebaselined existing tests.
+
+        * Modules/webaudio/ConvolverNode.cpp:
+        (WebCore::ConvolverNode::initialize): Deleted.
+        (WebCore::ConvolverNode::uninitialize): Deleted.
+        * Modules/webaudio/ConvolverNode.h:
+
 2020-09-06  Myles C. Maxfield  <[email protected]>
 
         Letter-spacing should disable ligatures

Modified: trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp (266683 => 266684)


--- trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp	2020-09-06 23:09:39 UTC (rev 266684)
@@ -123,23 +123,6 @@
         m_reverb->reset();
 }
 
-void ConvolverNode::initialize()
-{
-    if (isInitialized())
-        return;
-
-    AudioNode::initialize();
-}
-
-void ConvolverNode::uninitialize()
-{
-    if (!isInitialized())
-        return;
-
-    m_reverb = nullptr;
-    AudioNode::uninitialize();
-}
-
 ExceptionOr<void> ConvolverNode::setBuffer(RefPtr<AudioBuffer>&& buffer)
 {
     ASSERT(isMainThread());

Modified: trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h (266683 => 266684)


--- trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h	2020-09-06 22:20:54 UTC (rev 266683)
+++ trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h	2020-09-06 23:09:39 UTC (rev 266684)
@@ -59,8 +59,6 @@
 
     void process(size_t framesToProcess) final;
     void reset() final;
-    void initialize() final;
-    void uninitialize() final;
     void checkNumberOfChannelsForInput(AudioNodeInput*) final;
 
     std::unique_ptr<Reverb> m_reverb;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to