Title: [266708] trunk/Source/WebCore
- Revision
- 266708
- Author
- [email protected]
- Date
- 2020-09-07 12:04:25 -0700 (Mon, 07 Sep 2020)
Log Message
Fix https://trac.webkit.org/changeset/266508 as per post-commit comments
https://bugs.webkit.org/show_bug.cgi?id=216242
Reviewed by Alex Christensen.
No change of behavior.
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::toRTCRtpCapabilities):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (266707 => 266708)
--- trunk/Source/WebCore/ChangeLog 2020-09-07 18:54:23 UTC (rev 266707)
+++ trunk/Source/WebCore/ChangeLog 2020-09-07 19:04:25 UTC (rev 266708)
@@ -1,3 +1,15 @@
+2020-09-07 Youenn Fablet <[email protected]>
+
+ Fix https://trac.webkit.org/changeset/266508 as per post-commit comments
+ https://bugs.webkit.org/show_bug.cgi?id=216242
+
+ Reviewed by Alex Christensen.
+
+ No change of behavior.
+
+ * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+ (WebCore::toRTCRtpCapabilities):
+
2020-09-07 Sam Weinig <[email protected]>
[WebIDL] Support extended attributes on includes statements to allow for conditionalized inclusion
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp (266707 => 266708)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp 2020-09-07 18:54:23 UTC (rev 266707)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp 2020-09-07 19:04:25 UTC (rev 266708)
@@ -403,13 +403,8 @@
StringBuilder sdpFmtpLine;
bool hasParameter = false;
for (auto& parameter : codec.parameters) {
- if (hasParameter)
- sdpFmtpLine.append(";");
- else
- hasParameter = true;
- sdpFmtpLine.append(StringView(parameter.first.data(), parameter.first.length()));
- sdpFmtpLine.append("=");
- sdpFmtpLine.append(StringView(parameter.second.data(), parameter.second.length()));
+ sdpFmtpLine.append(hasParameter ? ";" : "", StringView(parameter.first.data(), parameter.first.length()), '=', StringView(parameter.second.data(), parameter.second.length()));
+ hasParameter = true;
}
capabilities.codecs.uncheckedAppend(RTCRtpCodecCapability { fromStdString(codec.mime_type()), static_cast<uint32_t>(codec.clock_rate ? *codec.clock_rate : 0), toChannels(codec.num_channels), sdpFmtpLine.toString() });
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
