Diff
Modified: trunk/Source/WebCore/ChangeLog (266720 => 266721)
--- trunk/Source/WebCore/ChangeLog 2020-09-08 11:59:42 UTC (rev 266720)
+++ trunk/Source/WebCore/ChangeLog 2020-09-08 13:18:46 UTC (rev 266721)
@@ -1,3 +1,28 @@
+2020-09-08 Víctor Manuel Jáquez Leal <[email protected]>
+
+ [GStreamer] Follow-up of "Convert custom GObject subclasses to WEBKIT_DEFINE_TYPE"
+ https://bugs.webkit.org/show_bug.cgi?id=204673
+ <rdar://problem/68455348>
+
+ Reviewed by Carlos Garcia Campos.
+
+ This a continuation of 204673 since a post-merge review came up: it
+ was also needed to remove g_type_class_add_private() calls.
+
+ No new tests needed.
+
+ * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+ (_WebKitWebAudioSrcPrivate::_WebKitWebAudioSrcPrivate):
+ (webkit_web_audio_src_class_init):
+ * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
+ (webkit_video_sink_class_init):
+ * platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
+ (webkit_media_clear_key_decrypt_class_init):
+ * platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
+ (webkit_media_common_encryption_decrypt_class_init):
+ * platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp:
+ (webkit_media_thunder_decrypt_class_init):
+
2020-09-08 Rob Buis <[email protected]>
Fix crash in image-loading-lazy-slow.html WPT test
Modified: trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp (266720 => 266721)
--- trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2020-09-08 11:59:42 UTC (rev 266720)
+++ trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp 2020-09-08 13:18:46 UTC (rev 266721)
@@ -80,9 +80,6 @@
{
sourcePad = webkitGstGhostPadFromStaticTemplate(&srcTemplate, "src", nullptr);
- provider = nullptr;
- bus = nullptr;
-
g_rec_mutex_init(&mutex);
// GAP buffer support is enabled only for GStreamer 1.12.5 because of a
@@ -190,8 +187,6 @@
g_param_spec_uint("frames", "frames",
"Number of audio frames to pull at each iteration",
0, G_MAXUINT8, 128, flags));
-
- g_type_class_add_private(webKitWebAudioSrcClass, sizeof(WebKitWebAudioSrcPrivate));
}
static void webKitWebAudioSrcConstructed(GObject* object)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp (266720 => 266721)
--- trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp 2020-09-08 11:59:42 UTC (rev 266720)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp 2020-09-08 13:18:46 UTC (rev 266721)
@@ -277,8 +277,6 @@
gst_element_class_add_pad_template(elementClass, gst_static_pad_template_get(&s_sinkTemplate));
gst_element_class_set_metadata(elementClass, "WebKit video sink", "Sink/Video", "Sends video data from a GStreamer pipeline to WebKit", "Igalia, Alp Toker <[email protected]>");
- g_type_class_add_private(klass, sizeof(WebKitVideoSinkPrivate));
-
gobjectClass->constructed = webkitVideoSinkConstructed;
baseSinkClass->unlock = webkitVideoSinkUnlock;
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp (266720 => 266721)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp 2020-09-08 11:59:42 UTC (rev 266720)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp 2020-09-08 13:18:46 UTC (rev 266721)
@@ -84,8 +84,6 @@
cencClass->protectionSystemId = GST_DEBUG_FUNCPTR(protectionSystemId);
cencClass->cdmProxyAttached = GST_DEBUG_FUNCPTR(cdmProxyAttached);
cencClass->decrypt = GST_DEBUG_FUNCPTR(decrypt);
-
- g_type_class_add_private(klass, sizeof(WebKitMediaClearKeyDecryptPrivate));
}
static const char* protectionSystemId(WebKitMediaCommonEncryptionDecrypt*)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp (266720 => 266721)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp 2020-09-08 11:59:42 UTC (rev 266720)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp 2020-09-08 13:18:46 UTC (rev 266721)
@@ -77,8 +77,6 @@
baseTransformClass->transform_caps = GST_DEBUG_FUNCPTR(transformCaps);
baseTransformClass->transform_ip_on_passthrough = FALSE;
baseTransformClass->sink_event = GST_DEBUG_FUNCPTR(sinkEventHandler);
-
- g_type_class_add_private(klass, sizeof(WebKitMediaCommonEncryptionDecryptPrivate));
}
static void constructed(GObject* object)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp (266720 => 266721)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp 2020-09-08 11:59:42 UTC (rev 266720)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp 2020-09-08 13:18:46 UTC (rev 266721)
@@ -103,8 +103,6 @@
commonClass->protectionSystemId = GST_DEBUG_FUNCPTR(protectionSystemId);
commonClass->cdmProxyAttached = GST_DEBUG_FUNCPTR(cdmProxyAttached);
commonClass->decrypt = GST_DEBUG_FUNCPTR(decrypt);
-
- g_type_class_add_private(klass, sizeof(WebKitMediaThunderDecryptPrivate));
}
static const char* protectionSystemId(WebKitMediaCommonEncryptionDecrypt* self)
