Title: [266750] trunk/Source/WebKit
- Revision
- 266750
- Author
- [email protected]
- Date
- 2020-09-08 14:10:32 -0700 (Tue, 08 Sep 2020)
Log Message
Null check m_layerHostingContext in TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=216282
<rdar://problem/64933878>
Patch by Alex Christensen <[email protected]> on 2020-09-08
Reviewed by Tim Horton.
There's no reason to dereference null here. Let's not crash.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (266749 => 266750)
--- trunk/Source/WebKit/ChangeLog 2020-09-08 21:10:28 UTC (rev 266749)
+++ trunk/Source/WebKit/ChangeLog 2020-09-08 21:10:32 UTC (rev 266750)
@@ -1,3 +1,16 @@
+2020-09-08 Alex Christensen <[email protected]>
+
+ Null check m_layerHostingContext in TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded
+ https://bugs.webkit.org/show_bug.cgi?id=216282
+ <rdar://problem/64933878>
+
+ Reviewed by Tim Horton.
+
+ There's no reason to dereference null here. Let's not crash.
+
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+ (WebKit::TiledCoreAnimationDrawingArea::sendDidFirstLayerFlushIfNeeded):
+
2020-09-08 Youenn Fablet <[email protected]>
Tighten checks when creating an audio buffer list
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (266749 => 266750)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2020-09-08 21:10:28 UTC (rev 266749)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2020-09-08 21:10:32 UTC (rev 266750)
@@ -113,7 +113,7 @@
// Let the first commit complete before sending.
[CATransaction addCommitHandler:[this, weakThis = makeWeakPtr(*this)] {
- if (!weakThis)
+ if (!weakThis || !m_layerHostingContext)
return;
LayerTreeContext layerTreeContext;
layerTreeContext.contextID = m_layerHostingContext->contextID();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
